| Message ID | 20210219212035.3088189-1-marcelo.cerri@canonical.com |
|---|---|
| Headers | show |
| Series | LP:#1916290 - Enforce CONFIG_DRM_BOCHS=m | expand |
On Fri, Feb 19, 2021 at 6:21 PM Marcelo Henrique Cerri <marcelo.cerri@canonical.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/1916290 > > [Impact] > > In LP:#1872863 we started to build and ship the bochs-drm.ko driver again, however this config wasn't enforced and because of that derivatives didn't inherit. > > We should enforce CONFIG_DRM_BOCHS=m to avoid problem in the future and to let the derivatives update their configuration to include it or not. > > [Testcase] > > This should be a no-op for bionic:linux causing no differences for the current kernel. For derivatives, it will prompt the kernel engineer to update the config or to annotate it. > > [Regression Potential] > > Since it's no-op, there's no regression potential > > --- > Marcelo Henrique Cerri (1): > UBUNTU: [Config] Enforce CONFIG_DRM_BOCHS=m > > debian.master/config/annotations | 1 + > 1 file changed, 1 insertion(+) > > -- > 2.25.1 > Very straightforward / non-invasive change, thanks Marcelo! Acked-by: Guilherme G. Piccoli <gpiccoli@canonical.com>
On 19/02/2021 21:20, Marcelo Henrique Cerri wrote: > BugLink: https://bugs.launchpad.net/bugs/1916290 > > [Impact] > > In LP:#1872863 we started to build and ship the bochs-drm.ko driver again, however this config wasn't enforced and because of that derivatives didn't inherit. > > We should enforce CONFIG_DRM_BOCHS=m to avoid problem in the future and to let the derivatives update their configuration to include it or not. > > [Testcase] > > This should be a no-op for bionic:linux causing no differences for the current kernel. For derivatives, it will prompt the kernel engineer to update the config or to annotate it. > > [Regression Potential] > > Since it's no-op, there's no regression potential > > --- > Marcelo Henrique Cerri (1): > UBUNTU: [Config] Enforce CONFIG_DRM_BOCHS=m > > debian.master/config/annotations | 1 + > 1 file changed, 1 insertion(+) > Looks OK to me. Acked-by: Colin Ian King <colin.king@canonical.com>
On 19.02.21 22:20, Marcelo Henrique Cerri wrote: > BugLink: https://bugs.launchpad.net/bugs/1916290 > > [Impact] > > In LP:#1872863 we started to build and ship the bochs-drm.ko driver again, however this config wasn't enforced and because of that derivatives didn't inherit. > > We should enforce CONFIG_DRM_BOCHS=m to avoid problem in the future and to let the derivatives update their configuration to include it or not. > > [Testcase] > > This should be a no-op for bionic:linux causing no differences for the current kernel. For derivatives, it will prompt the kernel engineer to update the config or to annotate it. > > [Regression Potential] > > Since it's no-op, there's no regression potential > > --- > Marcelo Henrique Cerri (1): > UBUNTU: [Config] Enforce CONFIG_DRM_BOCHS=m > > debian.master/config/annotations | 1 + > 1 file changed, 1 insertion(+) > Applied to B+F+G:linux/master-next. I deleted the BugLink reference to the already fixed bug (otherwise we have all sorts of issues, one being to ask the reporter of the fixed bug to test again). I also adjusted the new bug report to have nominations for focal and groovy. Which rises the question whether you also have ensured that hirsute/unstable contains the annotation. Please make sure to update the bug report to show the devel status correctly. -Stefan