diff mbox series

[v1,1/3] package/runc: bump to version 1.0.0-rc93

Message ID 20210210235203.2819535-1-christian@paral.in
State Superseded
Headers show
Series [v1,1/3] package/runc: bump to version 1.0.0-rc93 | expand

Commit Message

Christian Stewart Feb. 10, 2021, 11:52 p.m. UTC
https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc93

Signed-off-by: Christian Stewart <christian@paral.in>
---
 package/runc/runc.hash | 2 +-
 package/runc/runc.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard Feb. 11, 2021, 3:49 p.m. UTC | #1
>>>>> "Christian" == Christian Stewart <christian@paral.in> writes:

 > https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc93

Is this meant for master or next?

It is in the same series as security bumps, but I see the release notes
talks about a feature-rich release?

It also mentions the following:

For packagers the following changes have been made which will have impact on
your packaging of runc:

    The "selinux" and "apparmor" buildtags have been removed, and now all runc
    builds will have SELinux and AppArmor support enabled. Note that "seccomp"
    is still optional (though we very highly recommend you enable it).

But I see no changes related to this?
Christian Stewart Feb. 11, 2021, 9:11 p.m. UTC | #2
Hi Peter,

On Thu, Feb 11, 2021 at 7:49 AM Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "Christian" == Christian Stewart <christian@paral.in> writes:
>
>  > https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc93
>
> Is this meant for master or next?

Master.

> It is in the same series as security bumps, but I see the release notes
> talks about a feature-rich release?

Runc is now on their 93rd release candidate. Now is not the time to
decide to stop at #92.

> It also mentions the following:
>
> For packagers the following changes have been made which will have impact on
> your packaging of runc:
>
>     The "selinux" and "apparmor" buildtags have been removed, and now all runc
>     builds will have SELinux and AppArmor support enabled. Note that "seccomp"
>     is still optional (though we very highly recommend you enable it).
>
> But I see no changes related to this?

I don't have seccomp enabled on my systems, and docker + runc is still
working as per this series.

Additionally, I see that there are still conditional build tags
"linux,cgo,seccomp" in the code, which exclude seccomp unless the
seccomp build tag is set. So I don't think that the note in the
release notes is accurate - you still need the "seccomp" build tag for
runc to have seccomp support.

So everything is fine to merge this to master as-is. (Tested as well).

Best regards,
Christian Stewart
diff mbox series

Patch

diff --git a/package/runc/runc.hash b/package/runc/runc.hash
index d792947d5f..afe396368d 100644
--- a/package/runc/runc.hash
+++ b/package/runc/runc.hash
@@ -1,3 +1,3 @@ 
 # Locally computed
-sha256	28378df983a3c586ed3ec8c76a774a9b10f36a0c323590a284b801cce95cc61f  runc-1.0.0-rc92.tar.gz
+sha256  e42456078d2f76c925cdd656e4f423b918525d8188521de05e893b6bb473a6f8  runc-1.0.0-rc93.tar.gz
 sha256  552a739c3b25792263f731542238b92f6f8d07e9a488eae27e6c4690038a8243  LICENSE
diff --git a/package/runc/runc.mk b/package/runc/runc.mk
index c0de2783e4..ba2ab3081a 100644
--- a/package/runc/runc.mk
+++ b/package/runc/runc.mk
@@ -10,7 +10,7 @@  RUNC_LICENSE = Apache-2.0
 RUNC_LICENSE_FILES = LICENSE
 RUNC_CPE_ID_VENDOR = linuxfoundation
 RUNC_CPE_ID_VERSION = 1.0.0
-RUNC_CPE_ID_UPDATE = rc92
+RUNC_CPE_ID_UPDATE = rc93
 
 RUNC_LDFLAGS = -X main.version=$(RUNC_VERSION)
 RUNC_TAGS = cgo static_build