| Message ID | 20210204022415.20589-13-trini@konsulko.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [01/13] arm: nanopi2: Remove unused code | expand |
Hi Tom, On 2/4/21 3:24 AM, Tom Rini wrote: > These platforms never had to support an ATAGs-based Linux Kernel, so > remove the options. > > Cc: Kamil Lulko <kamil.lulko@gmail.com> > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Vikas Manocha <vikas.manocha@st.com> > Cc: Marek Vasut <marex@denx.de> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > I'm assuming, please correct me if I'm wrong. > --- > include/configs/stm32f429-discovery.h | 5 ----- > include/configs/stm32f429-evaluation.h | 5 ----- > include/configs/stm32f469-discovery.h | 5 ----- > include/configs/stm32f746-disco.h | 5 ----- > include/configs/stm32h743-disco.h | 5 ----- > include/configs/stm32h743-eval.h | 5 ----- > include/configs/stm32mp1.h | 5 ----- > 7 files changed, 35 deletions(-) > Yes you are right. It is inherited of the first U-boot porting (before full DM and FDT support). Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> For information the initialization parts can be removed in boards support (as no more used): gd->bd->bi_boot_params = gd->bd->bi_dram[0].start + 0x100; in ./board/st/ - stm32f429-evaluation/stm32f429-evaluation.c:54: - stm32h743-disco/stm32h743-disco.c:55: - stm32f429-discovery/stm32f429-discovery.c:60: - stm32mp1/stm32mp1.c:644: - stm32f746-disco/stm32f746-disco.c:129: - stm32f469-discovery/stm32f469-discovery.c:54: - stm32h743-eval/stm32h743-eval.c:55: But I will push a separate patch for this point. Just one question for other part of generic code which can be removed.... bi_boot_params should be under compilation BOOTM_ENABLE_TAGS flags ? In include/asm-generic/u-boot.h:70 struct bd_info { .... ulong bi_boot_params; /* where this board expects params */ ... }; and also params global variables, only used in setup_XXX functions ? arch/arm/lib/bootm.c:44: static struct tag *params; Regards Thanks Patrick
On Mon, Feb 08, 2021 at 05:34:50PM +0100, Patrick DELAUNAY wrote: [snip] > Just one question for other part of generic code which can be removed.... > > bi_boot_params should be under compilation BOOTM_ENABLE_TAGS flags ? > > In include/asm-generic/u-boot.h:70 > struct bd_info { > > .... > ulong bi_boot_params; /* where this board expects > params */ > > ... > > }; > > > and also params global variables, only used in setup_XXX functions ? > > arch/arm/lib/bootm.c:44: > static struct tag *params; With some further cleanup work to introduce a single symbol to say yes/no to ATAGS support, we could then cleanly condition out a few more bits of code and save some space, yes.
diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h index 9d029fbcc6f0..dbbce494759f 100644 --- a/include/configs/stm32f429-discovery.h +++ b/include/configs/stm32f429-discovery.h @@ -27,11 +27,6 @@ #define CONFIG_SYS_HZ_CLOCK 1000000 /* Timer is clocked at 1MHz */ -#define CONFIG_CMDLINE_TAG -#define CONFIG_SETUP_MEMORY_TAGS -#define CONFIG_INITRD_TAG -#define CONFIG_REVISION_TAG - #define CONFIG_SYS_CBSIZE 1024 #define CONFIG_SYS_MALLOC_LEN (2 << 20) diff --git a/include/configs/stm32f429-evaluation.h b/include/configs/stm32f429-evaluation.h index fefdb2dd1525..29a41e80676a 100644 --- a/include/configs/stm32f429-evaluation.h +++ b/include/configs/stm32f429-evaluation.h @@ -29,11 +29,6 @@ #define CONFIG_SYS_HZ_CLOCK 1000000 /* Timer is clocked at 1MHz */ -#define CONFIG_CMDLINE_TAG -#define CONFIG_SETUP_MEMORY_TAGS -#define CONFIG_INITRD_TAG -#define CONFIG_REVISION_TAG - #define CONFIG_SYS_CBSIZE 1024 #define CONFIG_SYS_MALLOC_LEN (1 * 1024 * 1024) diff --git a/include/configs/stm32f469-discovery.h b/include/configs/stm32f469-discovery.h index ba9f05a61b40..b9b932c65107 100644 --- a/include/configs/stm32f469-discovery.h +++ b/include/configs/stm32f469-discovery.h @@ -29,11 +29,6 @@ #define CONFIG_SYS_HZ_CLOCK 1000000 /* Timer is clocked at 1MHz */ -#define CONFIG_CMDLINE_TAG -#define CONFIG_SETUP_MEMORY_TAGS -#define CONFIG_INITRD_TAG -#define CONFIG_REVISION_TAG - #define CONFIG_SYS_CBSIZE 1024 #define CONFIG_SYS_MALLOC_LEN (1 * 1024 * 1024) diff --git a/include/configs/stm32f746-disco.h b/include/configs/stm32f746-disco.h index 08d050adfa51..b72b989c2c21 100644 --- a/include/configs/stm32f746-disco.h +++ b/include/configs/stm32f746-disco.h @@ -36,11 +36,6 @@ #define CONFIG_SYS_HZ_CLOCK 1000000 /* Timer is clocked at 1MHz */ -#define CONFIG_CMDLINE_TAG -#define CONFIG_SETUP_MEMORY_TAGS -#define CONFIG_INITRD_TAG -#define CONFIG_REVISION_TAG - #define CONFIG_SYS_CBSIZE 1024 #define CONFIG_SYS_MALLOC_LEN (1 * 1024 * 1024) diff --git a/include/configs/stm32h743-disco.h b/include/configs/stm32h743-disco.h index 6e10dbdfe945..e5bb08eec719 100644 --- a/include/configs/stm32h743-disco.h +++ b/include/configs/stm32h743-disco.h @@ -24,11 +24,6 @@ #define CONFIG_SYS_HZ_CLOCK 1000000 -#define CONFIG_CMDLINE_TAG -#define CONFIG_SETUP_MEMORY_TAGS -#define CONFIG_INITRD_TAG -#define CONFIG_REVISION_TAG - #define CONFIG_SYS_MAXARGS 16 #define CONFIG_SYS_MALLOC_LEN (1 * 1024 * 1024) diff --git a/include/configs/stm32h743-eval.h b/include/configs/stm32h743-eval.h index 268d39c7ad6a..89169f85d5ba 100644 --- a/include/configs/stm32h743-eval.h +++ b/include/configs/stm32h743-eval.h @@ -24,11 +24,6 @@ #define CONFIG_SYS_HZ_CLOCK 1000000 -#define CONFIG_CMDLINE_TAG -#define CONFIG_SETUP_MEMORY_TAGS -#define CONFIG_INITRD_TAG -#define CONFIG_REVISION_TAG - #define CONFIG_SYS_MAXARGS 16 #define CONFIG_SYS_MALLOC_LEN (1 * 1024 * 1024) diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h index 863b652ca4f7..e2e8a5d1a325 100644 --- a/include/configs/stm32mp1.h +++ b/include/configs/stm32mp1.h @@ -33,11 +33,6 @@ #define CONFIG_LOADADDR 0xc2000000 #define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR -/* ATAGs */ -#define CONFIG_CMDLINE_TAG -#define CONFIG_SETUP_MEMORY_TAGS -#define CONFIG_INITRD_TAG - /* * For booting Linux, use the first 256 MB of memory, since this is * the maximum mapped by the Linux kernel during initialization.
These platforms never had to support an ATAGs-based Linux Kernel, so remove the options. Cc: Kamil Lulko <kamil.lulko@gmail.com> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> Cc: Patrice Chotard <patrice.chotard@foss.st.com> Cc: Vikas Manocha <vikas.manocha@st.com> Cc: Marek Vasut <marex@denx.de> Signed-off-by: Tom Rini <trini@konsulko.com> --- I'm assuming, please correct me if I'm wrong. --- include/configs/stm32f429-discovery.h | 5 ----- include/configs/stm32f429-evaluation.h | 5 ----- include/configs/stm32f469-discovery.h | 5 ----- include/configs/stm32f746-disco.h | 5 ----- include/configs/stm32h743-disco.h | 5 ----- include/configs/stm32h743-eval.h | 5 ----- include/configs/stm32mp1.h | 5 ----- 7 files changed, 35 deletions(-)