| Message ID | 1611024723-14293-1-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | target/riscv: Declare csr_ops[] with a known size | expand |
On 1/19/21 3:52 AM, Bin Meng wrote: > From: Bin Meng <bin.meng@windriver.com> > > csr_ops[] is currently declared with an unknown size in cpu.h. > Since the array size is known, let's do a complete declaration. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > --- > > target/riscv/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On Mon, Jan 18, 2021 at 6:52 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > > csr_ops[] is currently declared with an unknown size in cpu.h. > Since the array size is known, let's do a complete declaration. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > --- > > target/riscv/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h > index 02758ae..419a214 100644 > --- a/target/riscv/cpu.h > +++ b/target/riscv/cpu.h > @@ -487,7 +487,7 @@ enum { > }; > > /* CSR function table */ > -extern riscv_csr_operations csr_ops[]; > +extern riscv_csr_operations csr_ops[CSR_TABLE_SIZE]; > > void riscv_get_csr_ops(int csrno, riscv_csr_operations *ops); > void riscv_set_csr_ops(int csrno, riscv_csr_operations *ops); > -- > 2.7.4 > >
On Mon, Jan 18, 2021 at 6:52 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > csr_ops[] is currently declared with an unknown size in cpu.h. > Since the array size is known, let's do a complete declaration. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> Thanks! Applied to riscv-to-apply.next Alistair > --- > > target/riscv/cpu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h > index 02758ae..419a214 100644 > --- a/target/riscv/cpu.h > +++ b/target/riscv/cpu.h > @@ -487,7 +487,7 @@ enum { > }; > > /* CSR function table */ > -extern riscv_csr_operations csr_ops[]; > +extern riscv_csr_operations csr_ops[CSR_TABLE_SIZE]; > > void riscv_get_csr_ops(int csrno, riscv_csr_operations *ops); > void riscv_set_csr_ops(int csrno, riscv_csr_operations *ops); > -- > 2.7.4 > >
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 02758ae..419a214 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -487,7 +487,7 @@ enum { }; /* CSR function table */ -extern riscv_csr_operations csr_ops[]; +extern riscv_csr_operations csr_ops[CSR_TABLE_SIZE]; void riscv_get_csr_ops(int csrno, riscv_csr_operations *ops); void riscv_set_csr_ops(int csrno, riscv_csr_operations *ops);