| Message ID | 20201230115408.492565-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | PCI: qcom: fixup PCIe support on sm8250 | expand |
On Wed, Dec 30, 2020 at 02:54:06PM +0300, Dmitry Baryshkov wrote: > SM8250 SoC requires another clock to be up to power up the translation > unit. Add necessary bindings and driver support. > So what is the exact issue you're facing? Thanks, Mani >
Hi Mani, On Wed, 30 Dec 2020 at 15:35, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > On Wed, Dec 30, 2020 at 02:54:06PM +0300, Dmitry Baryshkov wrote: > > SM8250 SoC requires another clock to be up to power up the translation > > unit. Add necessary bindings and driver support. > > > > So what is the exact issue you're facing? IOMMU timeouts for PCIe0 device (WiFi)
On Wed, Dec 30, 2020 at 03:38:12PM +0300, Dmitry Baryshkov wrote: > Hi Mani, > > On Wed, 30 Dec 2020 at 15:35, Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > > > > On Wed, Dec 30, 2020 at 02:54:06PM +0300, Dmitry Baryshkov wrote: > > > SM8250 SoC requires another clock to be up to power up the translation > > > unit. Add necessary bindings and driver support. > > > > > > > So what is the exact issue you're facing? > > IOMMU timeouts for PCIe0 device (WiFi) > Strange. I never observed this issue while testing with onboard QCA6390. Is it only happening on v5.11? Thanks, Mani > -- > With best wishes > Dmitry
On Wed, 30 Dec 2020 at 15:46, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > On Wed, Dec 30, 2020 at 03:38:12PM +0300, Dmitry Baryshkov wrote: > > Hi Mani, > > > > On Wed, 30 Dec 2020 at 15:35, Manivannan Sadhasivam > > <manivannan.sadhasivam@linaro.org> wrote: > > > > > > On Wed, Dec 30, 2020 at 02:54:06PM +0300, Dmitry Baryshkov wrote: > > > > SM8250 SoC requires another clock to be up to power up the translation > > > > unit. Add necessary bindings and driver support. > > > > > > > > > > So what is the exact issue you're facing? > > > > IOMMU timeouts for PCIe0 device (WiFi) > > > > Strange. I never observed this issue while testing with onboard QCA6390. Is it > only happening on v5.11? No, I've faced it with 5.10 also. Don't remember about 5.9. Downstream 4.19 also has this patch. It well might be that on your board the firmware enables this clock. However to be on a safe side I think we should enable it too.
On Wed, Dec 30, 2020 at 03:57:54PM +0300, Dmitry Baryshkov wrote: > On Wed, 30 Dec 2020 at 15:46, Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > > > > On Wed, Dec 30, 2020 at 03:38:12PM +0300, Dmitry Baryshkov wrote: > > > Hi Mani, > > > > > > On Wed, 30 Dec 2020 at 15:35, Manivannan Sadhasivam > > > <manivannan.sadhasivam@linaro.org> wrote: > > > > > > > > On Wed, Dec 30, 2020 at 02:54:06PM +0300, Dmitry Baryshkov wrote: > > > > > SM8250 SoC requires another clock to be up to power up the translation > > > > > unit. Add necessary bindings and driver support. > > > > > > > > > > > > > So what is the exact issue you're facing? > > > > > > IOMMU timeouts for PCIe0 device (WiFi) > > > > > > > Strange. I never observed this issue while testing with onboard QCA6390. Is it > > only happening on v5.11? > > No, I've faced it with 5.10 also. Don't remember about 5.9. Downstream > 4.19 also has this patch. > It well might be that on your board the firmware enables this clock. > However to be on a safe side I think we should enable it too. > Okay, then please remove the optional field and make it as a required one. Thanks, Mani > -- > With best wishes > Dmitry
Hi Mani, On Wed, 30 Dec 2020 at 16:06, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > On Wed, Dec 30, 2020 at 03:57:54PM +0300, Dmitry Baryshkov wrote: > > On Wed, 30 Dec 2020 at 15:46, Manivannan Sadhasivam > > <manivannan.sadhasivam@linaro.org> wrote: > > > > > > On Wed, Dec 30, 2020 at 03:38:12PM +0300, Dmitry Baryshkov wrote: > > > > Hi Mani, > > > > > > > > On Wed, 30 Dec 2020 at 15:35, Manivannan Sadhasivam > > > > <manivannan.sadhasivam@linaro.org> wrote: > > > > > > > > > > On Wed, Dec 30, 2020 at 02:54:06PM +0300, Dmitry Baryshkov wrote: > > > > > > SM8250 SoC requires another clock to be up to power up the translation > > > > > > unit. Add necessary bindings and driver support. > > > > > > > > > > > > > > > > So what is the exact issue you're facing? > > > > > > > > IOMMU timeouts for PCIe0 device (WiFi) > > > > > > > > > > Strange. I never observed this issue while testing with onboard QCA6390. Is it > > > only happening on v5.11? > > > > No, I've faced it with 5.10 also. Don't remember about 5.9. Downstream > > 4.19 also has this patch. > > It well might be that on your board the firmware enables this clock. > > However to be on a safe side I think we should enable it too. > > > > Okay, then please remove the optional field and make it as a required one. Done.