| Message ID | 20201117010709.96914-1-pepe.schlehofer@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Petr Štetiar |
| Headers | show |
| Series | busybox: enable whois by default | expand |
Josef Schlehofer <pepe.schlehofer@gmail.com> [2020-11-17 02:07:09]: Hi, > Whois can identify who owns a domain and how to get reach owner. Providing > this tool in OpenWrt someone does not need to use websites for everything. I don't think, that this tool is essential enough to be shipped by default. One can use whois on desktop or mobile phone for example. I think, that packaging whois[1] shouldn't be that hard, then you've it one `opkg install` away. 1. https://github.com/rfc1036/whois Cheers, Petr
On Mon Nov 16, 2020 at 9:14 PM HST, Petr Štetiar wrote: > Josef Schlehofer <pepe.schlehofer@gmail.com> [2020-11-17 02:07:09]: > > Hi, > > > Whois can identify who owns a domain and how to get reach owner. Providing > > this tool in OpenWrt someone does not need to use websites for everything. > > I don't think, that this tool is essential enough to be shipped by > default. I agree. > One can use whois on desktop or mobile phone for example. I think, that > packaging whois[1] shouldn't be that hard, then you've it one `opkg > install` > away. > > 1. https://github.com/rfc1036/whois > > Cheers, > > Petr > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hi guys, Thank you for your feedback. I was surprised how fast this was rejected and I thought that there is going to be some vote or discussion about it. My bad. I noticed that on OpenWrt forum, there are some requests like this [1] to have whois present on their routers. We can be thinking about which tools are essentials to you and which are you using. On the other hand, why we should be using whois on a mobile phone or on websites. Because in my opinion, It's all just a matter of taste. For now, I am satisfied with enabled whois in busybox and as I was doing compile and run tests. I thought that it was a nice idea to share it with you. Anyway, there isn't anything wrong with that! At least we have it documented on the mailing list, so we can refer to it in the future. [1] https://forum.openwrt.org/t/whois-binary-cannot-find-providing-package/31274 Regards, Josef On 17. 11. 20 21:18, Paul Spooren wrote: > On Mon Nov 16, 2020 at 9:14 PM HST, Petr Štetiar wrote: >> Josef Schlehofer <pepe.schlehofer@gmail.com> [2020-11-17 02:07:09]: >> >> Hi, >> >>> Whois can identify who owns a domain and how to get reach owner. Providing >>> this tool in OpenWrt someone does not need to use websites for everything. >> I don't think, that this tool is essential enough to be shipped by >> default. > I agree. > >> One can use whois on desktop or mobile phone for example. I think, that >> packaging whois[1] shouldn't be that hard, then you've it one `opkg >> install` >> away. >> >> 1. https://github.com/rfc1036/whois >> >> Cheers, >> >> Petr >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
I liked the idea of including whois. I think it should be one of those things that gets enabled if we’re not doing a super-skinny-build. And if I’m at a remote location and OpenWRT isn’t coming up enough for me to run “whois” on a laptop behind it, then having it on OpenWRT itself makes it that much more self-contained. > On Nov 18, 2020, at 12:22 AM, Josef Schlehofer <pepe.schlehofer@gmail.com> wrote: > > Hi guys, > > Thank you for your feedback. > I was surprised how fast this was rejected and I thought that there is > going to be some vote or discussion about it. My bad. > > I noticed that on OpenWrt forum, there are some requests like this [1] > to have whois present on their routers. We can be thinking about which > tools are essentials to you and which are you using. On the other hand, > why we should be using whois on a mobile phone or on websites. Because > in my opinion, It's all just a matter of taste. > > For now, I am satisfied with enabled whois in busybox and as I was doing > compile and run tests. I thought that it was a nice idea to share it > with you. > > Anyway, there isn't anything wrong with that! At least we have it > documented on the mailing list, so we can refer to it in the future. > > [1] > https://forum.openwrt.org/t/whois-binary-cannot-find-providing-package/31274 > > Regards, > > Josef > > > On 17. 11. 20 21:18, Paul Spooren wrote: >> On Mon Nov 16, 2020 at 9:14 PM HST, Petr Štetiar wrote: >>> Josef Schlehofer <pepe.schlehofer@gmail.com> [2020-11-17 02:07:09]: >>> >>> Hi, >>> >>>> Whois can identify who owns a domain and how to get reach owner. Providing >>>> this tool in OpenWrt someone does not need to use websites for everything. >>> I don't think, that this tool is essential enough to be shipped by >>> default. >> I agree. >> >>> One can use whois on desktop or mobile phone for example. I think, that >>> packaging whois[1] shouldn't be that hard, then you've it one `opkg >>> install` >>> away. >>> >>> 1. https://github.com/rfc1036/whois >>> >>> Cheers, >>> >>> Petr >>> >>> _______________________________________________ >>> openwrt-devel mailing list >>> openwrt-devel@lists.openwrt.org >>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
On Tue Nov 17, 2020 at 9:22 PM HST, Josef Schlehofer wrote: > Hi guys, > > Thank you for your feedback. > I was surprised how fast this was rejected and I thought that there is > going to be some vote or discussion about it. My bad. > > I noticed that on OpenWrt forum, there are some requests like this [1] > to have whois present on their routers. We can be thinking about which > tools are essentials to you and which are you using. On the other hand, > why we should be using whois on a mobile phone or on websites. Because > in my opinion, It's all just a matter of taste. OpenWrt has a taste for storage constrained devices, so whatever increases the default size by multiple kB is evaluated in depth. In this case it's easily installed via `opkg`. > For now, I am satisfied with enabled whois in busybox and as I was doing > compile and run tests. I thought that it was a nice idea to share it > with you. > > Anyway, there isn't anything wrong with that! At least we have it > documented on the mailing list, so we can refer to it in the future. I ported the suggested whois package to OpenWrt[2], it has more features and doesn't take up any extra space for the default case. [2]: https://github.com/openwrt/packages/pull/13944 Sunshine, Paul > > [1] > https://forum.openwrt.org/t/whois-binary-cannot-find-providing-package/31274 > > Regards, > > Josef > > > On 17. 11. 20 21:18, Paul Spooren wrote: > > On Mon Nov 16, 2020 at 9:14 PM HST, Petr Štetiar wrote: > >> Josef Schlehofer <pepe.schlehofer@gmail.com> [2020-11-17 02:07:09]: > >> > >> Hi, > >> > >>> Whois can identify who owns a domain and how to get reach owner. Providing > >>> this tool in OpenWrt someone does not need to use websites for everything. > >> I don't think, that this tool is essential enough to be shipped by > >> default. > > I agree. > > > >> One can use whois on desktop or mobile phone for example. I think, that > >> packaging whois[1] shouldn't be that hard, then you've it one `opkg > >> install` > >> away. > >> > >> 1. https://github.com/rfc1036/whois > >> > >> Cheers, > >> > >> Petr > >> > >> _______________________________________________ > >> openwrt-devel mailing list > >> openwrt-devel@lists.openwrt.org > >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in index 29724041f4..c2e9337478 100644 --- a/package/utils/busybox/Config-defaults.in +++ b/package/utils/busybox/Config-defaults.in @@ -2582,7 +2582,7 @@ config BUSYBOX_DEFAULT_FEATURE_WGET_OPENSSL default n config BUSYBOX_DEFAULT_WHOIS bool - default n + default y config BUSYBOX_DEFAULT_ZCIP bool default n diff --git a/package/utils/busybox/Makefile b/package/utils/busybox/Makefile index 71bd888c71..38ef4d33bd 100644 --- a/package/utils/busybox/Makefile +++ b/package/utils/busybox/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=busybox PKG_VERSION:=1.31.1 -PKG_RELEASE:=6 +PKG_RELEASE:=7 PKG_FLAGS:=essential PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
Some users of OpenWrt would like to use whois on their routers without re-compiling whole busybox. It means that they need to know how to cross-compile things for OpenWrt, enable it, compile busybox and flash it on the router. That's can be difficult as force reinstall of busybox can leads to some serious issues if you don't update package indexes first. Whois can identify who owns a domain and how to get reach owner. Providing this tool in OpenWrt someone does not need to use websites for everything. According to config/networking/Config.in, it should take 6.3 kb. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> --- package/utils/busybox/Config-defaults.in | 2 +- package/utils/busybox/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)