mbox series

[v3,0/5] add exynos4412-based p4note device family support

Message ID 20201113212525.13455-1-martin.juecker@gmail.com
Headers show
Series add exynos4412-based p4note device family support | expand

Message

Martin Jücker Nov. 13, 2020, 9:25 p.m. UTC 
Hello,

after lots of research and trial and error, this is my first
contribution to the linux kernel.

These patches lay the foundation for supporting the Samsung Galaxy
Note 10.1 device family. To the best of my knowledge there are around
16 devices which use almost identical hardware inside with exceptions
being the modem and one of the sensors. The first instance which I'm
currently testing on is the N8010 which is the wifi only version that
is identical to the N8013. There are some missing components still,
but it's a start.

v1:
https://lore.kernel.org/linux-samsung-soc/20201024144421.34435-1-martin.juecker@gmail.com/

v2:
https://lore.kernel.org/linux-samsung-soc/20201031175836.47745-1-martin.juecker@gmail.com/

Changes in v3:
- copyright changed
- indentation fix

Changes in v2:
- lots of label adjustments, some removed
- unused ehci node removed
- unused serials removed
- compatible string is now samsung,n8010 instead of samsung,n801x
- removed unused imports
- voltage regulator name for TSP changed to match vendor kernel
- i2c numbering starting from 1 now
- two missing gpio configurations added
- added vdd supply to adc node
- added all regulators to max77686 node
- pinctrl configs sorted by pin name


Cheers
Martin

Comments

Krzysztof Kozlowski Nov. 15, 2020, 10:32 a.m. UTC | #1 
On Fri, Nov 13, 2020 at 10:25:23PM +0100, Martin Jücker wrote:
> The p4note family contains a couple of variants of the Galaxy Note 10.1
> tablet with mainly different modems. The GT-N8010/GT-N8013 is the wifi
> only version.
> 
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
>  arch/arm/boot/dts/Makefile                    |    1 +
>  arch/arm/boot/dts/exynos4412-p4note-n8010.dts |   17 +
>  arch/arm/boot/dts/exynos4412-p4note.dtsi      | 1132 +++++++++++++++++
>  3 files changed, 1150 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-p4note-n8010.dts
>  create mode 100644 arch/arm/boot/dts/exynos4412-p4note.dtsi
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ce66ffd5a1bb..55ffee2b20f8 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -197,6 +197,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
>  	exynos4412-odroidx.dtb \
>  	exynos4412-odroidx2.dtb \
>  	exynos4412-origen.dtb \
> +	exynos4412-p4note-n8010.dtb \
>  	exynos4412-smdk4412.dtb \
>  	exynos4412-tiny4412.dtb \
>  	exynos4412-trats2.dtb
> diff --git a/arch/arm/boot/dts/exynos4412-p4note-n8010.dts b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> new file mode 100644
> index 000000000000..9f559425bd2c
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Samsung's Galaxy Note 10.1 - N801x (wifi only version)
> + *
> + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> + *		http://www.samsung.com

Here and in other files - why did you remove your copyright? My comment
from previous version: "If it is true, then include the copyright of
original work as well."

Best regards,
Krzysztof
Martin Jücker Nov. 15, 2020, 5:48 p.m. UTC | #2 
On Sun, Nov 15, 2020 at 11:32:51AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 13, 2020 at 10:25:23PM +0100, Martin Jücker wrote:
> > The p4note family contains a couple of variants of the Galaxy Note 10.1
> > tablet with mainly different modems. The GT-N8010/GT-N8013 is the wifi
> > only version.
> > 
> > Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> > ---
> >  arch/arm/boot/dts/Makefile                    |    1 +
> >  arch/arm/boot/dts/exynos4412-p4note-n8010.dts |   17 +
> >  arch/arm/boot/dts/exynos4412-p4note.dtsi      | 1132 +++++++++++++++++
> >  3 files changed, 1150 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> >  create mode 100644 arch/arm/boot/dts/exynos4412-p4note.dtsi
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index ce66ffd5a1bb..55ffee2b20f8 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -197,6 +197,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
> >  	exynos4412-odroidx.dtb \
> >  	exynos4412-odroidx2.dtb \
> >  	exynos4412-origen.dtb \
> > +	exynos4412-p4note-n8010.dtb \
> >  	exynos4412-smdk4412.dtb \
> >  	exynos4412-tiny4412.dtb \
> >  	exynos4412-trats2.dtb
> > diff --git a/arch/arm/boot/dts/exynos4412-p4note-n8010.dts b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> > new file mode 100644
> > index 000000000000..9f559425bd2c
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> > @@ -0,0 +1,17 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Samsung's Galaxy Note 10.1 - N801x (wifi only version)
> > + *
> > + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> > + *		http://www.samsung.com
> 
> Here and in other files - why did you remove your copyright? My comment
> from previous version: "If it is true, then include the copyright of
> original work as well."
> 
> Best regards,
> Krzysztof
> 

Hey Krzysztof,

in the second response you wrote that "usually we keep the copyright of
original file", I understood this as only the Samsung header as it is
done for the midas, i930x and n710x. A lot of it is basically the same
but with changed gpios. I really don't need my copyright up there if
it's not strictly necessary.

Cheers
Martin
Krzysztof Kozlowski Nov. 15, 2020, 9:22 p.m. UTC | #3 
On Sun, Nov 15, 2020 at 06:48:43PM +0100, Martin Jücker wrote:
> On Sun, Nov 15, 2020 at 11:32:51AM +0100, Krzysztof Kozlowski wrote:
> > On Fri, Nov 13, 2020 at 10:25:23PM +0100, Martin Jücker wrote:
> > > The p4note family contains a couple of variants of the Galaxy Note 10.1
> > > tablet with mainly different modems. The GT-N8010/GT-N8013 is the wifi
> > > only version.
> > > 
> > > Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> > > ---
> > >  arch/arm/boot/dts/Makefile                    |    1 +
> > >  arch/arm/boot/dts/exynos4412-p4note-n8010.dts |   17 +
> > >  arch/arm/boot/dts/exynos4412-p4note.dtsi      | 1132 +++++++++++++++++
> > >  3 files changed, 1150 insertions(+)
> > >  create mode 100644 arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> > >  create mode 100644 arch/arm/boot/dts/exynos4412-p4note.dtsi
> > > 
> > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > > index ce66ffd5a1bb..55ffee2b20f8 100644
> > > --- a/arch/arm/boot/dts/Makefile
> > > +++ b/arch/arm/boot/dts/Makefile
> > > @@ -197,6 +197,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
> > >  	exynos4412-odroidx.dtb \
> > >  	exynos4412-odroidx2.dtb \
> > >  	exynos4412-origen.dtb \
> > > +	exynos4412-p4note-n8010.dtb \
> > >  	exynos4412-smdk4412.dtb \
> > >  	exynos4412-tiny4412.dtb \
> > >  	exynos4412-trats2.dtb
> > > diff --git a/arch/arm/boot/dts/exynos4412-p4note-n8010.dts b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> > > new file mode 100644
> > > index 000000000000..9f559425bd2c
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> > > @@ -0,0 +1,17 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Samsung's Galaxy Note 10.1 - N801x (wifi only version)
> > > + *
> > > + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> > > + *		http://www.samsung.com
> > 
> > Here and in other files - why did you remove your copyright? My comment
> > from previous version: "If it is true, then include the copyright of
> > original work as well."
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> Hey Krzysztof,
> 
> in the second response you wrote that "usually we keep the copyright of
> original file",

Yes, we keep it, in the sense: "we do not remove it". However on top of
it you can add your copyrights.

> I understood this as only the Samsung header as it is
> done for the midas, i930x and n710x. A lot of it is basically the same
> but with changed gpios. I really don't need my copyright up there if
> it's not strictly necessary.

Your copyright is not required, it's anyway coming through contribution
and Git history. If you don't need it, I'll apply the patches as they
are.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 16, 2020, 4:18 p.m. UTC | #4 
On Fri, Nov 13, 2020 at 10:25:23PM +0100, Martin Jücker wrote:
> The p4note family contains a couple of variants of the Galaxy Note 10.1
> tablet with mainly different modems. The GT-N8010/GT-N8013 is the wifi
> only version.
> 
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
>  arch/arm/boot/dts/Makefile                    |    1 +
>  arch/arm/boot/dts/exynos4412-p4note-n8010.dts |   17 +
>  arch/arm/boot/dts/exynos4412-p4note.dtsi      | 1132 +++++++++++++++++
>  3 files changed, 1150 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-p4note-n8010.dts
>  create mode 100644 arch/arm/boot/dts/exynos4412-p4note.dtsi

Thanks, applied.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 16, 2020, 4:22 p.m. UTC | #5 
On Fri, Nov 13, 2020 at 10:25:24PM +0100, Martin Jücker wrote:
> Enable the stmpe adc driver for the p4note device family.
> 
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
>  arch/arm/configs/exynos_defconfig   | 3 +++
>  arch/arm/configs/multi_v7_defconfig | 2 ++
>  2 files changed, 5 insertions(+)

Thanks, applied.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 16, 2020, 4:23 p.m. UTC | #6 
On Fri, Nov 13, 2020 at 10:25:25PM +0100, Martin Jücker wrote:
> The Atmel MXT touchscreen can load firmware and settings from the
> /lib/firmware directory, it makes sense to have it as a module to have
> more control over the loading process.
> 
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
>  arch/arm/configs/exynos_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 16, 2020, 4:32 p.m. UTC | #7 
On Fri, Nov 13, 2020 at 10:25:26PM +0100, Martin Jücker wrote:
> The p4note family supports cpuidle, so allow it to make use of this
> feature.
> 
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
>  arch/arm/mach-exynos/exynos.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, applied.

Best regards,
Krzysztof