| Message ID | 20201106161128.24069-1-vadym.kochan@plvision.eu |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | success | Link |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | success | Link |
| jkicinski/tree_selection | success | Clearly marked for net |
| jkicinski/subject_prefix | success | Link |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | success | Errors and warnings before: 43 this patch: 43 |
| jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/verify_fixes | success | Link |
| jkicinski/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 35 this patch: 35 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
On 11/6/20 8:11 AM, Vadym Kochan wrote: > With CONFIG_BRIDGE=m the compilation fails: > > ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event': > prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled' > > in case the driver is statically enabled. > > Fix it by adding 'BRIDGE || BRIDGE=n' dependency. > > Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation") > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > drivers/net/ethernet/marvell/prestera/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/marvell/prestera/Kconfig b/drivers/net/ethernet/marvell/prestera/Kconfig > index b1fcc44f566a..b6f20e2034c6 100644 > --- a/drivers/net/ethernet/marvell/prestera/Kconfig > +++ b/drivers/net/ethernet/marvell/prestera/Kconfig > @@ -6,6 +6,7 @@ > config PRESTERA > tristate "Marvell Prestera Switch ASICs support" > depends on NET_SWITCHDEV && VLAN_8021Q > + depends on BRIDGE || BRIDGE=n > select NET_DEVLINK > help > This driver supports Marvell Prestera Switch ASICs family. >
On Fri, 6 Nov 2020 12:13:12 -0800 Randy Dunlap wrote: > On 11/6/20 8:11 AM, Vadym Kochan wrote: > > With CONFIG_BRIDGE=m the compilation fails: > > > > ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event': > > prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled' > > > > in case the driver is statically enabled. > > > > Fix it by adding 'BRIDGE || BRIDGE=n' dependency. > > > > Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation") > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu> > > Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Applied, thanks!
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 6 Nov 2020 18:11:25 +0200 you wrote: > With CONFIG_BRIDGE=m the compilation fails: > > ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event': > prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled' > > in case the driver is statically enabled. > > [...] Here is the summary with links: - [net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m https://git.kernel.org/netdev/net/c/4e0396c59559 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/marvell/prestera/Kconfig b/drivers/net/ethernet/marvell/prestera/Kconfig index b1fcc44f566a..b6f20e2034c6 100644 --- a/drivers/net/ethernet/marvell/prestera/Kconfig +++ b/drivers/net/ethernet/marvell/prestera/Kconfig @@ -6,6 +6,7 @@ config PRESTERA tristate "Marvell Prestera Switch ASICs support" depends on NET_SWITCHDEV && VLAN_8021Q + depends on BRIDGE || BRIDGE=n select NET_DEVLINK help This driver supports Marvell Prestera Switch ASICs family.
With CONFIG_BRIDGE=m the compilation fails: ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function `prestera_bridge_port_event': prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_enabled' in case the driver is statically enabled. Fix it by adding 'BRIDGE || BRIDGE=n' dependency. Fixes: e1189d9a5fbe ("net: marvell: prestera: Add Switchdev driver implementation") Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu> --- drivers/net/ethernet/marvell/prestera/Kconfig | 1 + 1 file changed, 1 insertion(+)