| Message ID | 1604564201-50491-1-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Andes |
| Headers | show |
| Series | riscv: Fix ax25-ae350 and qemu-riscv Kconfig dependency | expand |
On Thu, Nov 5, 2020 at 4:16 PM Bin Meng <bmeng.cn@gmail.com> wrote:> > From: Bin Meng <bin.meng@windriver.com> > > SPL_RAM_SUPPORT and SPL_RAM_DEVICE are only visible in an SPL config. > > Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de> +Heinrich Schuchardt in CC > Signed-off-by: Bin Meng <bin.meng@windriver.com> > --- > This patch should be applied after the following one: > http://patchwork.ozlabs.org/project/uboot/patch/20201104114901.9420-2-xypron.glpk@gmx.de/ > > board/AndesTech/ax25-ae350/Kconfig | 4 ++-- > board/emulation/qemu-riscv/Kconfig | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > Regards, Bin
On 05.11.20 09:16, Bin Meng wrote: > From: Bin Meng <bin.meng@windriver.com> > > SPL_RAM_SUPPORT and SPL_RAM_DEVICE are only visible in an SPL config. 'if SPL' would only be required if you would use 'select'. With 'imply' the Kconfig build system takes care of this dependency. My question was about CONFIG_RAM which is not selected on QEMU. But of cause you do not need a RAM driver on QEMU. So I think you can drop this patch. Best regards Heinrich > > Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Signed-off-by: Bin Meng <bin.meng@windriver.com> > --- > This patch should be applied after the following one: > http://patchwork.ozlabs.org/project/uboot/patch/20201104114901.9420-2-xypron.glpk@gmx.de/ > > board/AndesTech/ax25-ae350/Kconfig | 4 ++-- > board/emulation/qemu-riscv/Kconfig | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig > index 321dd0c..2491e26 100644 > --- a/board/AndesTech/ax25-ae350/Kconfig > +++ b/board/AndesTech/ax25-ae350/Kconfig > @@ -32,7 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy > select RISCV_NDS > select SUPPORT_SPL > imply SMP > - imply SPL_RAM_SUPPORT > - imply SPL_RAM_DEVICE > + imply SPL_RAM_SUPPORT if SPL > + imply SPL_RAM_DEVICE if SPL > > endif > diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig > index 0818048..71ce2e5 100644 > --- a/board/emulation/qemu-riscv/Kconfig > +++ b/board/emulation/qemu-riscv/Kconfig > @@ -33,8 +33,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy > imply SMP > imply BOARD_LATE_INIT > imply PCI_INIT_R > - imply SPL_RAM_SUPPORT > - imply SPL_RAM_DEVICE > + imply SPL_RAM_SUPPORT if SPL > + imply SPL_RAM_DEVICE if SPL > imply CMD_PCI > imply CMD_POWEROFF > imply CMD_SCSI >
Hi Heinrich, On Thu, Nov 5, 2020 at 4:55 PM Heinrich Schuchardt <xypron.debian@gmx.de> wrote: > > On 05.11.20 09:16, Bin Meng wrote: > > From: Bin Meng <bin.meng@windriver.com> > > > > SPL_RAM_SUPPORT and SPL_RAM_DEVICE are only visible in an SPL config. > > 'if SPL' would only be required if you would use 'select'. With 'imply' > the Kconfig build system takes care of this dependency. Yes, but I feel that adding a "if" seems to be express the dependency explicitly to avoid confusions. > > My question was about CONFIG_RAM which is not selected on QEMU. But of > cause you do not need a RAM driver on QEMU. > Correct. > So I think you can drop this patch. > I am fine to drop this if there is no concern. Regards, Bin
diff --git a/board/AndesTech/ax25-ae350/Kconfig b/board/AndesTech/ax25-ae350/Kconfig index 321dd0c..2491e26 100644 --- a/board/AndesTech/ax25-ae350/Kconfig +++ b/board/AndesTech/ax25-ae350/Kconfig @@ -32,7 +32,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select RISCV_NDS select SUPPORT_SPL imply SMP - imply SPL_RAM_SUPPORT - imply SPL_RAM_DEVICE + imply SPL_RAM_SUPPORT if SPL + imply SPL_RAM_DEVICE if SPL endif diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig index 0818048..71ce2e5 100644 --- a/board/emulation/qemu-riscv/Kconfig +++ b/board/emulation/qemu-riscv/Kconfig @@ -33,8 +33,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy imply SMP imply BOARD_LATE_INIT imply PCI_INIT_R - imply SPL_RAM_SUPPORT - imply SPL_RAM_DEVICE + imply SPL_RAM_SUPPORT if SPL + imply SPL_RAM_DEVICE if SPL imply CMD_PCI imply CMD_POWEROFF imply CMD_SCSI