diff mbox series

[v4,02/22] log: Fix incorrect documentation of log_filter.cat_list

Message ID 20201027235541.706077-3-seanga2@gmail.com
State Accepted
Commit b66a924f9762bf4d608c6061d5fa2ab79f803e13
Delegated to: Tom Rini
Headers show
Series log: Add commands for manipulating filters | expand

Commit Message

Sean Anderson Oct. 27, 2020, 11:55 p.m. UTC 
Logging category lists are terminated by LOGC_END, not LOGC_NONE.

Fixes: e9c8d49d54 ("log: Add an implementation of logging")

Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

(no changes since v2)

Changes in v2:
- Also fix misdocumentation of for log_add_filter()

 include/log.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Rini Oct. 30, 2020, 6:46 p.m. UTC | #1 
On Tue, Oct 27, 2020 at 07:55:21PM -0400, Sean Anderson wrote:

> Logging category lists are terminated by LOGC_END, not LOGC_NONE.
> 
> Fixes: e9c8d49d54 ("log: Add an implementation of logging")
> 
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/log.h b/include/log.h
index 6de5e611c7..5fde401bd9 100644
--- a/include/log.h
+++ b/include/log.h
@@ -370,7 +370,7 @@  enum log_filter_flags {
  *	new filter, and must be provided when removing a previously added
  *	filter.
  * @flags: Flags for this filter (LOGFF_...)
- * @cat_list: List of categories to allow (terminated by LOGC_none). If empty
+ * @cat_list: List of categories to allow (terminated by %LOGC_END). If empty
  *	then all categories are permitted. Up to LOGF_MAX_CATEGORIES entries
  *	can be provided
  * @max_level: Maximum log level to allow
@@ -448,7 +448,7 @@  int do_log_test(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
  *
  * @drv_name: Driver name to add the filter to (since each driver only has a
  *	single device)
- * @cat_list: List of categories to allow (terminated by LOGC_none). If empty
+ * @cat_list: List of categories to allow (terminated by %LOGC_END). If empty
  *	then all categories are permitted. Up to LOGF_MAX_CATEGORIES entries
  *	can be provided
  * @max_level: Maximum log level to allow