| Message ID | 20201027214155.17246-2-alpernebiyasak@gmail.com |
|---|---|
| State | Accepted |
| Commit | f457680ffbb20aa76ef8f2da38ad6814cf0d0404 |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | [1/2] video: simple_panel: Add sharp,lq123p1jx31 display | expand |
> From: Alper Nebi Yasak <alpernebiyasak@gmail.com> > Date: Wed, 28 Oct 2020 00:41:55 +0300 > > Add "boe,nv101wxmn51" to the compatible node. This is the panel for > chromebook_bob. I do have bob, and would be interested in testing chainloading u-boot on it. Can you give some guidance on how to test this? Which set of patches do I need? Thanks, Mark > Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com> > --- > I didn't test this as I don't have a gru-bob, but this panel is listed > among Linux's simple-panel compatibles [1] just like gru-kevin's (which > I tested) so I strongly believe it should work. > > [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > drivers/video/simple_panel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/simple_panel.c b/drivers/video/simple_panel.c > index d454c11f7eea..0f674c95c00e 100644 > --- a/drivers/video/simple_panel.c > +++ b/drivers/video/simple_panel.c > @@ -109,6 +109,7 @@ static const struct udevice_id simple_panel_ids[] = { > { .compatible = "boe,nv140fhmn49" }, > { .compatible = "lg,lb070wv8" }, > { .compatible = "sharp,lq123p1jx31" }, > + { .compatible = "boe,nv101wxmn51" }, > { } > }; > > -- > 2.28.0 > >
On 28/10/2020 00:52, Mark Kettenis wrote: >> From: Alper Nebi Yasak <alpernebiyasak@gmail.com> >> Date: Wed, 28 Oct 2020 00:41:55 +0300 >> >> Add "boe,nv101wxmn51" to the compatible node. This is the panel for >> chromebook_bob. > > I do have bob, and would be interested in testing chainloading u-boot > on it. Can you give some guidance on how to test this? Which set of > patches do I need? > By chainloading I mean the RW_LEGACY thing because I couldn't manage to do it as a "Chrome OS kernel" yet. For bob, you should get this branch: https://github.com/alpernebbi/u-boot/commits/rk3399-gru-bob-edp/wip I'm not putting my hacks in the bob branch since it should be possible to flash it to SPI and boot from there as things are normally done. So you might need to port my hacks (and other interesing changes) from the other one if you want chainloading: https://github.com/alpernebbi/u-boot/commits/rk3399-gru-kevin/wip I've tried to explain how to build and use things in 'wip' commit messages in the second one. If things are unclear there I'd be glad to help, but it might be too spammy to do it as replies to this patch.
On Tue, 27 Oct 2020 at 15:42, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote: > > Add "boe,nv101wxmn51" to the compatible node. This is the panel for > chromebook_bob. > > Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com> > --- > I didn't test this as I don't have a gru-bob, but this panel is listed > among Linux's simple-panel compatibles [1] just like gru-kevin's (which > I tested) so I strongly believe it should work. > > [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > drivers/video/simple_panel.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass <sjg@chromium.org>
On Wed, 28 Oct 2020 00:41:55 +0300 Alper Nebi Yasak alpernebiyasak@gmail.com wrote: > Add "boe,nv101wxmn51" to the compatible node. This is the panel for > chromebook_bob. > > Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com> > --- > I didn't test this as I don't have a gru-bob, but this panel is listed > among Linux's simple-panel compatibles [1] just like gru-kevin's (which > I tested) so I strongly believe it should work. > > [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > drivers/video/simple_panel.c | 1 + > 1 file changed, 1 insertion(+) Applied to u-boot-video/master, thanks! -- Anatolij
diff --git a/drivers/video/simple_panel.c b/drivers/video/simple_panel.c index d454c11f7eea..0f674c95c00e 100644 --- a/drivers/video/simple_panel.c +++ b/drivers/video/simple_panel.c @@ -109,6 +109,7 @@ static const struct udevice_id simple_panel_ids[] = { { .compatible = "boe,nv140fhmn49" }, { .compatible = "lg,lb070wv8" }, { .compatible = "sharp,lq123p1jx31" }, + { .compatible = "boe,nv101wxmn51" }, { } };
Add "boe,nv101wxmn51" to the compatible node. This is the panel for chromebook_bob. Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com> --- I didn't test this as I don't have a gru-bob, but this panel is listed among Linux's simple-panel compatibles [1] just like gru-kevin's (which I tested) so I strongly believe it should work. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/display/panel/panel-simple.yaml drivers/video/simple_panel.c | 1 + 1 file changed, 1 insertion(+)