| Message ID | 20201026185820.32558-1-agust@denx.de |
|---|---|
| State | Accepted |
| Commit | 9dec5a0ea1301d7c1f350fed3f309471b695584f |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | [v2] nokia_rx51: disable obsolete VIDEO config | expand |
On Mon, 26 Oct 2020 19:58:20 +0100 Anatolij Gustschin agust@denx.de wrote: > Disable VIDEO config to fix DM_VIDEO conversion > deadline warning. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: Pali Rohár <pali@kernel.org> > --- > > Changes in v2: > - select CFB_CONSOLE instead of VIDEO to let video console > support enabled > > configs/nokia_rx51_defconfig | 2 +- > drivers/video/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-video/master.
On Monday 26 October 2020 19:58:20 Anatolij Gustschin wrote: > Disable VIDEO config to fix DM_VIDEO conversion > deadline warning. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: Pali Rohár <pali@kernel.org> > --- > > Changes in v2: > - select CFB_CONSOLE instead of VIDEO to let video console > support enabled > > configs/nokia_rx51_defconfig | 2 +- > drivers/video/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig > index e249dff774..b0a58e5253 100644 > --- a/configs/nokia_rx51_defconfig > +++ b/configs/nokia_rx51_defconfig > @@ -54,7 +54,7 @@ CONFIG_USB_MUSB_HCD=y > CONFIG_USB_MUSB_UDC=y > CONFIG_USB_OMAP3=y > CONFIG_TWL4030_USB=y > -CONFIG_VIDEO=y > +CONFIG_CFB_CONSOLE=y > CONFIG_CFB_CONSOLE_ANSI=y > # CONFIG_VGA_AS_SINGLE_DEVICE is not set > CONFIG_SPLASH_SCREEN=y Hello! This change is disabling CONFIG_CONSOLE_MUX option. Could you please do not disable it? It is needed for debugging via qemu: https://gitlab.denx.de/u-boot/u-boot/-/commit/07693ccb1574adecb9e87756339442955aeaf346 Here is difference of .config file without (.old) and with your patch: --- .config.old 2020-10-27 00:43:11.560525550 +0100 +++ .config 2020-10-27 00:45:17.381359170 +0100 @@ -322,8 +322,8 @@ CONFIG_SPL_LOGLEVEL=4 CONFIG_TPL_LOGLEVEL=4 # CONFIG_SILENT_CONSOLE is not set # CONFIG_PRE_CONSOLE_BUFFER is not set -CONFIG_CONSOLE_MUX=y -CONFIG_SYS_CONSOLE_IS_IN_ENV=y +# CONFIG_CONSOLE_MUX is not set +# CONFIG_SYS_CONSOLE_IS_IN_ENV is not set # CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE is not set # CONFIG_SYS_CONSOLE_ENV_OVERWRITE is not set # CONFIG_SYS_CONSOLE_INFO_QUIET is not set @@ -532,7 +532,6 @@ CONFIG_CMD_SOURCE=y # # Misc commands # -# CONFIG_CMD_BMP is not set # CONFIG_CMD_BSP is not set # CONFIG_CMD_CACHE is not set # CONFIG_CMD_CONITRACE is not set @@ -1074,16 +1073,14 @@ CONFIG_TWL4030_USB=y # CONFIG_VIDEO_VESA is not set # CONFIG_VIDEO_LCD_ANX9804 is not set # CONFIG_VIDEO_LCD_SSD2828 is not set -# CONFIG_VIDEO_LCD_HITACHI_TX18D42VM is not set # CONFIG_VIDEO_MVEBU is not set # CONFIG_VIDEO_OMAP3 is not set # CONFIG_I2C_EDID is not set # CONFIG_DISPLAY is not set # CONFIG_ATMEL_HLCD is not set # CONFIG_AM335X_LCD is not set -# CONFIG_VIDEO_FSL_DCU_FB is not set # CONFIG_VIDEO_BRIDGE is not set -CONFIG_VIDEO=y +# CONFIG_VIDEO is not set CONFIG_CFB_CONSOLE=y CONFIG_CFB_CONSOLE_ANSI=y # CONFIG_VGA_AS_SINGLE_DEVICE is not set > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 2f3bb4b085..998271b9b6 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -665,7 +665,7 @@ config VIDEO > > config CFB_CONSOLE > bool "Enable colour frame buffer console" > - depends on VIDEO > + depends on VIDEO || ARCH_OMAP2PLUS > default y if VIDEO > help > Enables the colour frame buffer driver. This supports colour > -- > 2.17.1 >
On Tue, 27 Oct 2020 00:51:29 +0100 Pali Rohár pali@kernel.org wrote: ... > Hello! This change is disabling CONFIG_CONSOLE_MUX option. > > Could you please do not disable it? It is needed for debugging via qemu: > https://gitlab.denx.de/u-boot/u-boot/-/commit/07693ccb1574adecb9e87756339442955aeaf346 This was auto-selected by CONFIG_VIDEO, so now we have to enable it explicitly. I'll send a patch. -- Anatolij
On Tuesday 27 October 2020 08:17:13 Anatolij Gustschin wrote: > On Tue, 27 Oct 2020 00:51:29 +0100 > Pali Rohár pali@kernel.org wrote: > ... > > Hello! This change is disabling CONFIG_CONSOLE_MUX option. > > > > Could you please do not disable it? It is needed for debugging via qemu: > > https://gitlab.denx.de/u-boot/u-boot/-/commit/07693ccb1574adecb9e87756339442955aeaf346 > > This was auto-selected by CONFIG_VIDEO, so now we have to enable it > explicitly. I'll send a patch. I have already did in above mentioned patch...
On Tue, 27 Oct 2020 09:42:50 +0100 Pali Rohár pali@kernel.org wrote: ... > > This was auto-selected by CONFIG_VIDEO, so now we have to enable it > > explicitly. I'll send a patch. > > I have already did in above mentioned patch... yes, but it was dropped in commit 585da32f4ced since it was auto- selected with CONFIG_VIDEO defined. -- Anatolij
diff --git a/configs/nokia_rx51_defconfig b/configs/nokia_rx51_defconfig index e249dff774..b0a58e5253 100644 --- a/configs/nokia_rx51_defconfig +++ b/configs/nokia_rx51_defconfig @@ -54,7 +54,7 @@ CONFIG_USB_MUSB_HCD=y CONFIG_USB_MUSB_UDC=y CONFIG_USB_OMAP3=y CONFIG_TWL4030_USB=y -CONFIG_VIDEO=y +CONFIG_CFB_CONSOLE=y CONFIG_CFB_CONSOLE_ANSI=y # CONFIG_VGA_AS_SINGLE_DEVICE is not set CONFIG_SPLASH_SCREEN=y diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 2f3bb4b085..998271b9b6 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -665,7 +665,7 @@ config VIDEO config CFB_CONSOLE bool "Enable colour frame buffer console" - depends on VIDEO + depends on VIDEO || ARCH_OMAP2PLUS default y if VIDEO help Enables the colour frame buffer driver. This supports colour
Disable VIDEO config to fix DM_VIDEO conversion deadline warning. Signed-off-by: Anatolij Gustschin <agust@denx.de> Cc: Pali Rohár <pali@kernel.org> --- Changes in v2: - select CFB_CONSOLE instead of VIDEO to let video console support enabled configs/nokia_rx51_defconfig | 2 +- drivers/video/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)