| Message ID | 1601454112-11787-4-git-send-email-mingming.lee@mediatek.com |
|---|---|
| State | Superseded |
| Delegated to: | Heiko Schocher |
| Headers | show |
| Series | Add i2c support for MediaTek mt8512 | expand |
On Wed, 30 Sep 2020 at 02:22, mingming lee <mingming.lee@mediatek.com> wrote: > > From: Mingming Lee <Mingming.Lee@mediatek.com> > > Enable MTK I2C > Enable I2C basic command > > Signed-off-by: Mingming Lee <Mingming.Lee@mediatek.com> > --- > configs/mt8512_bm1_emmc_defconfig | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org> Please check that the sorting is correct. Something like this bash function may help: # $1 is config name function fix_kconfig() { make O=/tmp/b/$1_defconfig cfg && \ make O=/tmp/b/$1 savedefconfig && \ meld /tmp/b/$1/defconfig configs/$1_defconfig } Regards, Simon
hello Simon, thank you for your review I have re-order it and would send it in next version. On Sun, 2020-10-11 at 21:34 -0600, Simon Glass wrote: > On Wed, 30 Sep 2020 at 02:22, mingming lee <mingming.lee@mediatek.com> wrote: > > > > From: Mingming Lee <Mingming.Lee@mediatek.com> > > > > Enable MTK I2C > > Enable I2C basic command > > > > Signed-off-by: Mingming Lee <Mingming.Lee@mediatek.com> > > --- > > configs/mt8512_bm1_emmc_defconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > Please check that the sorting is correct. > > Something like this bash function may help: > > # $1 is config name > function fix_kconfig() > { > make O=/tmp/b/$1_defconfig cfg && \ > make O=/tmp/b/$1 savedefconfig && \ > meld /tmp/b/$1/defconfig configs/$1_defconfig > } > > Regards, > Simon
diff --git a/configs/mt8512_bm1_emmc_defconfig b/configs/mt8512_bm1_emmc_defconfig index 10a2083134..6b3d9a4e9b 100644 --- a/configs/mt8512_bm1_emmc_defconfig +++ b/configs/mt8512_bm1_emmc_defconfig @@ -33,3 +33,6 @@ CONFIG_MTK_TIMER=y CONFIG_WDT=y CONFIG_WDT_MTK=y CONFIG_LZO=y +CONFIG_CMD_I2C=y +CONFIG_DM_I2C=y +CONFIG_SYS_I2C_MTK=y