| Message ID | 20201001102555.18053-1-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | d9839417cb408415a240a5c513365973b3cb6031 |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | ARM: dts: stm32: Add missing dm-spl props for SPI NOR on AV96 | expand |
Hi Marek On 10/1/20 12:25 PM, Marek Vasut wrote: > The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and > flash0 nodes are not included in the reduced SPL DT. This prevents > SPI NOR boot from working at all. Fix this by filling them in. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > --- > arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > index c73318488d..9d3db20876 100644 > --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi > @@ -21,6 +21,10 @@ > }; > }; > > +&flash0 { > + u-boot,dm-spl; > +}; > + > &gpiof { > snor-nwp { > gpio-hog; > @@ -49,6 +53,23 @@ > u-boot,dm-spl; > }; > > +&qspi_clk_pins_a { > + u-boot,dm-spl; > + pins { > + u-boot,dm-spl; > + }; > +}; > + > +&qspi_bk1_pins_a { > + u-boot,dm-spl; > + pins1 { > + u-boot,dm-spl; > + }; > + pins2 { > + u-boot,dm-spl; > + }; > +}; > + > &rcc { > st,clksrc = < > CLK_MPU_PLL1P Reviewed-by: Patrice Chotard <patrice.chotard@st.com> Thanks
Hi Marek, > From: Marek Vasut <marex@denx.de> > Sent: jeudi 1 octobre 2020 12:26 > > The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and > flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR > boot from working at all. Fix this by filling them in. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > --- > arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com> 2 questions; It is a regression or SPI boot had never worked on AV96 ? And the expected target is v2020.10 or v2021.01-rc1 ? I prefer v2021.01-rc1, except if it is blocking or it is a regression ..... Thanks Patrick
On 10/2/20 11:05 AM, Patrick DELAUNAY wrote: > Hi Marek, Hi, >> From: Marek Vasut <marex@denx.de> >> Sent: jeudi 1 octobre 2020 12:26 >> >> The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and >> flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR >> boot from working at all. Fix this by filling them in. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Patrick Delaunay <patrick.delaunay@st.com> >> Cc: Patrice Chotard <patrice.chotard@st.com> >> --- >> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> > > Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com> > > 2 questions; > It is a regression or SPI boot had never worked on AV96 ? > And the expected target is v2020.10 or v2021.01-rc1 ? > > I prefer v2021.01-rc1, except if it is blocking or it is a regression ..... It used to work before, so 2020.10 please.
Hi, > From: Marek Vasut <marex@denx.de> > Sent: vendredi 2 octobre 2020 14:09 > > On 10/2/20 11:05 AM, Patrick DELAUNAY wrote: > > Hi Marek, > > Hi, > > >> From: Marek Vasut <marex@denx.de> > >> Sent: jeudi 1 octobre 2020 12:26 > >> > >> The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and > >> flash0 nodes are not included in the reduced SPL DT. This prevents > >> SPI NOR boot from working at all. Fix this by filling them in. > >> > >> Signed-off-by: Marek Vasut <marex@denx.de> > >> Cc: Patrick Delaunay <patrick.delaunay@st.com> > >> Cc: Patrice Chotard <patrice.chotard@st.com> > >> --- > >> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 > >> +++++++++++++++++++++ > >> 1 file changed, 21 insertions(+) > >> > > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com> > > > > 2 questions; > > It is a regression or SPI boot had never worked on AV96 ? > > And the expected target is v2020.10 or v2021.01-rc1 ? > > > > I prefer v2021.01-rc1, except if it is blocking or it is a regression ..... > > It used to work before, so 2020.10 please. Ok Applied to u-boot-stm/master, thanks! Regards Patrick
On 10/2/20 2:31 PM, Patrick DELAUNAY wrote: > Hi, > >> From: Marek Vasut <marex@denx.de> >> Sent: vendredi 2 octobre 2020 14:09 >> >> On 10/2/20 11:05 AM, Patrick DELAUNAY wrote: >>> Hi Marek, >> >> Hi, >> >>>> From: Marek Vasut <marex@denx.de> >>>> Sent: jeudi 1 octobre 2020 12:26 >>>> >>>> The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and >>>> flash0 nodes are not included in the reduced SPL DT. This prevents >>>> SPI NOR boot from working at all. Fix this by filling them in. >>>> >>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>> Cc: Patrick Delaunay <patrick.delaunay@st.com> >>>> Cc: Patrice Chotard <patrice.chotard@st.com> >>>> --- >>>> arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 >>>> +++++++++++++++++++++ >>>> 1 file changed, 21 insertions(+) >>>> >>> >>> Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com> >>> >>> 2 questions; >>> It is a regression or SPI boot had never worked on AV96 ? >>> And the expected target is v2020.10 or v2021.01-rc1 ? >>> >>> I prefer v2021.01-rc1, except if it is blocking or it is a regression ..... >> >> It used to work before, so 2020.10 please. > > Ok > > Applied to u-boot-stm/master, thanks! Thanks
diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi index c73318488d..9d3db20876 100644 --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi @@ -21,6 +21,10 @@ }; }; +&flash0 { + u-boot,dm-spl; +}; + &gpiof { snor-nwp { gpio-hog; @@ -49,6 +53,23 @@ u-boot,dm-spl; }; +&qspi_clk_pins_a { + u-boot,dm-spl; + pins { + u-boot,dm-spl; + }; +}; + +&qspi_bk1_pins_a { + u-boot,dm-spl; + pins1 { + u-boot,dm-spl; + }; + pins2 { + u-boot,dm-spl; + }; +}; + &rcc { st,clksrc = < CLK_MPU_PLL1P
The u-boot,dm-spl DT props are missing on AV96, hence the pinmux and flash0 nodes are not included in the reduced SPL DT. This prevents SPI NOR boot from working at all. Fix this by filling them in. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Patrick Delaunay <patrick.delaunay@st.com> Cc: Patrice Chotard <patrice.chotard@st.com> --- arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)