| Message ID | 20200904152404.20636-14-krzk@kernel.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: Cleanup of i.MX 8 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Fri, Sep 4, 2020 at 9:25 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Most of Freescale/NXP GPMI device trees use size-cells==1 (even when > actually not needed except few boards). This fixes dtbs_check warnings > like: > > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: #size-cells:0:0: 0 was expected > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > Documentation/devicetree/bindings/mtd/nand-controller.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > index 40fc5b0b2b8c..0879e1108837 100644 > --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > @@ -34,7 +34,10 @@ properties: > const: 1 > > "#size-cells": > - const: 0 > + description: > + Depends on your controller. Put zero unless you need a mapping between CS > + lines and dedicated memory regions. > + enum: [0, 1] Humm, seems that was to describe partitions, but the expectation of the nand binding is describing nand chips. It seems the nand chips are never described and on 1 board even has partitions. I think you should fix the dts to move 'partition@N' nodes under 'partitions' which is preferred and needed if you ever describe nand chips. And then fix '#size-cells' to be 0. Rob
diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml index 40fc5b0b2b8c..0879e1108837 100644 --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml @@ -34,7 +34,10 @@ properties: const: 1 "#size-cells": - const: 0 + description: + Depends on your controller. Put zero unless you need a mapping between CS + lines and dedicated memory regions. + enum: [0, 1] ranges: true
Most of Freescale/NXP GPMI device trees use size-cells==1 (even when actually not needed except few boards). This fixes dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: #size-cells:0:0: 0 was expected Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Documentation/devicetree/bindings/mtd/nand-controller.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)