| Message ID | 20200806145438.65862-14-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [v1,01/15] x86: Introduce USE_EARLY_BOARD_INIT option | expand |
On Thu, 6 Aug 2020 at 08:54, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > start.S does nothing and can be safely removed. Makefile is still being used > by the build system, so simply drop the rule from it. > > Cc: Aiden Park <aiden.park@intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > board/intel/slimbootloader/Makefile | 2 +- > board/intel/slimbootloader/start.S | 9 --------- > 2 files changed, 1 insertion(+), 10 deletions(-) > delete mode 100644 board/intel/slimbootloader/start.S Reviewed-by: Simon Glass <sjg@chromium.org>
> -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Thursday, August 6, 2020 7:55 AM > To: Simon Glass <sjg@chromium.org>; Bin Meng <bmeng.cn@gmail.com>; u- > boot@lists.denx.de > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Park, Aiden > <aiden.park@intel.com> > Subject: [PATCH v1 14/15] x86: intel: slimbootloader: Remove dead code > > start.S does nothing and can be safely removed. Makefile is still being used by > the build system, so simply drop the rule from it. > > Cc: Aiden Park <aiden.park@intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > board/intel/slimbootloader/Makefile | 2 +- board/intel/slimbootloader/start.S > | 9 --------- > 2 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 > board/intel/slimbootloader/start.S > > diff --git a/board/intel/slimbootloader/Makefile > b/board/intel/slimbootloader/Makefile > index fd8fa98a8d39..50330cc6e5db 100644 > --- a/board/intel/slimbootloader/Makefile > +++ b/board/intel/slimbootloader/Makefile > @@ -2,4 +2,4 @@ > # > # Copyright (C) 2019 Intel Corporation <www.intel.com> > > -obj-y += start.o slimbootloader.o > +obj-y += slimbootloader.o > diff --git a/board/intel/slimbootloader/start.S > b/board/intel/slimbootloader/start.S > deleted file mode 100644 > index 5c3f3df09eb0..000000000000 > --- a/board/intel/slimbootloader/start.S > +++ /dev/null > @@ -1,9 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0+ */ > -/* > - * Copyright (C) 2019 Intel Corporation <www.intel.com> > - */ > - > -/* board early initialization */ > -.globl early_board_init > -early_board_init: > - jmp early_board_init_ret > -- > 2.27.0 Reviewed-by: Aiden Park <aiden.park@intel.com>
diff --git a/board/intel/slimbootloader/Makefile b/board/intel/slimbootloader/Makefile index fd8fa98a8d39..50330cc6e5db 100644 --- a/board/intel/slimbootloader/Makefile +++ b/board/intel/slimbootloader/Makefile @@ -2,4 +2,4 @@ # # Copyright (C) 2019 Intel Corporation <www.intel.com> -obj-y += start.o slimbootloader.o +obj-y += slimbootloader.o diff --git a/board/intel/slimbootloader/start.S b/board/intel/slimbootloader/start.S deleted file mode 100644 index 5c3f3df09eb0..000000000000 --- a/board/intel/slimbootloader/start.S +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2019 Intel Corporation <www.intel.com> - */ - -/* board early initialization */ -.globl early_board_init -early_board_init: - jmp early_board_init_ret
start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it. Cc: Aiden Park <aiden.park@intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- board/intel/slimbootloader/Makefile | 2 +- board/intel/slimbootloader/start.S | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 board/intel/slimbootloader/start.S