diff mbox series

[v4,7/9] powerpc: Remove bi_memstart & bi_memsize assignments in spl.c

Message ID 20200813054800.469284-8-sr@denx.de
State Superseded
Delegated to: Tom Rini
Headers show
Series Remove CONFIG_NR_DRAM_BANKS option and bi_memstart/memsize from bd_info | expand

Commit Message

Stefan Roese Aug. 13, 2020, 5:47 a.m. UTC
Most likely these deprecated (removed) variables are not needed. Lets
remove the assignments completely from all spl.c files.

Signed-off-by: Stefan Roese <sr@denx.de>

---

Changes in v4:
- New patch

 board/Arcturus/ucp1020/spl.c       | 2 --
 board/freescale/p1010rdb/spl.c     | 2 --
 board/freescale/p1_p2_rdb_pc/spl.c | 2 --
 board/freescale/t102xrdb/spl.c     | 2 --
 board/freescale/t104xrdb/spl.c     | 2 --
 board/freescale/t208xqds/spl.c     | 2 --
 board/freescale/t208xrdb/spl.c     | 2 --
 board/freescale/t4rdb/spl.c        | 2 --
 8 files changed, 16 deletions(-)

Comments

Stefan Roese Aug. 13, 2020, 9:15 a.m. UTC | #1
Hi Oleksandr and Michael,
Hi developers as NXP,

On 13.08.20 07:47, Stefan Roese wrote:
> Most likely these deprecated (removed) variables are not needed. Lets
> remove the assignments completely from all spl.c files.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>

Could you please test this patch on one of your platforms? I'm not
100% sure, if this assignment can be dropped.

Thanks,
Stefan

> ---
> 
> Changes in v4:
> - New patch
> 
>   board/Arcturus/ucp1020/spl.c       | 2 --
>   board/freescale/p1010rdb/spl.c     | 2 --
>   board/freescale/p1_p2_rdb_pc/spl.c | 2 --
>   board/freescale/t102xrdb/spl.c     | 2 --
>   board/freescale/t104xrdb/spl.c     | 2 --
>   board/freescale/t208xqds/spl.c     | 2 --
>   board/freescale/t208xrdb/spl.c     | 2 --
>   board/freescale/t4rdb/spl.c        | 2 --
>   8 files changed, 16 deletions(-)
> 
> diff --git a/board/Arcturus/ucp1020/spl.c b/board/Arcturus/ucp1020/spl.c
> index 5416a5b663..0fd9532d74 100644
> --- a/board/Arcturus/ucp1020/spl.c
> +++ b/board/Arcturus/ucp1020/spl.c
> @@ -83,8 +83,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>   	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>   	memset(bd, 0, sizeof(struct bd_info));
>   	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>   
>   	arch_cpu_init();
>   	get_clocks();
> diff --git a/board/freescale/p1010rdb/spl.c b/board/freescale/p1010rdb/spl.c
> index 4ee4573d2b..fbaa6a6514 100644
> --- a/board/freescale/p1010rdb/spl.c
> +++ b/board/freescale/p1010rdb/spl.c
> @@ -69,8 +69,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>   	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>   	memset(bd, 0, sizeof(struct bd_info));
>   	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>   
>   	arch_cpu_init();
>   	get_clocks();
> diff --git a/board/freescale/p1_p2_rdb_pc/spl.c b/board/freescale/p1_p2_rdb_pc/spl.c
> index e76c3e82c3..8aceceb56a 100644
> --- a/board/freescale/p1_p2_rdb_pc/spl.c
> +++ b/board/freescale/p1_p2_rdb_pc/spl.c
> @@ -75,8 +75,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>   	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>   	memset(bd, 0, sizeof(struct bd_info));
>   	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>   
>   	arch_cpu_init();
>   	get_clocks();
> diff --git a/board/freescale/t102xrdb/spl.c b/board/freescale/t102xrdb/spl.c
> index da442fcc18..09dd88ac4e 100644
> --- a/board/freescale/t102xrdb/spl.c
> +++ b/board/freescale/t102xrdb/spl.c
> @@ -103,8 +103,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>   	memset(bd, 0, sizeof(struct bd_info));
>   	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>   
>   	arch_cpu_init();
>   	get_clocks();
> diff --git a/board/freescale/t104xrdb/spl.c b/board/freescale/t104xrdb/spl.c
> index f83d69ba15..e7922954de 100644
> --- a/board/freescale/t104xrdb/spl.c
> +++ b/board/freescale/t104xrdb/spl.c
> @@ -94,8 +94,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>   	memset(bd, 0, sizeof(struct bd_info));
>   	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>   
>   	arch_cpu_init();
>   	get_clocks();
> diff --git a/board/freescale/t208xqds/spl.c b/board/freescale/t208xqds/spl.c
> index c197884421..d8c2bbe28d 100644
> --- a/board/freescale/t208xqds/spl.c
> +++ b/board/freescale/t208xqds/spl.c
> @@ -102,8 +102,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>   	memset(bd, 0, sizeof(struct bd_info));
>   	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>   
>   	arch_cpu_init();
>   	get_clocks();
> diff --git a/board/freescale/t208xrdb/spl.c b/board/freescale/t208xrdb/spl.c
> index 07aab6349c..c64bd87115 100644
> --- a/board/freescale/t208xrdb/spl.c
> +++ b/board/freescale/t208xrdb/spl.c
> @@ -72,8 +72,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>   	memset(bd, 0, sizeof(struct bd_info));
>   	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>   
>   	arch_cpu_init();
>   	get_clocks();
> diff --git a/board/freescale/t4rdb/spl.c b/board/freescale/t4rdb/spl.c
> index 64d2753da8..9aa0a9b052 100644
> --- a/board/freescale/t4rdb/spl.c
> +++ b/board/freescale/t4rdb/spl.c
> @@ -75,8 +75,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>   	memset(bd, 0, sizeof(struct bd_info));
>   	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>   
>   	arch_cpu_init();
>   	get_clocks();
> 


Viele Grüße,
Stefan
Arcturus Support Aug. 13, 2020, 2:45 p.m. UTC | #2
We will ...

Michael 
Arcturus Support
arcsupport@ArcturusNetworks.com

On 2020-08-13 5:15 a.m., Stefan Roese wrote:
> Hi Oleksandr and Michael,
> Hi developers as NXP,
>
> On 13.08.20 07:47, Stefan Roese wrote:
>> Most likely these deprecated (removed) variables are not needed. Lets
>> remove the assignments completely from all spl.c files.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>
> Could you please test this patch on one of your platforms? I'm not
> 100% sure, if this assignment can be dropped.
>
> Thanks,
> Stefan
>
>> ---
>>
>> Changes in v4:
>> - New patch
>>
>>   board/Arcturus/ucp1020/spl.c       | 2 --
>>   board/freescale/p1010rdb/spl.c     | 2 --
>>   board/freescale/p1_p2_rdb_pc/spl.c | 2 --
>>   board/freescale/t102xrdb/spl.c     | 2 --
>>   board/freescale/t104xrdb/spl.c     | 2 --
>>   board/freescale/t208xqds/spl.c     | 2 --
>>   board/freescale/t208xrdb/spl.c     | 2 --
>>   board/freescale/t4rdb/spl.c        | 2 --
>>   8 files changed, 16 deletions(-)
>>
>> diff --git a/board/Arcturus/ucp1020/spl.c b/board/Arcturus/ucp1020/spl.c
>> index 5416a5b663..0fd9532d74 100644
>> --- a/board/Arcturus/ucp1020/spl.c
>> +++ b/board/Arcturus/ucp1020/spl.c
>> @@ -83,8 +83,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>       bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>>       memset(bd, 0, sizeof(struct bd_info));
>>       gd->bd = bd;
>> -    bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
>> -    bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>>         arch_cpu_init();
>>       get_clocks();
>> diff --git a/board/freescale/p1010rdb/spl.c
>> b/board/freescale/p1010rdb/spl.c
>> index 4ee4573d2b..fbaa6a6514 100644
>> --- a/board/freescale/p1010rdb/spl.c
>> +++ b/board/freescale/p1010rdb/spl.c
>> @@ -69,8 +69,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>       bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>>       memset(bd, 0, sizeof(struct bd_info));
>>       gd->bd = bd;
>> -    bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
>> -    bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>>         arch_cpu_init();
>>       get_clocks();
>> diff --git a/board/freescale/p1_p2_rdb_pc/spl.c
>> b/board/freescale/p1_p2_rdb_pc/spl.c
>> index e76c3e82c3..8aceceb56a 100644
>> --- a/board/freescale/p1_p2_rdb_pc/spl.c
>> +++ b/board/freescale/p1_p2_rdb_pc/spl.c
>> @@ -75,8 +75,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>       bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>>       memset(bd, 0, sizeof(struct bd_info));
>>       gd->bd = bd;
>> -    bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
>> -    bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>>         arch_cpu_init();
>>       get_clocks();
>> diff --git a/board/freescale/t102xrdb/spl.c
>> b/board/freescale/t102xrdb/spl.c
>> index da442fcc18..09dd88ac4e 100644
>> --- a/board/freescale/t102xrdb/spl.c
>> +++ b/board/freescale/t102xrdb/spl.c
>> @@ -103,8 +103,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>       bd = (struct bd_info *)(gd + sizeof(gd_t));
>>       memset(bd, 0, sizeof(struct bd_info));
>>       gd->bd = bd;
>> -    bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -    bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>         arch_cpu_init();
>>       get_clocks();
>> diff --git a/board/freescale/t104xrdb/spl.c
>> b/board/freescale/t104xrdb/spl.c
>> index f83d69ba15..e7922954de 100644
>> --- a/board/freescale/t104xrdb/spl.c
>> +++ b/board/freescale/t104xrdb/spl.c
>> @@ -94,8 +94,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>       bd = (struct bd_info *)(gd + sizeof(gd_t));
>>       memset(bd, 0, sizeof(struct bd_info));
>>       gd->bd = bd;
>> -    bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -    bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>         arch_cpu_init();
>>       get_clocks();
>> diff --git a/board/freescale/t208xqds/spl.c
>> b/board/freescale/t208xqds/spl.c
>> index c197884421..d8c2bbe28d 100644
>> --- a/board/freescale/t208xqds/spl.c
>> +++ b/board/freescale/t208xqds/spl.c
>> @@ -102,8 +102,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>       bd = (struct bd_info *)(gd + sizeof(gd_t));
>>       memset(bd, 0, sizeof(struct bd_info));
>>       gd->bd = bd;
>> -    bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -    bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>         arch_cpu_init();
>>       get_clocks();
>> diff --git a/board/freescale/t208xrdb/spl.c
>> b/board/freescale/t208xrdb/spl.c
>> index 07aab6349c..c64bd87115 100644
>> --- a/board/freescale/t208xrdb/spl.c
>> +++ b/board/freescale/t208xrdb/spl.c
>> @@ -72,8 +72,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>       bd = (struct bd_info *)(gd + sizeof(gd_t));
>>       memset(bd, 0, sizeof(struct bd_info));
>>       gd->bd = bd;
>> -    bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -    bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>         arch_cpu_init();
>>       get_clocks();
>> diff --git a/board/freescale/t4rdb/spl.c b/board/freescale/t4rdb/spl.c
>> index 64d2753da8..9aa0a9b052 100644
>> --- a/board/freescale/t4rdb/spl.c
>> +++ b/board/freescale/t4rdb/spl.c
>> @@ -75,8 +75,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>       bd = (struct bd_info *)(gd + sizeof(gd_t));
>>       memset(bd, 0, sizeof(struct bd_info));
>>       gd->bd = bd;
>> -    bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -    bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>         arch_cpu_init();
>>       get_clocks();
>>
>
>
> Viele Grüße,
> Stefan
>
Arcturus Support Aug. 13, 2020, 3:26 p.m. UTC | #3
Yes, you can drop the assignment for our ucp1020 board and apply your
board/Arcturus/ucp1020/spl.c patch.

Tested-by: Oleksandr Zhadan and Michael Durrant
<arcsupport@arcturusnetworks.com>


On 2020-08-13 1:47 a.m., Stefan Roese wrote:
> Most likely these deprecated (removed) variables are not needed. Lets
> remove the assignments completely from all spl.c files.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
>
> ---
>
> Changes in v4:
> - New patch
>
>  board/Arcturus/ucp1020/spl.c       | 2 --
>  board/freescale/p1010rdb/spl.c     | 2 --
>  board/freescale/p1_p2_rdb_pc/spl.c | 2 --
>  board/freescale/t102xrdb/spl.c     | 2 --
>  board/freescale/t104xrdb/spl.c     | 2 --
>  board/freescale/t208xqds/spl.c     | 2 --
>  board/freescale/t208xrdb/spl.c     | 2 --
>  board/freescale/t4rdb/spl.c        | 2 --
>  8 files changed, 16 deletions(-)
>
> diff --git a/board/Arcturus/ucp1020/spl.c b/board/Arcturus/ucp1020/spl.c
> index 5416a5b663..0fd9532d74 100644
> --- a/board/Arcturus/ucp1020/spl.c
> +++ b/board/Arcturus/ucp1020/spl.c
> @@ -83,8 +83,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>  	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>  	memset(bd, 0, sizeof(struct bd_info));
>  	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>  
>  	arch_cpu_init();
>  	get_clocks();
> diff --git a/board/freescale/p1010rdb/spl.c b/board/freescale/p1010rdb/spl.c
> index 4ee4573d2b..fbaa6a6514 100644
> --- a/board/freescale/p1010rdb/spl.c
> +++ b/board/freescale/p1010rdb/spl.c
> @@ -69,8 +69,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>  	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>  	memset(bd, 0, sizeof(struct bd_info));
>  	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>  
>  	arch_cpu_init();
>  	get_clocks();
> diff --git a/board/freescale/p1_p2_rdb_pc/spl.c b/board/freescale/p1_p2_rdb_pc/spl.c
> index e76c3e82c3..8aceceb56a 100644
> --- a/board/freescale/p1_p2_rdb_pc/spl.c
> +++ b/board/freescale/p1_p2_rdb_pc/spl.c
> @@ -75,8 +75,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>  	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>  	memset(bd, 0, sizeof(struct bd_info));
>  	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>  
>  	arch_cpu_init();
>  	get_clocks();
> diff --git a/board/freescale/t102xrdb/spl.c b/board/freescale/t102xrdb/spl.c
> index da442fcc18..09dd88ac4e 100644
> --- a/board/freescale/t102xrdb/spl.c
> +++ b/board/freescale/t102xrdb/spl.c
> @@ -103,8 +103,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>  	bd = (struct bd_info *)(gd + sizeof(gd_t));
>  	memset(bd, 0, sizeof(struct bd_info));
>  	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>  
>  	arch_cpu_init();
>  	get_clocks();
> diff --git a/board/freescale/t104xrdb/spl.c b/board/freescale/t104xrdb/spl.c
> index f83d69ba15..e7922954de 100644
> --- a/board/freescale/t104xrdb/spl.c
> +++ b/board/freescale/t104xrdb/spl.c
> @@ -94,8 +94,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>  	bd = (struct bd_info *)(gd + sizeof(gd_t));
>  	memset(bd, 0, sizeof(struct bd_info));
>  	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>  
>  	arch_cpu_init();
>  	get_clocks();
> diff --git a/board/freescale/t208xqds/spl.c b/board/freescale/t208xqds/spl.c
> index c197884421..d8c2bbe28d 100644
> --- a/board/freescale/t208xqds/spl.c
> +++ b/board/freescale/t208xqds/spl.c
> @@ -102,8 +102,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>  	bd = (struct bd_info *)(gd + sizeof(gd_t));
>  	memset(bd, 0, sizeof(struct bd_info));
>  	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>  
>  	arch_cpu_init();
>  	get_clocks();
> diff --git a/board/freescale/t208xrdb/spl.c b/board/freescale/t208xrdb/spl.c
> index 07aab6349c..c64bd87115 100644
> --- a/board/freescale/t208xrdb/spl.c
> +++ b/board/freescale/t208xrdb/spl.c
> @@ -72,8 +72,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>  	bd = (struct bd_info *)(gd + sizeof(gd_t));
>  	memset(bd, 0, sizeof(struct bd_info));
>  	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>  
>  	arch_cpu_init();
>  	get_clocks();
> diff --git a/board/freescale/t4rdb/spl.c b/board/freescale/t4rdb/spl.c
> index 64d2753da8..9aa0a9b052 100644
> --- a/board/freescale/t4rdb/spl.c
> +++ b/board/freescale/t4rdb/spl.c
> @@ -75,8 +75,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>  	bd = (struct bd_info *)(gd + sizeof(gd_t));
>  	memset(bd, 0, sizeof(struct bd_info));
>  	gd->bd = bd;
> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>  
>  	arch_cpu_init();
>  	get_clocks();
Priyanka Jain (OSS) Aug. 21, 2020, 8:50 a.m. UTC | #4
>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Stefan Roese
>Sent: Thursday, August 13, 2020 2:46 PM
>To: Oleksandr Zhadan and Michael Durrant
><arcsupport@arcturusnetworks.com>; Priyanka Jain
><priyanka.jain@nxp.com>; Qiang Zhao <qiang.zhao@nxp.com>; Shengzhou
>Liu <shengzhou.liu@nxp.com>
>Cc: u-boot@lists.denx.de
>Subject: Re: [PATCH v4 7/9] powerpc: Remove bi_memstart & bi_memsize
>assignments in spl.c
>
>Hi Oleksandr and Michael,
>Hi developers as NXP,
>
>On 13.08.20 07:47, Stefan Roese wrote:
>> Most likely these deprecated (removed) variables are not needed. Lets
>> remove the assignments completely from all spl.c files.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>
>Could you please test this patch on one of your platforms? I'm not 100% sure,
>if this assignment can be dropped.
>
>Thanks,
>Stefan
>
Hello Stefan,

We will test and provide you the feedback.

Regards
Priyanka
>> ---
>>
>> Changes in v4:
>> - New patch
>>
>>   board/Arcturus/ucp1020/spl.c       | 2 --
>>   board/freescale/p1010rdb/spl.c     | 2 --
>>   board/freescale/p1_p2_rdb_pc/spl.c | 2 --
>>   board/freescale/t102xrdb/spl.c     | 2 --
>>   board/freescale/t104xrdb/spl.c     | 2 --
>>   board/freescale/t208xqds/spl.c     | 2 --
>>   board/freescale/t208xrdb/spl.c     | 2 --
>>   board/freescale/t4rdb/spl.c        | 2 --
>>   8 files changed, 16 deletions(-)
>>
>> diff --git a/board/Arcturus/ucp1020/spl.c
>> b/board/Arcturus/ucp1020/spl.c index 5416a5b663..0fd9532d74 100644
>> --- a/board/Arcturus/ucp1020/spl.c
>> +++ b/board/Arcturus/ucp1020/spl.c
>> @@ -83,8 +83,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>   	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>>   	memset(bd, 0, sizeof(struct bd_info));
>>   	gd->bd = bd;
>> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
>> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>>
>>   	arch_cpu_init();
>>   	get_clocks();
>> diff --git a/board/freescale/p1010rdb/spl.c
>> b/board/freescale/p1010rdb/spl.c index 4ee4573d2b..fbaa6a6514 100644
>> --- a/board/freescale/p1010rdb/spl.c
>> +++ b/board/freescale/p1010rdb/spl.c
>> @@ -69,8 +69,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>   	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>>   	memset(bd, 0, sizeof(struct bd_info));
>>   	gd->bd = bd;
>> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
>> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>>
>>   	arch_cpu_init();
>>   	get_clocks();
>> diff --git a/board/freescale/p1_p2_rdb_pc/spl.c
>> b/board/freescale/p1_p2_rdb_pc/spl.c
>> index e76c3e82c3..8aceceb56a 100644
>> --- a/board/freescale/p1_p2_rdb_pc/spl.c
>> +++ b/board/freescale/p1_p2_rdb_pc/spl.c
>> @@ -75,8 +75,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>   	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
>>   	memset(bd, 0, sizeof(struct bd_info));
>>   	gd->bd = bd;
>> -	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
>> -	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
>>
>>   	arch_cpu_init();
>>   	get_clocks();
>> diff --git a/board/freescale/t102xrdb/spl.c
>> b/board/freescale/t102xrdb/spl.c index da442fcc18..09dd88ac4e 100644
>> --- a/board/freescale/t102xrdb/spl.c
>> +++ b/board/freescale/t102xrdb/spl.c
>> @@ -103,8 +103,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>>   	memset(bd, 0, sizeof(struct bd_info));
>>   	gd->bd = bd;
>> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>
>>   	arch_cpu_init();
>>   	get_clocks();
>> diff --git a/board/freescale/t104xrdb/spl.c
>> b/board/freescale/t104xrdb/spl.c index f83d69ba15..e7922954de 100644
>> --- a/board/freescale/t104xrdb/spl.c
>> +++ b/board/freescale/t104xrdb/spl.c
>> @@ -94,8 +94,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>>   	memset(bd, 0, sizeof(struct bd_info));
>>   	gd->bd = bd;
>> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>
>>   	arch_cpu_init();
>>   	get_clocks();
>> diff --git a/board/freescale/t208xqds/spl.c
>> b/board/freescale/t208xqds/spl.c index c197884421..d8c2bbe28d 100644
>> --- a/board/freescale/t208xqds/spl.c
>> +++ b/board/freescale/t208xqds/spl.c
>> @@ -102,8 +102,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>>   	memset(bd, 0, sizeof(struct bd_info));
>>   	gd->bd = bd;
>> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>
>>   	arch_cpu_init();
>>   	get_clocks();
>> diff --git a/board/freescale/t208xrdb/spl.c
>> b/board/freescale/t208xrdb/spl.c index 07aab6349c..c64bd87115 100644
>> --- a/board/freescale/t208xrdb/spl.c
>> +++ b/board/freescale/t208xrdb/spl.c
>> @@ -72,8 +72,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>>   	memset(bd, 0, sizeof(struct bd_info));
>>   	gd->bd = bd;
>> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>
>>   	arch_cpu_init();
>>   	get_clocks();
>> diff --git a/board/freescale/t4rdb/spl.c b/board/freescale/t4rdb/spl.c
>> index 64d2753da8..9aa0a9b052 100644
>> --- a/board/freescale/t4rdb/spl.c
>> +++ b/board/freescale/t4rdb/spl.c
>> @@ -75,8 +75,6 @@ void board_init_r(gd_t *gd, ulong dest_addr)
>>   	bd = (struct bd_info *)(gd + sizeof(gd_t));
>>   	memset(bd, 0, sizeof(struct bd_info));
>>   	gd->bd = bd;
>> -	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
>> -	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
>>
>>   	arch_cpu_init();
>>   	get_clocks();
>>
>
>
>Viele Grüße,
>Stefan
>
>--
>DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
diff mbox series

Patch

diff --git a/board/Arcturus/ucp1020/spl.c b/board/Arcturus/ucp1020/spl.c
index 5416a5b663..0fd9532d74 100644
--- a/board/Arcturus/ucp1020/spl.c
+++ b/board/Arcturus/ucp1020/spl.c
@@ -83,8 +83,6 @@  void board_init_r(gd_t *gd, ulong dest_addr)
 	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
 	memset(bd, 0, sizeof(struct bd_info));
 	gd->bd = bd;
-	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
-	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
 
 	arch_cpu_init();
 	get_clocks();
diff --git a/board/freescale/p1010rdb/spl.c b/board/freescale/p1010rdb/spl.c
index 4ee4573d2b..fbaa6a6514 100644
--- a/board/freescale/p1010rdb/spl.c
+++ b/board/freescale/p1010rdb/spl.c
@@ -69,8 +69,6 @@  void board_init_r(gd_t *gd, ulong dest_addr)
 	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
 	memset(bd, 0, sizeof(struct bd_info));
 	gd->bd = bd;
-	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
-	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
 
 	arch_cpu_init();
 	get_clocks();
diff --git a/board/freescale/p1_p2_rdb_pc/spl.c b/board/freescale/p1_p2_rdb_pc/spl.c
index e76c3e82c3..8aceceb56a 100644
--- a/board/freescale/p1_p2_rdb_pc/spl.c
+++ b/board/freescale/p1_p2_rdb_pc/spl.c
@@ -75,8 +75,6 @@  void board_init_r(gd_t *gd, ulong dest_addr)
 	bd = (struct bd_info *)(CONFIG_SPL_GD_ADDR + sizeof(gd_t));
 	memset(bd, 0, sizeof(struct bd_info));
 	gd->bd = bd;
-	bd->bi_memstart = CONFIG_SYS_INIT_L2_ADDR;
-	bd->bi_memsize = CONFIG_SYS_L2_SIZE;
 
 	arch_cpu_init();
 	get_clocks();
diff --git a/board/freescale/t102xrdb/spl.c b/board/freescale/t102xrdb/spl.c
index da442fcc18..09dd88ac4e 100644
--- a/board/freescale/t102xrdb/spl.c
+++ b/board/freescale/t102xrdb/spl.c
@@ -103,8 +103,6 @@  void board_init_r(gd_t *gd, ulong dest_addr)
 	bd = (struct bd_info *)(gd + sizeof(gd_t));
 	memset(bd, 0, sizeof(struct bd_info));
 	gd->bd = bd;
-	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
-	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
 
 	arch_cpu_init();
 	get_clocks();
diff --git a/board/freescale/t104xrdb/spl.c b/board/freescale/t104xrdb/spl.c
index f83d69ba15..e7922954de 100644
--- a/board/freescale/t104xrdb/spl.c
+++ b/board/freescale/t104xrdb/spl.c
@@ -94,8 +94,6 @@  void board_init_r(gd_t *gd, ulong dest_addr)
 	bd = (struct bd_info *)(gd + sizeof(gd_t));
 	memset(bd, 0, sizeof(struct bd_info));
 	gd->bd = bd;
-	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
-	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
 
 	arch_cpu_init();
 	get_clocks();
diff --git a/board/freescale/t208xqds/spl.c b/board/freescale/t208xqds/spl.c
index c197884421..d8c2bbe28d 100644
--- a/board/freescale/t208xqds/spl.c
+++ b/board/freescale/t208xqds/spl.c
@@ -102,8 +102,6 @@  void board_init_r(gd_t *gd, ulong dest_addr)
 	bd = (struct bd_info *)(gd + sizeof(gd_t));
 	memset(bd, 0, sizeof(struct bd_info));
 	gd->bd = bd;
-	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
-	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
 
 	arch_cpu_init();
 	get_clocks();
diff --git a/board/freescale/t208xrdb/spl.c b/board/freescale/t208xrdb/spl.c
index 07aab6349c..c64bd87115 100644
--- a/board/freescale/t208xrdb/spl.c
+++ b/board/freescale/t208xrdb/spl.c
@@ -72,8 +72,6 @@  void board_init_r(gd_t *gd, ulong dest_addr)
 	bd = (struct bd_info *)(gd + sizeof(gd_t));
 	memset(bd, 0, sizeof(struct bd_info));
 	gd->bd = bd;
-	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
-	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
 
 	arch_cpu_init();
 	get_clocks();
diff --git a/board/freescale/t4rdb/spl.c b/board/freescale/t4rdb/spl.c
index 64d2753da8..9aa0a9b052 100644
--- a/board/freescale/t4rdb/spl.c
+++ b/board/freescale/t4rdb/spl.c
@@ -75,8 +75,6 @@  void board_init_r(gd_t *gd, ulong dest_addr)
 	bd = (struct bd_info *)(gd + sizeof(gd_t));
 	memset(bd, 0, sizeof(struct bd_info));
 	gd->bd = bd;
-	bd->bi_memstart = CONFIG_SYS_INIT_L3_ADDR;
-	bd->bi_memsize = CONFIG_SYS_L3_SIZE;
 
 	arch_cpu_init();
 	get_clocks();