| Message ID | 20200729112452.15812-1-patrick.delaunay@st.com |
|---|---|
| State | Accepted |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | board: stm32mp1: use const for struct node_info | expand |
Hi Patrick On 7/29/20 1:24 PM, Patrick Delaunay wrote: > Use const for the variable nodes in ft_board_setup, > this patch follow fdt_fixup_mtdparts prototype and no more use stack. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > board/st/stm32mp1/stm32mp1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c > index 1d274c3157..68c4a221da 100644 > --- a/board/st/stm32mp1/stm32mp1.c > +++ b/board/st/stm32mp1/stm32mp1.c > @@ -847,7 +847,7 @@ int mmc_get_env_dev(void) > int ft_board_setup(void *blob, struct bd_info *bd) > { > #ifdef CONFIG_FDT_FIXUP_PARTITIONS > - struct node_info nodes[] = { > + static const struct node_info nodes[] = { > { "st,stm32f469-qspi", MTD_DEV_TYPE_NOR, }, > { "st,stm32f469-qspi", MTD_DEV_TYPE_SPINAND}, > { "st,stm32mp15-fmc2", MTD_DEV_TYPE_NAND, }, Reviewed-by: Patrice Chotard <patrice.chotard@st.com> Thanks Patrice
On 8/13/20 9:46 AM, Patrice CHOTARD wrote: > Hi Patrick > > On 7/29/20 1:24 PM, Patrick Delaunay wrote: >> Use const for the variable nodes in ft_board_setup, >> this patch follow fdt_fixup_mtdparts prototype and no more use stack. >> >> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> >> --- >> >> board/st/stm32mp1/stm32mp1.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) Applied on u-boot-stm/master Thanks >> >> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c >> index 1d274c3157..68c4a221da 100644 >> --- a/board/st/stm32mp1/stm32mp1.c >> +++ b/board/st/stm32mp1/stm32mp1.c >> @@ -847,7 +847,7 @@ int mmc_get_env_dev(void) >> int ft_board_setup(void *blob, struct bd_info *bd) >> { >> #ifdef CONFIG_FDT_FIXUP_PARTITIONS >> - struct node_info nodes[] = { >> + static const struct node_info nodes[] = { >> { "st,stm32f469-qspi", MTD_DEV_TYPE_NOR, }, >> { "st,stm32f469-qspi", MTD_DEV_TYPE_SPINAND}, >> { "st,stm32mp15-fmc2", MTD_DEV_TYPE_NAND, }, > Reviewed-by: Patrice Chotard <patrice.chotard@st.com> > > Thanks > > Patrice > _______________________________________________ > Uboot-stm32 mailing list > Uboot-stm32@st-md-mailman.stormreply.com > https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32
diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c index 1d274c3157..68c4a221da 100644 --- a/board/st/stm32mp1/stm32mp1.c +++ b/board/st/stm32mp1/stm32mp1.c @@ -847,7 +847,7 @@ int mmc_get_env_dev(void) int ft_board_setup(void *blob, struct bd_info *bd) { #ifdef CONFIG_FDT_FIXUP_PARTITIONS - struct node_info nodes[] = { + static const struct node_info nodes[] = { { "st,stm32f469-qspi", MTD_DEV_TYPE_NOR, }, { "st,stm32f469-qspi", MTD_DEV_TYPE_SPINAND}, { "st,stm32mp15-fmc2", MTD_DEV_TYPE_NAND, },
Use const for the variable nodes in ft_board_setup, this patch follow fdt_fixup_mtdparts prototype and no more use stack. Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- board/st/stm32mp1/stm32mp1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)