| Message ID | 20200723213545.3681-1-michael@walle.cc |
|---|---|
| State | Changes Requested |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | ram: rockchip: Disable debug output of RAM init by default | expand |
Hi Michael, I think there do have some information are really help people identify what's happen for TPL fail, that's why rockchip's dram binary always keep some DRAM info print for all the boards. I would like to keep it as is for now, before we are can split the 'debug' and 'info' msg. Thanks, - Kever 在 2020/7/24 上午5:35, Michael Walle 写道: > Like the name says, it is debug output and should not be enabled by > default as it just clutters the console. I know this basically > reverts commit fba7bd4c34c5 ("ram: rockchip: Default enable DRAM debug > info"). But if there is so important information printed on the console > as indicated in the commit description (which I didn't saw for the > LPDDR4 initialization), it shouldn't be debug in the first place. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > drivers/ram/rockchip/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ram/rockchip/Kconfig b/drivers/ram/rockchip/Kconfig > index 8e97c2f49e..43a125e273 100644 > --- a/drivers/ram/rockchip/Kconfig > +++ b/drivers/ram/rockchip/Kconfig > @@ -14,7 +14,6 @@ config ROCKCHIP_SDRAM_COMMON > config RAM_ROCKCHIP_DEBUG > bool "Rockchip ram drivers debugging" > depends on RAM_ROCKCHIP > - default y > help > This enables debugging ram driver API's for the platforms > based on Rockchip SoCs.
Hi Kever, Am 2020-08-08 11:40, schrieb Kever Yang: > Hi Michael, > > I think there do have some information are really help people > identify what's happen for TPL fail, > > that's why rockchip's dram binary always keep some DRAM info print for > all the boards. > > I would like to keep it as is for now, before we are can split the > 'debug' and 'info' msg. So shouldn't we work on splitting the messages into debug() and info() then? Like I said, it really clutters the console in the normal case (for DDR4 at least, I don't know about DDR3)and IMHO you don't want that many debug information _by default_. -michael
diff --git a/drivers/ram/rockchip/Kconfig b/drivers/ram/rockchip/Kconfig index 8e97c2f49e..43a125e273 100644 --- a/drivers/ram/rockchip/Kconfig +++ b/drivers/ram/rockchip/Kconfig @@ -14,7 +14,6 @@ config ROCKCHIP_SDRAM_COMMON config RAM_ROCKCHIP_DEBUG bool "Rockchip ram drivers debugging" depends on RAM_ROCKCHIP - default y help This enables debugging ram driver API's for the platforms based on Rockchip SoCs.
Like the name says, it is debug output and should not be enabled by default as it just clutters the console. I know this basically reverts commit fba7bd4c34c5 ("ram: rockchip: Default enable DRAM debug info"). But if there is so important information printed on the console as indicated in the commit description (which I didn't saw for the LPDDR4 initialization), it shouldn't be debug in the first place. Signed-off-by: Michael Walle <michael@walle.cc> --- drivers/ram/rockchip/Kconfig | 1 - 1 file changed, 1 deletion(-)