diff mbox series

[v1,05/15] x86: dfi: dfi-bt700: Remove dead code

Message ID 20200806145438.65862-5-andriy.shevchenko@linux.intel.com
State Superseded
Delegated to: Bin Meng
Headers show
Series [v1,01/15] x86: Introduce USE_EARLY_BOARD_INIT option | expand

Commit Message

Andy Shevchenko Aug. 6, 2020, 2:54 p.m. UTC
start.S does nothing and can be safely removed. Makefile is still being used
by the build system, so simply drop the rule from it.

Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 board/dfi/dfi-bt700/Makefile | 2 +-
 board/dfi/dfi-bt700/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/dfi/dfi-bt700/start.S

Comments

Stefan Roese Aug. 6, 2020, 3:05 p.m. UTC | #1
On 06.08.20 16:54, Andy Shevchenko wrote:
> start.S does nothing and can be safely removed. Makefile is still being used
> by the build system, so simply drop the rule from it.
> 
> Cc: Stefan Roese <sr@denx.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   board/dfi/dfi-bt700/Makefile | 2 +-
>   board/dfi/dfi-bt700/start.S  | 8 --------
>   2 files changed, 1 insertion(+), 9 deletions(-)
>   delete mode 100644 board/dfi/dfi-bt700/start.S
> 
> diff --git a/board/dfi/dfi-bt700/Makefile b/board/dfi/dfi-bt700/Makefile
> index 99cf357b701f..50d88f295458 100644
> --- a/board/dfi/dfi-bt700/Makefile
> +++ b/board/dfi/dfi-bt700/Makefile
> @@ -2,5 +2,5 @@
>   #
>   # Copyright (C) 2015, Google, Inc
>   
> -obj-y	+= dfi-bt700.o start.o
> +obj-y	+= dfi-bt700.o
>   obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
> diff --git a/board/dfi/dfi-bt700/start.S b/board/dfi/dfi-bt700/start.S
> deleted file mode 100644
> index 65d1f7e96150..000000000000
> --- a/board/dfi/dfi-bt700/start.S
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ */
> -/*
> - * Copyright (C) 2015, Google, Inc
> - */
> -
> -.globl early_board_init
> -early_board_init:
> -	jmp	early_board_init_ret
> 


Viele Grüße,
Stefan
diff mbox series

Patch

diff --git a/board/dfi/dfi-bt700/Makefile b/board/dfi/dfi-bt700/Makefile
index 99cf357b701f..50d88f295458 100644
--- a/board/dfi/dfi-bt700/Makefile
+++ b/board/dfi/dfi-bt700/Makefile
@@ -2,5 +2,5 @@ 
 #
 # Copyright (C) 2015, Google, Inc
 
-obj-y	+= dfi-bt700.o start.o
+obj-y	+= dfi-bt700.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
diff --git a/board/dfi/dfi-bt700/start.S b/board/dfi/dfi-bt700/start.S
deleted file mode 100644
index 65d1f7e96150..000000000000
--- a/board/dfi/dfi-bt700/start.S
+++ /dev/null
@@ -1,8 +0,0 @@ 
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Google, Inc
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret