diff mbox series

[v2] travis: update sbsigntools to 0.9.4

Message ID 20200729023622.11782-1-takahiro.akashi@linaro.org
State Accepted, archived
Headers show
Series [v2] travis: update sbsigntools to 0.9.4 | expand

Commit Message

AKASHI Takahiro July 29, 2020, 2:36 a.m. UTC
This version of sbsigntools is a prerequisite in testing "intermediate
certificates" support as part of UEFI secure boot as I added '--addcert'
option to 'sbsign' command:

  ===
  commit 7d6210e4b1fd
  Author: AKASHI Takahiro <takahiro.akashi at linaro.org>
  Date:   Thu Jun 4 16:50:22 2020 +0900

    sbsign: allow for adding intermediate certificates
  ===

Please note that, even after this patch is applied, UEFI secure boot
test can fail due to an issue with make-virt-fs.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
v2:
 * move the code to 'build' section per Tom
v1:
 * execute 'make install' with sudo
---
 .travis.yml | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Tom Rini July 30, 2020, 1:55 p.m. UTC | #1
On Wed, Jul 29, 2020 at 11:36:22AM +0900, AKASHI Takahiro wrote:

> This version of sbsigntools is a prerequisite in testing "intermediate
> certificates" support as part of UEFI secure boot as I added '--addcert'
> option to 'sbsign' command:
> 
>   ===
>   commit 7d6210e4b1fd
>   Author: AKASHI Takahiro <takahiro.akashi at linaro.org>
>   Date:   Thu Jun 4 16:50:22 2020 +0900
> 
>     sbsign: allow for adding intermediate certificates
>   ===
> 
> Please note that, even after this patch is applied, UEFI secure boot
> test can fail due to an issue with make-virt-fs.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> v2:
>  * move the code to 'build' section per Tom
> v1:
>  * execute 'make install' with sudo
> ---
>  .travis.yml | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 1ff140855ea3..dfc110a403b2 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -52,6 +52,14 @@ addons:
>      - sbsigntool
>      - fakeroot
>      - mtd-utils
> +    - automake
> +    - binutils-dev
> +    - gnu-efi
> +    - help2man
> +    - libguestfs-tools
> +    - linux-image-kvm
> +    - pkg-config
> +    - uuid-dev

Do you have a travis run from applying this patch available?  I'm
concerned that with libguestfs-tools installed now the filesystem tests
will move to "skip" rather than run.
AKASHI Takahiro July 31, 2020, 12:44 a.m. UTC | #2
On Thu, Jul 30, 2020 at 09:55:39AM -0400, Tom Rini wrote:
> On Wed, Jul 29, 2020 at 11:36:22AM +0900, AKASHI Takahiro wrote:
> 
> > This version of sbsigntools is a prerequisite in testing "intermediate
> > certificates" support as part of UEFI secure boot as I added '--addcert'
> > option to 'sbsign' command:
> > 
> >   ===
> >   commit 7d6210e4b1fd
> >   Author: AKASHI Takahiro <takahiro.akashi at linaro.org>
> >   Date:   Thu Jun 4 16:50:22 2020 +0900
> > 
> >     sbsign: allow for adding intermediate certificates
> >   ===
> > 
> > Please note that, even after this patch is applied, UEFI secure boot
> > test can fail due to an issue with make-virt-fs.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> > v2:
> >  * move the code to 'build' section per Tom
> > v1:
> >  * execute 'make install' with sudo
> > ---
> >  .travis.yml | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/.travis.yml b/.travis.yml
> > index 1ff140855ea3..dfc110a403b2 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -52,6 +52,14 @@ addons:
> >      - sbsigntool
> >      - fakeroot
> >      - mtd-utils
> > +    - automake
> > +    - binutils-dev
> > +    - gnu-efi
> > +    - help2man
> > +    - libguestfs-tools
> > +    - linux-image-kvm
> > +    - pkg-config
> > +    - uuid-dev
> 
> Do you have a travis run from applying this patch available?  I'm
> concerned that with libguestfs-tools installed now the filesystem tests
> will move to "skip" rather than run.

Yes, I saw that the filesystem tests were skipped.

-Takahiro Akashi

> 
> -- 
> Tom
Tom Rini July 31, 2020, 3:23 a.m. UTC | #3
On Fri, Jul 31, 2020 at 09:44:30AM +0900, AKASHI Takahiro wrote:
> On Thu, Jul 30, 2020 at 09:55:39AM -0400, Tom Rini wrote:
> > On Wed, Jul 29, 2020 at 11:36:22AM +0900, AKASHI Takahiro wrote:
> > 
> > > This version of sbsigntools is a prerequisite in testing "intermediate
> > > certificates" support as part of UEFI secure boot as I added '--addcert'
> > > option to 'sbsign' command:
> > > 
> > >   ===
> > >   commit 7d6210e4b1fd
> > >   Author: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > >   Date:   Thu Jun 4 16:50:22 2020 +0900
> > > 
> > >     sbsign: allow for adding intermediate certificates
> > >   ===
> > > 
> > > Please note that, even after this patch is applied, UEFI secure boot
> > > test can fail due to an issue with make-virt-fs.
> > > 
> > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > > ---
> > > v2:
> > >  * move the code to 'build' section per Tom
> > > v1:
> > >  * execute 'make install' with sudo
> > > ---
> > >  .travis.yml | 20 ++++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > > 
> > > diff --git a/.travis.yml b/.travis.yml
> > > index 1ff140855ea3..dfc110a403b2 100644
> > > --- a/.travis.yml
> > > +++ b/.travis.yml
> > > @@ -52,6 +52,14 @@ addons:
> > >      - sbsigntool
> > >      - fakeroot
> > >      - mtd-utils
> > > +    - automake
> > > +    - binutils-dev
> > > +    - gnu-efi
> > > +    - help2man
> > > +    - libguestfs-tools
> > > +    - linux-image-kvm
> > > +    - pkg-config
> > > +    - uuid-dev
> > 
> > Do you have a travis run from applying this patch available?  I'm
> > concerned that with libguestfs-tools installed now the filesystem tests
> > will move to "skip" rather than run.
> 
> Yes, I saw that the filesystem tests were skipped.

Well that's a blocker for this then.
diff mbox series

Patch

diff --git a/.travis.yml b/.travis.yml
index 1ff140855ea3..dfc110a403b2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -52,6 +52,14 @@  addons:
     - sbsigntool
     - fakeroot
     - mtd-utils
+    - automake
+    - binutils-dev
+    - gnu-efi
+    - help2man
+    - libguestfs-tools
+    - linux-image-kvm
+    - pkg-config
+    - uuid-dev
 
 install:
  # Clone uboot-test-hooks
@@ -112,6 +120,18 @@  before_script:
        ./tools/buildman/buildman --fetch-arch riscv32 &&
        ./tools/buildman/buildman --fetch-arch riscv64;
     fi
+  # Build sbsigntools, 0.9.4
+  - if [[ "${TEST_PY_BD}" != "" ]]; then
+       git clone https://git.kernel.org/pub/scm/linux/kernel/git/jejb/sbsigntools.git /tmp/sbsigntools &&
+       pushd /tmp/sbsigntools &&
+       git checkout -b latest v0.9.4 &&
+       ./autogen.sh &&
+       ./configure &&
+       make &&
+       sudo make install &&
+       popd
+    fi
+
   - if [[ "${QEMU_TARGET}" != "" ]]; then
        git clone git://git.qemu.org/qemu.git /tmp/qemu;
        pushd /tmp/qemu;