diff mbox series

[v3,2/2] x86: p2sb: make P2SB driver depend on P2SB uclass

Message ID 20200701113724.255226-3-wolfgang.wallner@br-automation.com
State Accepted
Commit ce04a9020c41a2ebf1d85e01532da69d2d2e2119
Delegated to: Bin Meng
Headers show
Series x86: p2sb: P2SB fixes | expand

Commit Message

Wolfgang Wallner July 1, 2020, 11:37 a.m. UTC 
Currently it is possible to select the P2SB driver without selecting the
P2SB uclass, which can't work. Fix this by adding a "depends on" in
Kconfig.

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>

---

(no changes since v2)

Changes in v2:
- Fixed cover letter

 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass July 3, 2020, 3:50 a.m. UTC | #1 
On Wed, 1 Jul 2020 at 05:37, Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently it is possible to select the P2SB driver without selecting the
> P2SB uclass, which can't work. Fix this by adding a "depends on" in
> Kconfig.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Fixed cover letter
>
>  arch/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Bin Meng July 13, 2020, 2:01 a.m. UTC | #2 
On Wed, Jul 1, 2020 at 7:37 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently it is possible to select the P2SB driver without selecting the
> P2SB uclass, which can't work. Fix this by adding a "depends on" in
> Kconfig.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Fixed cover letter
>
>  arch/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index c8eae24c07..27295ef384 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -717,6 +717,7 @@  config HAVE_ITSS
 
 config HAVE_P2SB
 	bool "Enable P2SB"
+	depends on P2SB
 	help
 	  Select this to include the driver for the Primary to
 	  Sideband Bridge (P2SB) which is found on several Intel