| Message ID | 20200701013320.130441-1-drew@beagleboard.org |
|---|---|
| Headers | show |
| Series | pinctrl: single: support #pinctrl-cells = 2 | expand |
* Drew Fustini <drew@beagleboard.org> [200701 01:34]: > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then > pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to > get the value to store in the register. > > To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in > omap.h is modified to keep pin conf and pin mux values separate. > > change log: > - v4: squash patches 2 and 3 together so that git biesct will not result > in a boot failure Thanks for updating it. Best that Linus queues both patches via the pinctrl tree when no more comments: Acked-by: Tony Lindgren <tony@atomide.com>
On Wed, 1 Jul 2020 at 09:33, Drew Fustini <drew@beagleboard.org> wrote: > > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then > pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to > get the value to store in the register. > > To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in > omap.h is modified to keep pin conf and pin mux values separate. > > change log: > - v4: squash patches 2 and 3 together so that git biesct will not result > in a boot failure > > - v3: change order of patches to make sure the pinctrl-single.c patch > does not break anything without the dts patches > > - v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a > compile error in dtc. I had added it per suggestion from checkpatch > about having parentheses around complex values. > > Drew Fustini (2): > pinctrl: single: parse #pinctrl-cells = 2 > ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 > > arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- > drivers/pinctrl/pinctrl-single.c | 11 +++++++++-- > include/dt-bindings/pinctrl/omap.h | 2 +- > 3 files changed, 11 insertions(+), 4 deletions(-) > > -- > 2.25.1 > Acked-by: Haojian Zhuang <haojian.zhuang@linaro.org>
On Wed, Jul 1, 2020 at 3:33 AM Drew Fustini <drew@beagleboard.org> wrote: > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then > pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to > get the value to store in the register. > > To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in > omap.h is modified to keep pin conf and pin mux values separate. > > change log: > - v4: squash patches 2 and 3 together so that git biesct will not result > in a boot failure > > - v3: change order of patches to make sure the pinctrl-single.c patch > does not break anything without the dts patches > > - v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a > compile error in dtc. I had added it per suggestion from checkpatch > about having parentheses around complex values. > > Drew Fustini (2): > pinctrl: single: parse #pinctrl-cells = 2 > ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 Both patches applied to the pinctrl devel branch for v5.9! Please make sure not to create colliding patches in the DTS files merged through ARM SoC this merge window. Yours, Linus Walleij
On Tue, Jul 7, 2020 at 1:01 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Jul 1, 2020 at 3:33 AM Drew Fustini <drew@beagleboard.org> wrote: > > > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then > > pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to > > get the value to store in the register. > > > > To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in > > omap.h is modified to keep pin conf and pin mux values separate. > > > > change log: > > - v4: squash patches 2 and 3 together so that git biesct will not result > > in a boot failure > > > > - v3: change order of patches to make sure the pinctrl-single.c patch > > does not break anything without the dts patches > > > > - v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a > > compile error in dtc. I had added it per suggestion from checkpatch > > about having parentheses around complex values. > > > > Drew Fustini (2): > > pinctrl: single: parse #pinctrl-cells = 2 > > ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 > > Both patches applied to the pinctrl devel branch for v5.9! > > Please make sure not to create colliding patches in the DTS files merged > through ARM SoC this merge window. > > Yours, > Linus Walleij Thanks. Which repo/branch is the best for me to use if I am going to be posting any further dts patches? -drew
On Tue, Jul 7, 2020 at 1:02 PM Drew Fustini <pdp7pdp7@gmail.com> wrote: > Which repo/branch is the best for me to use if I am going to be > posting any further dts patches? Mine, pinctrl devel branch during this (v5.9) cycle I suppose. Yours, Linus Walleij
Currently, pinctrl-single only allows #pinctrl-cells = 1. This series will allow pinctrl-single to also support #pinctrl-cells = 2 If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then pcs_parse_one_pinctrl_entry() does an OR operation on conf and mux to get the value to store in the register. To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in omap.h is modified to keep pin conf and pin mux values separate. change log: - v4: squash patches 2 and 3 together so that git biesct will not result in a boot failure - v3: change order of patches to make sure the pinctrl-single.c patch does not break anything without the dts patches - v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a compile error in dtc. I had added it per suggestion from checkpatch about having parentheses around complex values. Drew Fustini (2): pinctrl: single: parse #pinctrl-cells = 2 ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- drivers/pinctrl/pinctrl-single.c | 11 +++++++++-- include/dt-bindings/pinctrl/omap.h | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-)