| Message ID | 20200703205823.16912-1-pali@kernel.org |
|---|---|
| State | Accepted |
| Commit | 82c829d476f6239ccedc0474bd01850022175125 |
| Delegated to: | Lokesh Vutla |
| Headers | show |
| Series | mmc: omap_hsmmc: Set 3.3V for IO voltage on all places | expand |
On Fri 2020-07-03 22:58:23, Pali Rohár wrote: > In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") > was changed 3.0V IO voltage to 3.3V but it was not done on all places in > omap_hsmmc driver. That commit broke eMMC support on Nokia N900. > > This patch fixes that problematic commit and changes 3.0V to 3.3V on all > remaining places in omap_hsmmc driver. > > Fixes: d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") > Signed-off-by: Pali Rohár <pali@kernel.org> Acked-by: Pavel Machek <pavel@ucw.cz>
Hi, On 04/07/20 2:28 am, Pali Rohár wrote: > In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") > was changed 3.0V IO voltage to 3.3V but it was not done on all places in > omap_hsmmc driver. That commit broke eMMC support on Nokia N900. > > This patch fixes that problematic commit and changes 3.0V to 3.3V on all > remaining places in omap_hsmmc driver. > > Fixes: d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") > Signed-off-by: Pali Rohár <pali@kernel.org> > --- Reviewed-by: Faiz Abbas <faiz_abbas@ti.com> Thanks, Faiz
diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c index 8636cd713a..dc26e54795 100644 --- a/drivers/mmc/omap_hsmmc.c +++ b/drivers/mmc/omap_hsmmc.c @@ -840,7 +840,7 @@ static int omap_hsmmc_init_setup(struct mmc *mmc) omap_hsmmc_conf_bus_power(mmc, (reg_val & VS33_3V3SUP) ? MMC_SIGNAL_VOLTAGE_330 : MMC_SIGNAL_VOLTAGE_180); #else - writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V0, &mmc_base->hctl); + writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V3, &mmc_base->hctl); writel(readl(&mmc_base->capa) | VS33_3V3SUP | VS18_1V8SUP, &mmc_base->capa); #endif
In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") was changed 3.0V IO voltage to 3.3V but it was not done on all places in omap_hsmmc driver. That commit broke eMMC support on Nokia N900. This patch fixes that problematic commit and changes 3.0V to 3.3V on all remaining places in omap_hsmmc driver. Fixes: d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") Signed-off-by: Pali Rohár <pali@kernel.org> --- drivers/mmc/omap_hsmmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)