| Message ID | 20200623062812.705264-1-yamada.masahiro@socionext.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | dt-bindings: bus: uniphier-system-bus: fix warning in example | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 8 lines checked |
| robh/dt-meta-schema | success |
On Tue, Jun 23, 2020 at 3:29 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Since commit e69f5dc623f9 ("dt-bindings: serial: Convert 8250 to > json-schema"), the schema for "ns16550a" is checked. > > 'make dt_binding_check' emits the following warning: > > uart@5,00200000: $nodename:0: 'uart@5,00200000' does not match '^serial(@[0-9a-f,]+)*$' > > Rename the node to follow the pattern defined in > Documentation/devicetree/bindings/serial/serial.yaml > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > .../devicetree/bindings/bus/socionext,uniphier-system-bus.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml b/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml > index c4c9119e4a20..9fa4f891fa00 100644 > --- a/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml > +++ b/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml > @@ -87,7 +87,7 @@ examples: > phy-mode = "mii"; > }; > > - uart@5,00200000 { > + serial@5,00200000 { I think '5,200000' is a better unit name. Will send v2. > compatible = "ns16550a"; > reg = <5 0x00200000 0x20>; > interrupts = <0 49 4>; > -- > 2.25.1 >
diff --git a/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml b/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml index c4c9119e4a20..9fa4f891fa00 100644 --- a/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml +++ b/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml @@ -87,7 +87,7 @@ examples: phy-mode = "mii"; }; - uart@5,00200000 { + serial@5,00200000 { compatible = "ns16550a"; reg = <5 0x00200000 0x20>; interrupts = <0 49 4>;
Since commit e69f5dc623f9 ("dt-bindings: serial: Convert 8250 to json-schema"), the schema for "ns16550a" is checked. 'make dt_binding_check' emits the following warning: uart@5,00200000: $nodename:0: 'uart@5,00200000' does not match '^serial(@[0-9a-f,]+)*$' Rename the node to follow the pattern defined in Documentation/devicetree/bindings/serial/serial.yaml Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- .../devicetree/bindings/bus/socionext,uniphier-system-bus.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)