| Message ID | 20200617173316.32533-1-festevam@gmail.com |
|---|---|
| State | Accepted |
| Commit | 041dd8e9c4be5bcb49845955e4c472d0c2c46e1e |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode | expand |
On Wed, Jun 17, 2020 at 02:33:16PM -0300, Fabio Estevam wrote: > As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode) > the correct phy-mode should be "rgmii-id", so fix it accordingly > to fix the Ethernet regression. > > This problem has been exposed by commit: > > commit 13114f38e2ccea9386726d8b9831dfc310589548 > Author: Vladimir Oltean <vladimir.oltean@nxp.com> > Date: Thu May 7 00:11:51 2020 +0200 > > phy: atheros: Explicitly disable RGMII delays > > To eliminate any doubts about the out-of-reset value of the PHY, that > the driver previously relied on. > > If bisecting shows that this commit breaks your board you probably have > a wrong PHY interface mode. You probably want the > PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Acked-by: Joe Hershberger <joe.hershberger@ni.com> > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > Hi, > > Probably syncing with the mainline kernel would help fixing other boards. > > I tried this approach and noticed some dtb build breakage as there are some > dtbs that are not in mainline, so to be on the safe side, apply the minimal > fix for the sabresd board to fix the regression for 2020.07. As part of tracking down the cubox problem yesterday before posting I found that some parts of your commit 0672d22a1924 in the kernel applied in U-Boot, mainly, ah, the sabre* boards. Others were already fixed or absent.
> As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode) > the correct phy-mode should be "rgmii-id", so fix it accordingly > to fix the Ethernet regression. > This problem has been exposed by commit: > commit 13114f38e2ccea9386726d8b9831dfc310589548 > Author: Vladimir Oltean <vladimir.oltean@nxp.com> > Date: Thu May 7 00:11:51 2020 +0200 > phy: atheros: Explicitly disable RGMII delays > > To eliminate any doubts about the out-of-reset value of the PHY, that > the driver previously relied on. > > If bisecting shows that this commit breaks your board you probably have > a wrong PHY interface mode. You probably want the > PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Acked-by: Joe Hershberger <joe.hershberger@ni.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/dts/imx6qdl-sabresd.dtsi b/arch/arm/dts/imx6qdl-sabresd.dtsi index 2cd5a9fbac..eddb390174 100644 --- a/arch/arm/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/dts/imx6qdl-sabresd.dtsi @@ -204,7 +204,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; status = "okay"; };
As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode) the correct phy-mode should be "rgmii-id", so fix it accordingly to fix the Ethernet regression. This problem has been exposed by commit: commit 13114f38e2ccea9386726d8b9831dfc310589548 Author: Vladimir Oltean <vladimir.oltean@nxp.com> Date: Thu May 7 00:11:51 2020 +0200 phy: atheros: Explicitly disable RGMII delays To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on. If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com> Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Hi, Probably syncing with the mainline kernel would help fixing other boards. I tried this approach and noticed some dtb build breakage as there are some dtbs that are not in mainline, so to be on the safe side, apply the minimal fix for the sabresd board to fix the regression for 2020.07. arch/arm/dts/imx6qdl-sabresd.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)