Message ID | 20200526195633.11543-5-miquel.raynal@bootlin.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | Introduce the generic ECC engine abstraction | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/dt-meta-schema | success |
On Tue, 26 May 2020 21:56:16 +0200 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > This mode has never actually been used, it was introduced for a single > driver and even this driver did not use it in the DT but only in the > code. Now that this mode has been removed, let's trim the bindings > definition to avoid carrying useless properties. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > Documentation/devicetree/bindings/mtd/atmel-nand.txt | 3 +-- > Documentation/devicetree/bindings/mtd/nand-controller.yaml | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > index 3aa297c97ab6..ead1826d0d51 100644 > --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > @@ -143,8 +143,7 @@ Required properties: > Optional properties: > - atmel,nand-has-dma : boolean to support dma transfer for nand read/write. > - nand-ecc-mode : String, operation mode of the NAND ecc mode, soft by default. > - Supported values are: "none", "soft", "hw", "hw_syndrome", "hw_oob_first", > - "soft_bch". > + Supported values are: "none", "soft", "hw", "hw_syndrome", "soft_bch". > - atmel,has-pmecc : boolean to enable Programmable Multibit ECC hardware, > capable of BCH encoding and decoding, on devices where it is present. > - atmel,pmecc-cap : error correct capability for Programmable Multibit ECC > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > index d261b7096c69..d529f8587ba6 100644 > --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > @@ -49,7 +49,7 @@ patternProperties: > nand-ecc-mode: > allOf: > - $ref: /schemas/types.yaml#/definitions/string > - - enum: [ none, soft, hw, hw_syndrome, hw_oob_first, on-die ] > + - enum: [ none, soft, hw, hw_syndrome, on-die ] > description: > Desired ECC engine, either hardware (most of the time > embedded in the NAND controller) or software correction
On Tue, 2020-05-26 at 19:56:16 UTC, Miquel Raynal wrote: > This mode has never actually been used, it was introduced for a single > driver and even this driver did not use it in the DT but only in the > code. Now that this mode has been removed, let's trim the bindings > definition to avoid carrying useless properties. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel
diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt index 3aa297c97ab6..ead1826d0d51 100644 --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt @@ -143,8 +143,7 @@ Required properties: Optional properties: - atmel,nand-has-dma : boolean to support dma transfer for nand read/write. - nand-ecc-mode : String, operation mode of the NAND ecc mode, soft by default. - Supported values are: "none", "soft", "hw", "hw_syndrome", "hw_oob_first", - "soft_bch". + Supported values are: "none", "soft", "hw", "hw_syndrome", "soft_bch". - atmel,has-pmecc : boolean to enable Programmable Multibit ECC hardware, capable of BCH encoding and decoding, on devices where it is present. - atmel,pmecc-cap : error correct capability for Programmable Multibit ECC diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml index d261b7096c69..d529f8587ba6 100644 --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml @@ -49,7 +49,7 @@ patternProperties: nand-ecc-mode: allOf: - $ref: /schemas/types.yaml#/definitions/string - - enum: [ none, soft, hw, hw_syndrome, hw_oob_first, on-die ] + - enum: [ none, soft, hw, hw_syndrome, on-die ] description: Desired ECC engine, either hardware (most of the time embedded in the NAND controller) or software correction
This mode has never actually been used, it was introduced for a single driver and even this driver did not use it in the DT but only in the code. Now that this mode has been removed, let's trim the bindings definition to avoid carrying useless properties. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- Documentation/devicetree/bindings/mtd/atmel-nand.txt | 3 +-- Documentation/devicetree/bindings/mtd/nand-controller.yaml | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)