| Message ID | 20200329170538.25449-1-pragnesh.patel@sifive.com |
|---|---|
| Headers | show |
| Series | RISC-V SiFive FU540 support SPL | expand |
On Sun, Mar 29, 2020 at 10:36 PM Pragnesh Patel <pragnesh.patel@sifive.com> wrote: > > This series add support for SPL to FU540.U-Boot SPL can boot from > L2 LIM (0x0800_0000) and jump to OpenSBI(FW_DYNAMIC firmware) and > U-Boot proper from MMC devices. > > How to test this patch: > 1) Go to OpenSBI-dir : make PLATFORM=sifive/fu540 O=build_dir I=install_dir FW_DYNAMIC=y install > 2) cp install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin <u-boot-dir>/ I think setting OPENSBI=<path/to/opensbi/install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin> would help to attach the opensbi instead of copying into the source directory. Would you please check that. Jagan.
Hi Jagan, >-----Original Message----- >From: Jagan Teki <jagan@amarulasolutions.com> >Sent: 02 April 2020 14:42 >To: Pragnesh Patel <pragnesh.patel@sifive.com> >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra ><atish.patra@wdc.com>; palmerdabbelt@google.com; Bin Meng ><bmeng.cn@gmail.com>; Paul Walmsley <paul.walmsley@sifive.com>; Troy >Benjegerdes <troy.benjegerdes@sifive.com>; Anup Patel ><anup.patel@wdc.com>; Sagar Kadam <sagar.kadam@sifive.com>; Rick Chen ><rick@andestech.com> >Subject: Re: [PATCH v6 00/17] RISC-V SiFive FU540 support SPL > >[External Email] Do not click links or attachments unless you recognize the >sender and know the content is safe > >On Sun, Mar 29, 2020 at 10:36 PM Pragnesh Patel ><pragnesh.patel@sifive.com> wrote: >> >> This series add support for SPL to FU540.U-Boot SPL can boot from >> L2 LIM (0x0800_0000) and jump to OpenSBI(FW_DYNAMIC firmware) and >> U-Boot proper from MMC devices. >> >> How to test this patch: >> 1) Go to OpenSBI-dir : make PLATFORM=sifive/fu540 O=build_dir >> I=install_dir FW_DYNAMIC=y install >> 2) cp install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin >> <u-boot-dir>/ > >I think setting >OPENSBI=<path/to/opensbi/install_dir/platform/sifive/fu540/firmware/fw_d >ynamic.bin> >would help to attach the opensbi instead of copying into the source directory. >Would you please check that. Yes that will also work, if I need to submit v7 then will update this. > >Jagan.
On Thu, Apr 2, 2020 at 3:12 PM Pragnesh Patel <pragnesh.patel@sifive.com> wrote: > > Hi Jagan, > > >-----Original Message----- > >From: Jagan Teki <jagan@amarulasolutions.com> > >Sent: 02 April 2020 14:42 > >To: Pragnesh Patel <pragnesh.patel@sifive.com> > >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra > ><atish.patra@wdc.com>; palmerdabbelt@google.com; Bin Meng > ><bmeng.cn@gmail.com>; Paul Walmsley <paul.walmsley@sifive.com>; Troy > >Benjegerdes <troy.benjegerdes@sifive.com>; Anup Patel > ><anup.patel@wdc.com>; Sagar Kadam <sagar.kadam@sifive.com>; Rick Chen > ><rick@andestech.com> > >Subject: Re: [PATCH v6 00/17] RISC-V SiFive FU540 support SPL > > > >[External Email] Do not click links or attachments unless you recognize the > >sender and know the content is safe > > > >On Sun, Mar 29, 2020 at 10:36 PM Pragnesh Patel > ><pragnesh.patel@sifive.com> wrote: > >> > >> This series add support for SPL to FU540.U-Boot SPL can boot from > >> L2 LIM (0x0800_0000) and jump to OpenSBI(FW_DYNAMIC firmware) and > >> U-Boot proper from MMC devices. > >> > >> How to test this patch: > >> 1) Go to OpenSBI-dir : make PLATFORM=sifive/fu540 O=build_dir > >> I=install_dir FW_DYNAMIC=y install > >> 2) cp install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin > >> <u-boot-dir>/ > > > >I think setting > >OPENSBI=<path/to/opensbi/install_dir/platform/sifive/fu540/firmware/fw_d > >ynamic.bin> > >would help to attach the opensbi instead of copying into the source directory. > >Would you please check that. > > Yes that will also work, if I need to submit v7 then will update this. Thanks, please wait for sometime I'll send my comments for the rest of the patches. Jagan.
Hi Pragnesh, On Sun, Mar 29, 2020 at 10:36 PM Pragnesh Patel <pragnesh.patel@sifive.com> wrote: > > This series add support for SPL to FU540.U-Boot SPL can boot from > L2 LIM (0x0800_0000) and jump to OpenSBI(FW_DYNAMIC firmware) and > U-Boot proper from MMC devices. > > How to test this patch: > 1) Go to OpenSBI-dir : make PLATFORM=sifive/fu540 O=build_dir I=install_dir FW_DYNAMIC=y install > 2) cp install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin <u-boot-dir>/ > 3) Change to u-boot-dir > 4) make sifive_fu540_defconfig > 5) make all > 6) ZSBL loads the U-boot SPL(u-boot-spl.bin) from a partition with > GUID type 5B193300-FC78-40CD-8002-E86C45580B47 > > sudo dd if=spl/u-boot-spl.bin of=/dev/sdc4 bs=1M > > 7) U-boot SPL expects a u-boot FIT image(u-boot.itb) from 1st partition(/dev/sdc1) > of SD card irrespective of GUID > > sudo dd if=u-boot.itb of=/dev/sdc1 bs=1M Seems like SPL (sdc4) at 4th partition and U-Boot proper at first partition which seems an unconventional way to create partition layouts based on the booting stage hierarchy. I did send the changes on top of our changes [1] which indeed follow the conventional partition layout. So feel free to incorporate your series while sending the next version. So from next version, you can drop CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION and write images as, $ sudo dd if=u-boot.itb of=/dev/sda seek=4096 $ sudo dd if=spl/u-boot-spl.bin of=/dev/sda seek=2048 [1] https://patchwork.ozlabs.org/project/uboot/list/?series=168967 Jagan.
Hi Jagan, >-----Original Message----- >From: Jagan Teki <jagan@amarulasolutions.com> >Sent: 07 April 2020 15:02 >To: Pragnesh Patel <pragnesh.patel@sifive.com> >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra ><atish.patra@wdc.com>; palmerdabbelt@google.com; Bin Meng ><bmeng.cn@gmail.com>; Paul Walmsley <paul.walmsley@sifive.com>; Troy >Benjegerdes <troy.benjegerdes@sifive.com>; Anup Patel ><anup.patel@wdc.com>; Sagar Kadam <sagar.kadam@sifive.com>; Rick Chen ><rick@andestech.com> >Subject: Re: [PATCH v6 00/17] RISC-V SiFive FU540 support SPL > >[External Email] Do not click links or attachments unless you recognize the >sender and know the content is safe > >Hi Pragnesh, > >On Sun, Mar 29, 2020 at 10:36 PM Pragnesh Patel ><pragnesh.patel@sifive.com> wrote: >> >> This series add support for SPL to FU540.U-Boot SPL can boot from >> L2 LIM (0x0800_0000) and jump to OpenSBI(FW_DYNAMIC firmware) and >> U-Boot proper from MMC devices. >> >> How to test this patch: >> 1) Go to OpenSBI-dir : make PLATFORM=sifive/fu540 O=build_dir >> I=install_dir FW_DYNAMIC=y install >> 2) cp install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin >> <u-boot-dir>/ >> 3) Change to u-boot-dir >> 4) make sifive_fu540_defconfig >> 5) make all >> 6) ZSBL loads the U-boot SPL(u-boot-spl.bin) from a partition with >> GUID type 5B193300-FC78-40CD-8002-E86C45580B47 >> >> sudo dd if=spl/u-boot-spl.bin of=/dev/sdc4 bs=1M >> >> 7) U-boot SPL expects a u-boot FIT image(u-boot.itb) from 1st >partition(/dev/sdc1) >> of SD card irrespective of GUID >> >> sudo dd if=u-boot.itb of=/dev/sdc1 bs=1M > >Seems like SPL (sdc4) at 4th partition and U-Boot proper at first partition >which seems an unconventional way to create partition layouts based on the >booting stage hierarchy. > >I did send the changes on top of our changes [1] which indeed follow the >conventional partition layout. So feel free to incorporate your series while >sending the next version. > >So from next version, you can drop >CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION and write >images as, > >$ sudo dd if=u-boot.itb of=/dev/sda seek=4096 $ sudo dd if=spl/u-boot- >spl.bin of=/dev/sda seek=2048 > >[1] https://patchwork.ozlabs.org/project/uboot/list/?series=168967 Thanks Jagan, will update in v7. > >Jagan.
Hi Pragnesh, On Wed, Apr 8, 2020 at 12:42 PM Pragnesh Patel <pragnesh.patel@sifive.com> wrote: > > Hi Jagan, > > >-----Original Message----- > >From: Jagan Teki <jagan@amarulasolutions.com> > >Sent: 07 April 2020 15:02 > >To: Pragnesh Patel <pragnesh.patel@sifive.com> > >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra > ><atish.patra@wdc.com>; palmerdabbelt@google.com; Bin Meng > ><bmeng.cn@gmail.com>; Paul Walmsley <paul.walmsley@sifive.com>; Troy > >Benjegerdes <troy.benjegerdes@sifive.com>; Anup Patel > ><anup.patel@wdc.com>; Sagar Kadam <sagar.kadam@sifive.com>; Rick Chen > ><rick@andestech.com> > >Subject: Re: [PATCH v6 00/17] RISC-V SiFive FU540 support SPL > > > >[External Email] Do not click links or attachments unless you recognize the > >sender and know the content is safe > > > >Hi Pragnesh, > > > >On Sun, Mar 29, 2020 at 10:36 PM Pragnesh Patel > ><pragnesh.patel@sifive.com> wrote: > >> > >> This series add support for SPL to FU540.U-Boot SPL can boot from > >> L2 LIM (0x0800_0000) and jump to OpenSBI(FW_DYNAMIC firmware) and > >> U-Boot proper from MMC devices. > >> > >> How to test this patch: > >> 1) Go to OpenSBI-dir : make PLATFORM=sifive/fu540 O=build_dir > >> I=install_dir FW_DYNAMIC=y install > >> 2) cp install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin > >> <u-boot-dir>/ > >> 3) Change to u-boot-dir > >> 4) make sifive_fu540_defconfig > >> 5) make all > >> 6) ZSBL loads the U-boot SPL(u-boot-spl.bin) from a partition with > >> GUID type 5B193300-FC78-40CD-8002-E86C45580B47 > >> > >> sudo dd if=spl/u-boot-spl.bin of=/dev/sdc4 bs=1M > >> > >> 7) U-boot SPL expects a u-boot FIT image(u-boot.itb) from 1st > >partition(/dev/sdc1) > >> of SD card irrespective of GUID > >> > >> sudo dd if=u-boot.itb of=/dev/sdc1 bs=1M > > > >Seems like SPL (sdc4) at 4th partition and U-Boot proper at first partition > >which seems an unconventional way to create partition layouts based on the > >booting stage hierarchy. > > > >I did send the changes on top of our changes [1] which indeed follow the > >conventional partition layout. So feel free to incorporate your series while > >sending the next version. > > > >So from next version, you can drop > >CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION and write > >images as, > > > >$ sudo dd if=u-boot.itb of=/dev/sda seek=4096 $ sudo dd if=spl/u-boot- > >spl.bin of=/dev/sda seek=2048 > > > >[1] https://patchwork.ozlabs.org/project/uboot/list/?series=168967 > > Thanks Jagan, will update in v7. I've reviewed the v6 patches. Since Jagan also sent several series related to SPI and booting from SPI that is dependent on this series, would you please post a v7 soon? We need get this SPL support merged as soon as possible. Thank you. Regards, Bin
Hi Bin, >-----Original Message----- >From: Bin Meng <bmeng.cn@gmail.com> >Sent: 20 April 2020 20:13 >To: Pragnesh Patel <pragnesh.patel@sifive.com> >Cc: Jagan Teki <jagan@amarulasolutions.com>; U-Boot-Denx <u- >boot@lists.denx.de>; Atish Patra <atish.patra@wdc.com>; >palmerdabbelt@google.com; Paul Walmsley <paul.walmsley@sifive.com>; >Troy Benjegerdes <troy.benjegerdes@sifive.com>; Anup Patel ><anup.patel@wdc.com>; Sagar Kadam <sagar.kadam@sifive.com>; Rick Chen ><rick@andestech.com> >Subject: Re: [PATCH v6 00/17] RISC-V SiFive FU540 support SPL > >[External Email] Do not click links or attachments unless you recognize the >sender and know the content is safe > >Hi Pragnesh, > >On Wed, Apr 8, 2020 at 12:42 PM Pragnesh Patel ><pragnesh.patel@sifive.com> wrote: >> >> Hi Jagan, >> >> >-----Original Message----- >> >From: Jagan Teki <jagan@amarulasolutions.com> >> >Sent: 07 April 2020 15:02 >> >To: Pragnesh Patel <pragnesh.patel@sifive.com> >> >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra >> ><atish.patra@wdc.com>; palmerdabbelt@google.com; Bin Meng >> ><bmeng.cn@gmail.com>; Paul Walmsley <paul.walmsley@sifive.com>; >Troy >> >Benjegerdes <troy.benjegerdes@sifive.com>; Anup Patel >> ><anup.patel@wdc.com>; Sagar Kadam <sagar.kadam@sifive.com>; Rick >Chen >> ><rick@andestech.com> >> >Subject: Re: [PATCH v6 00/17] RISC-V SiFive FU540 support SPL >> > >> >[External Email] Do not click links or attachments unless you >> >recognize the sender and know the content is safe >> > >> >Hi Pragnesh, >> > >> >On Sun, Mar 29, 2020 at 10:36 PM Pragnesh Patel >> ><pragnesh.patel@sifive.com> wrote: >> >> >> >> This series add support for SPL to FU540.U-Boot SPL can boot from >> >> L2 LIM (0x0800_0000) and jump to OpenSBI(FW_DYNAMIC firmware) and >> >> U-Boot proper from MMC devices. >> >> >> >> How to test this patch: >> >> 1) Go to OpenSBI-dir : make PLATFORM=sifive/fu540 O=build_dir >> >> I=install_dir FW_DYNAMIC=y install >> >> 2) cp install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin >> >> <u-boot-dir>/ >> >> 3) Change to u-boot-dir >> >> 4) make sifive_fu540_defconfig >> >> 5) make all >> >> 6) ZSBL loads the U-boot SPL(u-boot-spl.bin) from a partition with >> >> GUID type 5B193300-FC78-40CD-8002-E86C45580B47 >> >> >> >> sudo dd if=spl/u-boot-spl.bin of=/dev/sdc4 bs=1M >> >> >> >> 7) U-boot SPL expects a u-boot FIT image(u-boot.itb) from 1st >> >partition(/dev/sdc1) >> >> of SD card irrespective of GUID >> >> >> >> sudo dd if=u-boot.itb of=/dev/sdc1 bs=1M >> > >> >Seems like SPL (sdc4) at 4th partition and U-Boot proper at first >> >partition which seems an unconventional way to create partition >> >layouts based on the booting stage hierarchy. >> > >> >I did send the changes on top of our changes [1] which indeed follow >> >the conventional partition layout. So feel free to incorporate your >> >series while sending the next version. >> > >> >So from next version, you can drop >> >CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION and write >images as, >> > >> >$ sudo dd if=u-boot.itb of=/dev/sda seek=4096 $ sudo dd >> >if=spl/u-boot- spl.bin of=/dev/sda seek=2048 >> > >> >[1] https://patchwork.ozlabs.org/project/uboot/list/?series=168967 >> >> Thanks Jagan, will update in v7. > >I've reviewed the v6 patches. Since Jagan also sent several series related to SPI >and booting from SPI that is dependent on this series, would you please post a >v7 soon? We need get this SPL support merged as soon as possible. Thank >you. Will submit v7 soon. > >Regards, >Bin
This series add support for SPL to FU540.U-Boot SPL can boot from L2 LIM (0x0800_0000) and jump to OpenSBI(FW_DYNAMIC firmware) and U-Boot proper from MMC devices. How to test this patch: 1) Go to OpenSBI-dir : make PLATFORM=sifive/fu540 O=build_dir I=install_dir FW_DYNAMIC=y install 2) cp install_dir/platform/sifive/fu540/firmware/fw_dynamic.bin <u-boot-dir>/ 3) Change to u-boot-dir 4) make sifive_fu540_defconfig 5) make all 6) ZSBL loads the U-boot SPL(u-boot-spl.bin) from a partition with GUID type 5B193300-FC78-40CD-8002-E86C45580B47 sudo dd if=spl/u-boot-spl.bin of=/dev/sdc4 bs=1M 7) U-boot SPL expects a u-boot FIT image(u-boot.itb) from 1st partition(/dev/sdc1) of SD card irrespective of GUID sudo dd if=u-boot.itb of=/dev/sdc1 bs=1M Thanks to Yash Shah <yash.shah@sifive.com> for testing the series. Changes in v6: - Typo Correction - Make fu540-c000-u-boot.dtsi and hifive-unleashed-a00-u-boot.dtsi Dual Licensed - Sync Hifive unleashed dts from Linux - Add arch/riscv/fu540 for FU540 specific code Changes in v5: - Return read/write bytes for sifive_otp_read and sifive_otp_write - Correct Palmer's email address Changes in v4: - Split misc DM driver patch into multiple patches - Added new SPL_CRC7_SUPPORT Kconfig option - Added DM driver for DDR - Added clk_enable and clk_disable ops in SiFive PRCI driver - Added early clock initialization for SPL in SiFive PRCI driver - Added SPL config options in sifive_fu540_defconfig instead of creatiing a new config file for SPL - Update fu540.rst on how to build and flash U-boot SPL Changes in v3: - Remove arch-fu540 and arch-sifive from arch/riscv/include/asm/ - Split SPL patches into DDR and SPL and spl defconfig - Update fu540/MAINTAINERS file - Update fu540.rst on how to build and flash U-boot SPL Changes in v2: - Add DM driver Sifive OTP - Split SPL patches into multiple patches - Add a seprate patch for _image_binary_end and crc7.c - Add a seprate patch to add board -u-boot.dtsi files - Update FU540 RISC-V documentation Pragnesh Patel (17): misc: add driver for the SiFive otp controller riscv: sifive: fu540: Use OTP DM driver for serial environment variable riscv: Add _image_binary_end for SPL lib: Makefile: build crc7.c when CONFIG_MMC_SPI riscv: sifive: dts: fu540: Add board -u-boot.dtsi files sifive: fu540: add ddr driver sifive: dts: fu540: Add DDR controller and phy register settings clk: sifive: fu540-prci: Add clock enable and disable ops clk: sifive: fu540-prci: Add clock initialization for SPL riscv: dts: sifive: Sync hifive-unleashed-a00 dts from linux sifive: dts: fu540: Enable gpio in U-Boot SPL riscv: sifive: fu540: add SPL configuration configs: fu540: Add config options for U-Boot SPL sifive: dts: fu540: Enable L2 Cache in U-Boot riscv: sifive: fu540: enable all cache ways from u-boot proper sifive: fix palmer's email address doc: update FU540 RISC-V documentation arch/riscv/Makefile | 1 + arch/riscv/cpu/u-boot-spl.lds | 1 + arch/riscv/dts/fu540-c000-u-boot.dtsi | 79 + arch/riscv/dts/fu540-c000.dtsi | 37 +- ...fu540-hifive-unleashed-a00-sdram-ddr4.dtsi | 1489 +++++++++++++++++ .../dts/hifive-unleashed-a00-u-boot.dtsi | 27 + arch/riscv/dts/hifive-unleashed-a00.dts | 9 + arch/riscv/fu540/Makefile | 10 + arch/riscv/fu540/cache.c | 58 + arch/riscv/fu540/spl.c | 30 + arch/riscv/include/asm/arch-generic/cache.h | 14 + arch/riscv/include/asm/arch-generic/gpio.h | 3 + arch/riscv/include/asm/arch-generic/spl.h | 14 + board/sifive/fu540/Kconfig | 10 + board/sifive/fu540/MAINTAINERS | 2 +- board/sifive/fu540/Makefile | 4 + board/sifive/fu540/fu540.c | 143 +- board/sifive/fu540/spl.c | 72 + common/spl/Kconfig | 6 + configs/sifive_fu540_defconfig | 11 + doc/board/sifive/fu540.rst | 409 ++++- drivers/clk/sifive/fu540-prci.c | 218 ++- drivers/misc/Kconfig | 7 + drivers/misc/Makefile | 1 + drivers/misc/sifive-otp.c | 255 +++ drivers/mmc/Kconfig | 1 + drivers/ram/Kconfig | 7 + drivers/ram/Makefile | 2 + drivers/ram/sifive/Kconfig | 8 + drivers/ram/sifive/Makefile | 6 + drivers/ram/sifive/sdram_fu540.c | 399 +++++ include/configs/sifive-fu540.h | 18 + lib/Makefile | 1 + 33 files changed, 3241 insertions(+), 111 deletions(-) create mode 100644 arch/riscv/dts/fu540-c000-u-boot.dtsi create mode 100644 arch/riscv/dts/fu540-hifive-unleashed-a00-sdram-ddr4.dtsi create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi create mode 100644 arch/riscv/fu540/Makefile create mode 100644 arch/riscv/fu540/cache.c create mode 100644 arch/riscv/fu540/spl.c create mode 100644 arch/riscv/include/asm/arch-generic/cache.h create mode 100644 arch/riscv/include/asm/arch-generic/spl.h create mode 100644 board/sifive/fu540/spl.c create mode 100644 drivers/misc/sifive-otp.c create mode 100644 drivers/ram/sifive/Kconfig create mode 100644 drivers/ram/sifive/Makefile create mode 100644 drivers/ram/sifive/sdram_fu540.c