| Message ID | 20200402165341.32941-1-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | a667cd8dd364031182dd0edfbee759f74f9c759f |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT | expand |
On Thu, Apr 02, 2020 at 06:53:41PM +0200, Marek Vasut wrote: > The card-detect GPIO and any other GPIO access currently doesn't work in > U-Boot SPL on any STM32 platform and crashes the SPL. To work around this > problem on AV96 right before release, remove the cd-gpios from DT. This > patch must be reverted right after release, once the proper fix for the > GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied. > > Signed-off-by: Marek Vasut <marex@denx.de> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Tom Rini <trini@konsulko.com> > --- > NOTE: I think it's OK if Tom picks this one directly to reduce load on > the ST people, since this is isolated to a single board. > --- > arch/arm/dts/stm32mp157a-avenger96.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/dts/stm32mp157a-avenger96.dts b/arch/arm/dts/stm32mp157a-avenger96.dts > index 1f32395e71..b23fa6dee0 100644 > --- a/arch/arm/dts/stm32mp157a-avenger96.dts > +++ b/arch/arm/dts/stm32mp157a-avenger96.dts > @@ -353,7 +353,6 @@ > pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>; > pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>; > pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>; > - cd-gpios = <&gpioi 8 GPIO_ACTIVE_LOW>; > disable-wp; > st,sig-dir; > st,neg-edge; > -- > 2.25.1 >
On Thu, Apr 02, 2020 at 06:53:41PM +0200, Marek Vasut wrote: > The card-detect GPIO and any other GPIO access currently doesn't work in > U-Boot SPL on any STM32 platform and crashes the SPL. To work around this > problem on AV96 right before release, remove the cd-gpios from DT. This > patch must be reverted right after release, once the proper fix for the > GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: Patrick Delaunay <patrick.delaunay@st.com> > Cc: Patrice Chotard <patrice.chotard@st.com> > Cc: Tom Rini <trini@konsulko.com> > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Applied to u-boot/master, thanks!
diff --git a/arch/arm/dts/stm32mp157a-avenger96.dts b/arch/arm/dts/stm32mp157a-avenger96.dts index 1f32395e71..b23fa6dee0 100644 --- a/arch/arm/dts/stm32mp157a-avenger96.dts +++ b/arch/arm/dts/stm32mp157a-avenger96.dts @@ -353,7 +353,6 @@ pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>; pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>; pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>; - cd-gpios = <&gpioi 8 GPIO_ACTIVE_LOW>; disable-wp; st,sig-dir; st,neg-edge;
The card-detect GPIO and any other GPIO access currently doesn't work in U-Boot SPL on any STM32 platform and crashes the SPL. To work around this problem on AV96 right before release, remove the cd-gpios from DT. This patch must be reverted right after release, once the proper fix for the GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: Patrick Delaunay <patrick.delaunay@st.com> Cc: Patrice Chotard <patrice.chotard@st.com> Cc: Tom Rini <trini@konsulko.com> --- NOTE: I think it's OK if Tom picks this one directly to reduce load on the ST people, since this is isolated to a single board. --- arch/arm/dts/stm32mp157a-avenger96.dts | 1 - 1 file changed, 1 deletion(-)