diff mbox series

i2c: ismt: Add missed pci_release_region

Message ID 20191109075435.29871-1-hslester96@gmail.com
State Needs Review / ACK
Headers show
Series i2c: ismt: Add missed pci_release_region | expand

Commit Message

Chuhong Yuan Nov. 9, 2019, 7:54 a.m. UTC
ismt_remove forgets to call pci_release_region when remove.
Add the call to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
 drivers/i2c/busses/i2c-ismt.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Wolfram Sang March 22, 2020, 4:08 p.m. UTC | #1
On Sat, Nov 09, 2019 at 03:54:35PM +0800, Chuhong Yuan wrote:
> ismt_remove forgets to call pci_release_region when remove.
> Add the call to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>

Chuhong Yuan, your To-Header is broken, so you never got a response.

Adding the maintainers to CC.

> ---
>  drivers/i2c/busses/i2c-ismt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 2f95e25a10f7..c393e629cac3 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
>  	struct ismt_priv *priv = pci_get_drvdata(pdev);
>  
>  	i2c_del_adapter(&priv->adapter);
> +
> +	pci_release_region(pdev, SMBBAR);
>  }
>  
>  static struct pci_driver ismt_driver = {
> -- 
> 2.23.0
>
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index 2f95e25a10f7..c393e629cac3 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -943,6 +943,8 @@  static void ismt_remove(struct pci_dev *pdev)
 	struct ismt_priv *priv = pci_get_drvdata(pdev);
 
 	i2c_del_adapter(&priv->adapter);
+
+	pci_release_region(pdev, SMBBAR);
 }
 
 static struct pci_driver ismt_driver = {