| Message ID | 20200316103216.29383-4-geert+renesas@glider.be |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: Renesas R-Car and TPU fixes | expand |
Hi Geert, Thank you for the patch. On Mon, Mar 16, 2020 at 11:32:16AM +0100, Geert Uytterhoeven wrote: > During device probe, the message > > TPU PWM -1 registered > > is printed. > > While the "-1" looks suspicious, it is perfectly normal for a device > instantiated from DT. > > Remove the message, as there are no non-DT users left, and other drivers > don't print such messages neither. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/pwm/pwm-renesas-tpu.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c > index 8032acc84161a9dd..81ad5a551455e4b8 100644 > --- a/drivers/pwm/pwm-renesas-tpu.c > +++ b/drivers/pwm/pwm-renesas-tpu.c > @@ -424,8 +424,6 @@ static int tpu_probe(struct platform_device *pdev) > return ret; > } > > - dev_info(&pdev->dev, "TPU PWM %d registered\n", tpu->pdev->id); > - > return 0; > } >
On Mon, Mar 16, 2020 at 11:32:16AM +0100, Geert Uytterhoeven wrote: > During device probe, the message > > TPU PWM -1 registered > > is printed. > > While the "-1" looks suspicious, it is perfectly normal for a device > instantiated from DT. > > Remove the message, as there are no non-DT users left, and other drivers > don't print such messages neither. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c index 8032acc84161a9dd..81ad5a551455e4b8 100644 --- a/drivers/pwm/pwm-renesas-tpu.c +++ b/drivers/pwm/pwm-renesas-tpu.c @@ -424,8 +424,6 @@ static int tpu_probe(struct platform_device *pdev) return ret; } - dev_info(&pdev->dev, "TPU PWM %d registered\n", tpu->pdev->id); - return 0; }
During device probe, the message TPU PWM -1 registered is printed. While the "-1" looks suspicious, it is perfectly normal for a device instantiated from DT. Remove the message, as there are no non-DT users left, and other drivers don't print such messages neither. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pwm/pwm-renesas-tpu.c | 2 -- 1 file changed, 2 deletions(-)