diff mbox series

[OpenWrt-Devel] .gitignore: ignore all .config* files

Message ID 20200310120204.6704-1-cc@80211.de
State Rejected
Delegated to: Adrian Schmutzler
Headers show
Series [OpenWrt-Devel] .gitignore: ignore all .config* files | expand

Commit Message

Catrinel Catrinescu March 10, 2020, 12:02 p.m. UTC 
From: Catrinel Catrinescu <cc@80211.de>

Signed-off-by: Catrinel Catrinescu <cc@80211.de>
---
 .gitignore | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Adrian Schmutzler March 10, 2020, 12:25 p.m. UTC | #1 
> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] On
> Behalf Of cc@80211.de
> Sent: Dienstag, 10. März 2020 13:02
> To: openwrt-devel@lists.openwrt.org
> Cc: Catrinel Catrinescu <cc@80211.de>
> Subject: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files

Why is this necessary (-> commit message)?

Or is it just a cosmetic replacement of two lines by one? (In that case, I'd
prefer the specific lines).

Best

Adrian

> 
> From: Catrinel Catrinescu <cc@80211.de>
> 
> Signed-off-by: Catrinel Catrinescu <cc@80211.de>
> ---
>  .gitignore | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 6549af83be..edffba9c05 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -3,8 +3,7 @@
>  .*.swp
>  /env
>  /dl
> -/.config
> -/.config.old
> +/.config*
>  /bin
>  /build_dir
>  /staging_dir
> --
> 2.17.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Catrinel Catrinescu March 10, 2020, 12:33 p.m. UTC | #2 
Hi Adrian

After successful testing, I always save the .config files, attaching the revision number, like .config_r12345.

And it is a cosmetic replacement too.


Thanks
Catrinel


-----Original Message-----
From: Adrian Schmutzler <mail@adrianschmutzler.de> 
Sent: Tuesday, 10 March 2020 13:26
To: Catrinel Catrinescu <cc@80211.de>; openwrt-devel@lists.openwrt.org
Subject: RE: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] 
> On Behalf Of cc@80211.de
> Sent: Dienstag, 10. März 2020 13:02
> To: openwrt-devel@lists.openwrt.org
> Cc: Catrinel Catrinescu <cc@80211.de>
> Subject: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files

Why is this necessary (-> commit message)?

Or is it just a cosmetic replacement of two lines by one? (In that case, I'd prefer the specific lines).

Best

Adrian

> 
> From: Catrinel Catrinescu <cc@80211.de>
> 
> Signed-off-by: Catrinel Catrinescu <cc@80211.de>
> ---
>  .gitignore | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 6549af83be..edffba9c05 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -3,8 +3,7 @@
>  .*.swp
>  /env
>  /dl
> -/.config
> -/.config.old
> +/.config*
>  /bin
>  /build_dir
>  /staging_dir
> --
> 2.17.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Sungbo Eo March 13, 2020, 1:26 p.m. UTC | #3 
Hi,

If we are going to accept this patch, I would suggest "/.config.*" 
instead of
"/.config*". That would suffice for all local usages.

Thanks.

On 2020-03-10 21:33, cc at 80211.de (Catrinel Catrinescu) wrote:
> Hi Adrian
>
> After successful testing, I always save the .config files, attaching the revision number, like .config_r12345.
>
> And it is a cosmetic replacement too.
>
>
> Thanks
> Catrinel
Adrian Schmutzler March 13, 2020, 2:30 p.m. UTC | #4 
> -----Original Message-----
> From: mans0n [mailto:mans0n@gorani.run]
> Sent: Freitag, 13. März 2020 14:26
> To: Catrinel Catrinescu <cc@80211.de>; Adrian Schmutzler
> <mail@adrianschmutzler.de>; openwrt-devel@lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files
> 
> Hi,
> 
> If we are going to accept this patch, I would suggest "/.config.*"

This would require a separate "/.config" though, wouldn't it?

> instead of
> "/.config*". That would suffice for all local usages.
> 
> Thanks.
> 
> On 2020-03-10 21:33, cc at 80211.de (Catrinel Catrinescu) wrote:
> > Hi Adrian
> >
> > After successful testing, I always save the .config files, attaching the
revision
> number, like .config_r12345.
> >
> > And it is a cosmetic replacement too.
> >
> >
> > Thanks
> > Catrinel
Sungbo Eo March 13, 2020, 2:42 p.m. UTC | #5 
On 2020-03-13 23:30, Adrian Schmutzler wrote:
>> -----Original Message-----
>> From: mans0n [mailto:mans0n@gorani.run]
>> Sent: Freitag, 13. März 2020 14:26
>> To: Catrinel Catrinescu <cc@80211.de>; Adrian Schmutzler
>> <mail@adrianschmutzler.de>; openwrt-devel@lists.openwrt.org
>> Subject: Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files
>>
>> Hi,
>>
>> If we are going to accept this patch, I would suggest "/.config.*"
> 
> This would require a separate "/.config" though, wouldn't it?

Yes, exactly. That is also my intention.

> 
>> instead of
>> "/.config*". That would suffice for all local usages.
>>
>> Thanks.
>>
>> On 2020-03-10 21:33, cc at 80211.de (Catrinel Catrinescu) wrote:
>>> Hi Adrian
>>>
>>> After successful testing, I always save the .config files, attaching the
> revision
>> number, like .config_r12345.
>>>
>>> And it is a cosmetic replacement too.
>>>
>>>
>>> Thanks
>>> Catrinel
>
Adrian Schmutzler July 11, 2020, 11:23 p.m. UTC | #6 
Hi,

since nobody else took care so far:

In my opinion, this does not solve a problem with OpenWrt, but with your particular use case.

However, we cannot cover each individual use case in our default settings.
Despite, it would be relatively easy to either keep that change locally or just not add the relevant files when doing a commit.

(Personally, I have 10+ files in my OpenWrt root I just never touch when working with git.)

So, I'm marking this a Rejected.

I hope you don't feel repelled and continue to contribute to the project.

Best

Adrian

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Catrinel Catrinescu
> Sent: Dienstag, 10. März 2020 13:33
> To: Adrian Schmutzler <mail@adrianschmutzler.de>; openwrt-
> devel@lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files
> 
> Hi Adrian
> 
> After successful testing, I always save the .config files, attaching the revision
> number, like .config_r12345.
> 
> And it is a cosmetic replacement too.
> 
> 
> Thanks
> Catrinel
> 
> 
> -----Original Message-----
> From: Adrian Schmutzler <mail@adrianschmutzler.de>
> Sent: Tuesday, 10 March 2020 13:26
> To: Catrinel Catrinescu <cc@80211.de>; openwrt-devel@lists.openwrt.org
> Subject: RE: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files
> 
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> > On Behalf Of cc@80211.de
> > Sent: Dienstag, 10. März 2020 13:02
> > To: openwrt-devel@lists.openwrt.org
> > Cc: Catrinel Catrinescu <cc@80211.de>
> > Subject: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files
> 
> Why is this necessary (-> commit message)?
> 
> Or is it just a cosmetic replacement of two lines by one? (In that case, I'd
> prefer the specific lines).
> 
> Best
> 
> Adrian
> 
> >
> > From: Catrinel Catrinescu <cc@80211.de>
> >
> > Signed-off-by: Catrinel Catrinescu <cc@80211.de>
> > ---
> >  .gitignore | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 6549af83be..edffba9c05 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -3,8 +3,7 @@
> >  .*.swp
> >  /env
> >  /dl
> > -/.config
> > -/.config.old
> > +/.config*
> >  /bin
> >  /build_dir
> >  /staging_dir
> > --
> > 2.17.1
> >
> >
> > _______________________________________________
> > openwrt-devel mailing list
> > openwrt-devel@lists.openwrt.org
> > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index 6549af83be..edffba9c05 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,8 +3,7 @@ 
 .*.swp
 /env
 /dl
-/.config
-/.config.old
+/.config*
 /bin
 /build_dir
 /staging_dir