| Message ID | 20200214144627.25815-2-ldevulder@suse.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | Add roc-rk3328-cc support | expand |
Hi Loic, On 2020/2/14 下午10:46, Loic Devulder wrote: > Add missing L2 cache entry in dts to avoid warning during Linux > kernel boot. Does this also appear at kernel dts? If yes, you can say it's sync from kernel and provide the kernel commit number here. Thanks, - Kever > > Signed-off-by: Loic Devulder <ldevulder@suse.com> > --- > arch/arm/dts/rk3328.dtsi | 25 ++++++++++++++++++++++++- > 1 file changed, 24 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/dts/rk3328.dtsi b/arch/arm/dts/rk3328.dtsi > index 060c84e6c0..7334eb124d 100644 > --- a/arch/arm/dts/rk3328.dtsi > +++ b/arch/arm/dts/rk3328.dtsi > @@ -38,7 +38,10 @@ > compatible = "arm,cortex-a53", "arm,armv8"; > reg = <0x0 0x0>; > enable-method = "psci"; > -// clocks = <&cru ARMCLK>; > + clocks = <&cru ARMCLK>; > + #cooling-cells = <2>; > + dynamic-power-coefficient = <120>; > + next-level-cache = <&l2>; > operating-points-v2 = <&cpu0_opp_table>; > }; > cpu1: cpu@1 { > @@ -46,19 +49,39 @@ > compatible = "arm,cortex-a53", "arm,armv8"; > reg = <0x0 0x1>; > enable-method = "psci"; > + clocks = <&cru ARMCLK>; > + #cooling-cells = <2>; > + dynamic-power-coefficient = <120>; > + next-level-cache = <&l2>; > + operating-points-v2 = <&cpu0_opp_table>; > }; > cpu2: cpu@2 { > device_type = "cpu"; > compatible = "arm,cortex-a53", "arm,armv8"; > reg = <0x0 0x2>; > enable-method = "psci"; > + clocks = <&cru ARMCLK>; > + #cooling-cells = <2>; > + dynamic-power-coefficient = <120>; > + next-level-cache = <&l2>; > + operating-points-v2 = <&cpu0_opp_table>; > }; > cpu3: cpu@3 { > device_type = "cpu"; > compatible = "arm,cortex-a53", "arm,armv8"; > reg = <0x0 0x3>; > enable-method = "psci"; > + clocks = <&cru ARMCLK>; > + #cooling-cells = <2>; > + dynamic-power-coefficient = <120>; > + next-level-cache = <&l2>; > + operating-points-v2 = <&cpu0_opp_table>; > }; > + > + l2: l2-cache0 { > + compatible = "cache"; > + }; > + > }; > > cpu0_opp_table: opp_table0 {
HI Loic, On 2020/3/3 上午1:39, Loic Devulder wrote: > Hi Kever, > > Sorry for the late reply... > > On Wed, 2020-02-19 at 16:40 +0800, Kever Yang wrote: >> Hi Loic, >> >> >> On 2020/2/14 下午10:46, Loic Devulder wrote: >>> Add missing L2 cache entry in dts to avoid warning during Linux >>> kernel boot. >> Does this also appear at kernel dts? If yes, you can say it's sync > Yes and it's in the kernel dts since the beginning: > https://github.com/torvalds/linux/commit/52e02d377a7282ae57052c222cdaacf45ddc4c5d#diff-49b6fb4fdb583aa27697c299d5e902e2 > >> from >> kernel and provide >> >> the kernel commit number here. > I will do it, sure. > > The main "issue" here is that dts are very differents from the ones in > kernel tree. I begin to try to use it for rk3328-roc-cc board but there > is some issues, at least in USB and ethernet. More work is needed here. > I plan to try to do some when I will have some free time (I'm not a U- > Boot dev daily, only one free time, but like some others here :-)). I have receive you previous mail. You can port the dts nodes you need first instead of port the full dtsi if too much related driver need to sync before it can work. Thanks, - Kever > >> >> Thanks, >> >> - Kever >> >>> Signed-off-by: Loic Devulder <ldevulder@suse.com> >>> --- >>> arch/arm/dts/rk3328.dtsi | 25 ++++++++++++++++++++++++- >>> 1 file changed, 24 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/dts/rk3328.dtsi b/arch/arm/dts/rk3328.dtsi >>> index 060c84e6c0..7334eb124d 100644 >>> --- a/arch/arm/dts/rk3328.dtsi >>> +++ b/arch/arm/dts/rk3328.dtsi >>> @@ -38,7 +38,10 @@ >>> compatible = "arm,cortex-a53", "arm,armv8"; >>> reg = <0x0 0x0>; >>> enable-method = "psci"; >>> -// clocks = <&cru ARMCLK>; >>> + clocks = <&cru ARMCLK>; >>> + #cooling-cells = <2>; >>> + dynamic-power-coefficient = <120>; >>> + next-level-cache = <&l2>; >>> operating-points-v2 = <&cpu0_opp_table>; >>> }; >>> cpu1: cpu@1 { >>> @@ -46,19 +49,39 @@ >>> compatible = "arm,cortex-a53", "arm,armv8"; >>> reg = <0x0 0x1>; >>> enable-method = "psci"; >>> + clocks = <&cru ARMCLK>; >>> + #cooling-cells = <2>; >>> + dynamic-power-coefficient = <120>; >>> + next-level-cache = <&l2>; >>> + operating-points-v2 = <&cpu0_opp_table>; >>> }; >>> cpu2: cpu@2 { >>> device_type = "cpu"; >>> compatible = "arm,cortex-a53", "arm,armv8"; >>> reg = <0x0 0x2>; >>> enable-method = "psci"; >>> + clocks = <&cru ARMCLK>; >>> + #cooling-cells = <2>; >>> + dynamic-power-coefficient = <120>; >>> + next-level-cache = <&l2>; >>> + operating-points-v2 = <&cpu0_opp_table>; >>> }; >>> cpu3: cpu@3 { >>> device_type = "cpu"; >>> compatible = "arm,cortex-a53", "arm,armv8"; >>> reg = <0x0 0x3>; >>> enable-method = "psci"; >>> + clocks = <&cru ARMCLK>; >>> + #cooling-cells = <2>; >>> + dynamic-power-coefficient = <120>; >>> + next-level-cache = <&l2>; >>> + operating-points-v2 = <&cpu0_opp_table>; >>> }; >>> + >>> + l2: l2-cache0 { >>> + compatible = "cache"; >>> + }; >>> + >>> }; >>> >>> cpu0_opp_table: opp_table0 { >>
diff --git a/arch/arm/dts/rk3328.dtsi b/arch/arm/dts/rk3328.dtsi index 060c84e6c0..7334eb124d 100644 --- a/arch/arm/dts/rk3328.dtsi +++ b/arch/arm/dts/rk3328.dtsi @@ -38,7 +38,10 @@ compatible = "arm,cortex-a53", "arm,armv8"; reg = <0x0 0x0>; enable-method = "psci"; -// clocks = <&cru ARMCLK>; + clocks = <&cru ARMCLK>; + #cooling-cells = <2>; + dynamic-power-coefficient = <120>; + next-level-cache = <&l2>; operating-points-v2 = <&cpu0_opp_table>; }; cpu1: cpu@1 { @@ -46,19 +49,39 @@ compatible = "arm,cortex-a53", "arm,armv8"; reg = <0x0 0x1>; enable-method = "psci"; + clocks = <&cru ARMCLK>; + #cooling-cells = <2>; + dynamic-power-coefficient = <120>; + next-level-cache = <&l2>; + operating-points-v2 = <&cpu0_opp_table>; }; cpu2: cpu@2 { device_type = "cpu"; compatible = "arm,cortex-a53", "arm,armv8"; reg = <0x0 0x2>; enable-method = "psci"; + clocks = <&cru ARMCLK>; + #cooling-cells = <2>; + dynamic-power-coefficient = <120>; + next-level-cache = <&l2>; + operating-points-v2 = <&cpu0_opp_table>; }; cpu3: cpu@3 { device_type = "cpu"; compatible = "arm,cortex-a53", "arm,armv8"; reg = <0x0 0x3>; enable-method = "psci"; + clocks = <&cru ARMCLK>; + #cooling-cells = <2>; + dynamic-power-coefficient = <120>; + next-level-cache = <&l2>; + operating-points-v2 = <&cpu0_opp_table>; }; + + l2: l2-cache0 { + compatible = "cache"; + }; + }; cpu0_opp_table: opp_table0 {
Add missing L2 cache entry in dts to avoid warning during Linux kernel boot. Signed-off-by: Loic Devulder <ldevulder@suse.com> --- arch/arm/dts/rk3328.dtsi | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-)