| Message ID | 20200226130345.209469-18-jolsa@kernel.org |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | bpf: Add trampoline and dispatcher to /proc/kallsyms | expand |
On Wed, Feb 26, 2020 at 5:06 AM Jiri Olsa <jolsa@kernel.org> wrote: > > There's no special load action for ksymbol data on > map__load/dso__load action, where the kernel is getting > loaded. It only gets confused with kernel kallsyms/vmlinux > load for bpf object, which fails and could mess up with > the map. > > Disabling any further load of the map for ksymbol related dso/map. > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> Acked-by: Song Liu <songliubraving@fb.com>
Em Wed, Feb 26, 2020 at 02:03:44PM +0100, Jiri Olsa escreveu: > There's no special load action for ksymbol data on > map__load/dso__load action, where the kernel is getting > loaded. It only gets confused with kernel kallsyms/vmlinux > load for bpf object, which fails and could mess up with > the map. > > Disabling any further load of the map for ksymbol related dso/map. Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > --- > tools/perf/util/machine.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index fb5c2cd44d30..463ada5117f8 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -742,6 +742,7 @@ static int machine__process_ksymbol_register(struct machine *machine, > map->start = event->ksymbol.addr; > map->end = map->start + event->ksymbol.len; > maps__insert(&machine->kmaps, map); > + dso__set_loaded(dso); > } > > sym = symbol__new(map->map_ip(map, map->start), > -- > 2.24.1
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index fb5c2cd44d30..463ada5117f8 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -742,6 +742,7 @@ static int machine__process_ksymbol_register(struct machine *machine, map->start = event->ksymbol.addr; map->end = map->start + event->ksymbol.len; maps__insert(&machine->kmaps, map); + dso__set_loaded(dso); } sym = symbol__new(map->map_ip(map, map->start),
There's no special load action for ksymbol data on map__load/dso__load action, where the kernel is getting loaded. It only gets confused with kernel kallsyms/vmlinux load for bpf object, which fails and could mess up with the map. Disabling any further load of the map for ksymbol related dso/map. Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- tools/perf/util/machine.c | 1 + 1 file changed, 1 insertion(+)