| Message ID | 20200120212009.32569366@kosmio.komorska |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ath79: update device naming for Netgear WNDR3700v2 | expand |
Hi, I've just merged 1/2, but when looking at this patch I found that u-boot-env partition is read-only for both v1/v2? Best Adrian > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] On > Behalf Of Michal Cieslakiewicz > Sent: Montag, 20. Januar 2020 21:20 > To: openwrt-devel@lists.openwrt.org > Cc: Adrian Schmutzler <mail@adrianschmutzler.de> > Subject: [OpenWrt-Devel] [PATCH v2 2/2] ath79: uboot-envtools: add Netgear > WNDR3700v2 > > Add Netgear WNDR3700v2 to the list of supported boards. > > Signed-off-by: Michal Cieslakiewicz <michal.cieslakiewicz@wp.pl> > --- > package/boot/uboot-envtools/files/ath79 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/boot/uboot-envtools/files/ath79 b/package/boot/uboot- > envtools/files/ath79 > index aafced98db..66f7dc6a64 100644 > --- a/package/boot/uboot-envtools/files/ath79 > +++ b/package/boot/uboot-envtools/files/ath79 > @@ -44,7 +44,8 @@ yuncore,xd4200) > buffalo,wzr-hp-ag300h) > ubootenv_add_uci_config "/dev/mtd3" "0x0" "0x10000" "0x10000" > ;; > -netgear,wndr3700) > +netgear,wndr3700|\ > +netgear,wndr3700-v2) > ubootenv_add_uci_config "/dev/mtd1" "0x0" "0x20000" "0x10000" > ;; > netgear,wndr3700-v4|\ > -- > 2.25.0 > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
On Mon, 3 Feb 2020 11:33:08 +0100 "Adrian Schmutzler" <mail@adrianschmutzler.de> wrote: > Hi, > > I've just merged 1/2, but when looking at this patch I found that > u-boot-env partition is read-only for both v1/v2? > > Best > > Adrian > Hi Adrian, Thanks for spotting that, didn't noticed that env is marked as read-only it dts. But maybe it will be better to issue a separate patch to make uboot-env for both 3700v1 and v2 writable? 3700v1 is write-protected despite being already recognized by uboot-envtools... Regards Michal
> -----Original Message----- > From: Michal Cieslakiewicz [mailto:michal.cieslakiewicz@wp.pl] > Sent: Montag, 3. Februar 2020 18:04 > To: Adrian Schmutzler <mail@adrianschmutzler.de> > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH v2 2/2] ath79: uboot-envtools: add > Netgear WNDR3700v2 > > On Mon, 3 Feb 2020 11:33:08 +0100 > "Adrian Schmutzler" <mail@adrianschmutzler.de> wrote: > > > Hi, > > > > I've just merged 1/2, but when looking at this patch I found that > > u-boot-env partition is read-only for both v1/v2? > > > > Best > > > > Adrian > > > > Hi Adrian, > > Thanks for spotting that, didn't noticed that env is marked as > read-only it dts. > But maybe it will be better to issue a separate patch to make uboot-env > for both 3700v1 and v2 writable? 3700v1 is write-protected despite > being already recognized by uboot-envtools... Yes, please do it separately (since uboot-envtools is a separate package anyway). I'd merge the DTS patch before the uboot-envtools patch then. Best Adrian > > Regards > Michal
diff --git a/package/boot/uboot-envtools/files/ath79 b/package/boot/uboot-envtools/files/ath79 index aafced98db..66f7dc6a64 100644 --- a/package/boot/uboot-envtools/files/ath79 +++ b/package/boot/uboot-envtools/files/ath79 @@ -44,7 +44,8 @@ yuncore,xd4200) buffalo,wzr-hp-ag300h) ubootenv_add_uci_config "/dev/mtd3" "0x0" "0x10000" "0x10000" ;; -netgear,wndr3700) +netgear,wndr3700|\ +netgear,wndr3700-v2) ubootenv_add_uci_config "/dev/mtd1" "0x0" "0x20000" "0x10000" ;; netgear,wndr3700-v4|\
Add Netgear WNDR3700v2 to the list of supported boards. Signed-off-by: Michal Cieslakiewicz <michal.cieslakiewicz@wp.pl> --- package/boot/uboot-envtools/files/ath79 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)