| Message ID | d7cefc0d-0574-82d4-3717-20fae3cdbd78@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [1/4] wdt: Add CONFIG_DESIGNWARE_WATCHDOG to Kconfig | expand |
On 2/2/20 12:12 PM, Sean Anderson wrote: > This header is needed outside of the arm architecture by the designware wdt > driver. > --- > arch/arm/cpu/armv7/cache_v7.c | 2 +- > arch/arm/mach-davinci/spl.c | 2 +- > arch/arm/mach-omap2/clocks-common.c | 2 +- > arch/arm/mach-omap2/emif-common.c | 2 +- > arch/arm/mach-omap2/omap4/emif.c | 2 +- > arch/arm/mach-omap2/omap5/dra7xx_iodelay.c | 2 +- > arch/arm/mach-omap2/omap5/emif.c | 2 +- > arch/arm/mach-omap2/omap5/hwinit.c | 2 +- > arch/arm/mach-socfpga/spl_a10.c | 2 +- > arch/arm/mach-socfpga/spl_agilex.c | 2 +- > arch/arm/mach-socfpga/spl_gen5.c | 2 +- > arch/arm/mach-socfpga/spl_s10.c | 2 +- > drivers/watchdog/designware_wdt.c | 4 ++-- > arch/arm/include/asm/utils.h => include/log2.h | 4 ++-- > 14 files changed, 16 insertions(+), 16 deletions(-) > rename arch/arm/include/asm/utils.h => include/log2.h (93%) Signed-off-by: Sean Anderson <seanga2@gmail.com>
On Sun, 2 Feb 2020 at 10:12, Sean Anderson <seanga2@gmail.com> wrote: > > This header is needed outside of the arm architecture by the designware wdt > driver. > --- > arch/arm/cpu/armv7/cache_v7.c | 2 +- > arch/arm/mach-davinci/spl.c | 2 +- > arch/arm/mach-omap2/clocks-common.c | 2 +- > arch/arm/mach-omap2/emif-common.c | 2 +- > arch/arm/mach-omap2/omap4/emif.c | 2 +- > arch/arm/mach-omap2/omap5/dra7xx_iodelay.c | 2 +- > arch/arm/mach-omap2/omap5/emif.c | 2 +- > arch/arm/mach-omap2/omap5/hwinit.c | 2 +- > arch/arm/mach-socfpga/spl_a10.c | 2 +- > arch/arm/mach-socfpga/spl_agilex.c | 2 +- > arch/arm/mach-socfpga/spl_gen5.c | 2 +- > arch/arm/mach-socfpga/spl_s10.c | 2 +- > drivers/watchdog/designware_wdt.c | 4 ++-- > arch/arm/include/asm/utils.h => include/log2.h | 4 ++-- > 14 files changed, 16 insertions(+), 16 deletions(-) > rename arch/arm/include/asm/utils.h => include/log2.h (93%) Reviewed-by: Simon Glass <sjg@chromium.org>
On 2/3/20 1:04 AM, Simon Glass wrote: > On Sun, 2 Feb 2020 at 10:12, Sean Anderson <seanga2@gmail.com> wrote: >> >> This header is needed outside of the arm architecture by the designware wdt >> driver. >> --- >> arch/arm/cpu/armv7/cache_v7.c | 2 +- >> arch/arm/mach-davinci/spl.c | 2 +- >> arch/arm/mach-omap2/clocks-common.c | 2 +- >> arch/arm/mach-omap2/emif-common.c | 2 +- >> arch/arm/mach-omap2/omap4/emif.c | 2 +- >> arch/arm/mach-omap2/omap5/dra7xx_iodelay.c | 2 +- >> arch/arm/mach-omap2/omap5/emif.c | 2 +- >> arch/arm/mach-omap2/omap5/hwinit.c | 2 +- >> arch/arm/mach-socfpga/spl_a10.c | 2 +- >> arch/arm/mach-socfpga/spl_agilex.c | 2 +- >> arch/arm/mach-socfpga/spl_gen5.c | 2 +- >> arch/arm/mach-socfpga/spl_s10.c | 2 +- >> drivers/watchdog/designware_wdt.c | 4 ++-- >> arch/arm/include/asm/utils.h => include/log2.h | 4 ++-- >> 14 files changed, 16 insertions(+), 16 deletions(-) >> rename arch/arm/include/asm/utils.h => include/log2.h (93%) > > Reviewed-by: Simon Glass <sjg@chromium.org> How could this be reviewed if it's missing basic things, like a SoB line ?
Hi Marek, On Mon, 3 Feb 2020 at 01:28, Marek Vasut <marex@denx.de> wrote: > > On 2/3/20 1:04 AM, Simon Glass wrote: > > On Sun, 2 Feb 2020 at 10:12, Sean Anderson <seanga2@gmail.com> wrote: > >> > >> This header is needed outside of the arm architecture by the designware wdt > >> driver. > >> --- > >> arch/arm/cpu/armv7/cache_v7.c | 2 +- > >> arch/arm/mach-davinci/spl.c | 2 +- > >> arch/arm/mach-omap2/clocks-common.c | 2 +- > >> arch/arm/mach-omap2/emif-common.c | 2 +- > >> arch/arm/mach-omap2/omap4/emif.c | 2 +- > >> arch/arm/mach-omap2/omap5/dra7xx_iodelay.c | 2 +- > >> arch/arm/mach-omap2/omap5/emif.c | 2 +- > >> arch/arm/mach-omap2/omap5/hwinit.c | 2 +- > >> arch/arm/mach-socfpga/spl_a10.c | 2 +- > >> arch/arm/mach-socfpga/spl_agilex.c | 2 +- > >> arch/arm/mach-socfpga/spl_gen5.c | 2 +- > >> arch/arm/mach-socfpga/spl_s10.c | 2 +- > >> drivers/watchdog/designware_wdt.c | 4 ++-- > >> arch/arm/include/asm/utils.h => include/log2.h | 4 ++-- > >> 14 files changed, 16 insertions(+), 16 deletions(-) > >> rename arch/arm/include/asm/utils.h => include/log2.h (93%) > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > How could this be reviewed if it's missing basic things, like a SoB line ? I saw you requested that on another patch. Apart from that it looks OK to me. People should use patman :-) Regards, Simon
On 2/3/20 10:11 AM, Simon Glass wrote: > Hi Marek, > > On Mon, 3 Feb 2020 at 01:28, Marek Vasut <marex@denx.de> wrote: >> How could this be reviewed if it's missing basic things, like a SoB line ? I added that in a reply to the original patch; again my apologies for missing it the first time around. > > I saw you requested that on another patch. Apart from that it looks OK to me. > > People should use patman :-) I usually add my signed-off-by lines with git rebase --sign, but I forgot to do that this time. Though reasonably the thing which should have reminded me was running checkpatch (which I also forgot to run). > Regards, > Simon >
Hi Sean, On Mon, 3 Feb 2020 at 08:27, Sean Anderson <seanga2@gmail.com> wrote: > > On 2/3/20 10:11 AM, Simon Glass wrote: > > Hi Marek, > > > > On Mon, 3 Feb 2020 at 01:28, Marek Vasut <marex@denx.de> wrote: > >> How could this be reviewed if it's missing basic things, like a SoB line ? > > I added that in a reply to the original patch; again my apologies for > missing it the first time around. > > > > > I saw you requested that on another patch. Apart from that it looks OK to me. > > > > People should use patman :-) > > I usually add my signed-off-by lines with git rebase --sign, but I > forgot to do that this time. Though reasonably the thing which should > have reminded me was running checkpatch (which I also forgot to run). That's why patman exists, to automate adding sign-off, checkpath, get maintainers, dropping unwanted tags, cover letter, etc. It's so simple to set up. It really doesn't make much sense to send patches manually, IMO. Regards, Simon
diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c index 99eb7db342..049a27cc92 100644 --- a/arch/arm/cpu/armv7/cache_v7.c +++ b/arch/arm/cpu/armv7/cache_v7.c @@ -8,7 +8,7 @@ #include <linux/types.h> #include <common.h> #include <asm/armv7.h> -#include <asm/utils.h> +#include <log2.h> #define ARMV7_DCACHE_INVAL_RANGE 1 #define ARMV7_DCACHE_CLEAN_INVAL_RANGE 2 diff --git a/arch/arm/mach-davinci/spl.c b/arch/arm/mach-davinci/spl.c index be3daa9bc0..821324074c 100644 --- a/arch/arm/mach-davinci/spl.c +++ b/arch/arm/mach-davinci/spl.c @@ -7,7 +7,7 @@ #include <config.h> #include <spl.h> #include <asm/u-boot.h> -#include <asm/utils.h> +#include <log2.h> #include <nand.h> #include <asm/arch/dm365_lowlevel.h> #include <ns16550.h> diff --git a/arch/arm/mach-omap2/clocks-common.c b/arch/arm/mach-omap2/clocks-common.c index 5932d694d3..7b91a39cdb 100644 --- a/arch/arm/mach-omap2/clocks-common.c +++ b/arch/arm/mach-omap2/clocks-common.c @@ -18,7 +18,7 @@ #include <asm/gpio.h> #include <asm/arch/clock.h> #include <asm/arch/sys_proto.h> -#include <asm/utils.h> +#include <log2.h> #include <asm/omap_gpio.h> #include <asm/emif.h> diff --git a/arch/arm/mach-omap2/emif-common.c b/arch/arm/mach-omap2/emif-common.c index 290f9dcdb0..758c2b3d11 100644 --- a/arch/arm/mach-omap2/emif-common.c +++ b/arch/arm/mach-omap2/emif-common.c @@ -14,7 +14,7 @@ #include <asm/arch/sys_proto.h> #include <asm/omap_common.h> #include <asm/omap_sec_common.h> -#include <asm/utils.h> +#include <log2.h> #include <linux/compiler.h> #include <asm/ti-common/ti-edma3.h> diff --git a/arch/arm/mach-omap2/omap4/emif.c b/arch/arm/mach-omap2/omap4/emif.c index 35a51645be..d2b530535e 100644 --- a/arch/arm/mach-omap2/omap4/emif.c +++ b/arch/arm/mach-omap2/omap4/emif.c @@ -11,7 +11,7 @@ #include <common.h> #include <asm/emif.h> #include <asm/arch/sys_proto.h> -#include <asm/utils.h> +#include <log2.h> #ifndef CONFIG_SYS_EMIF_PRECALCULATED_TIMING_REGS u32 *const T_num = (u32 *)OMAP_SRAM_SCRATCH_EMIF_T_NUM; diff --git a/arch/arm/mach-omap2/omap5/dra7xx_iodelay.c b/arch/arm/mach-omap2/omap5/dra7xx_iodelay.c index 9eda57c450..e541e729ef 100644 --- a/arch/arm/mach-omap2/omap5/dra7xx_iodelay.c +++ b/arch/arm/mach-omap2/omap5/dra7xx_iodelay.c @@ -7,7 +7,7 @@ */ #include <common.h> -#include <asm/utils.h> +#include <log2.h> #include <asm/arch/dra7xx_iodelay.h> #include <asm/arch/omap.h> #include <asm/arch/sys_proto.h> diff --git a/arch/arm/mach-omap2/omap5/emif.c b/arch/arm/mach-omap2/omap5/emif.c index f3661a0e74..a5c74261c0 100644 --- a/arch/arm/mach-omap2/omap5/emif.c +++ b/arch/arm/mach-omap2/omap5/emif.c @@ -11,7 +11,7 @@ #include <common.h> #include <asm/emif.h> #include <asm/arch/sys_proto.h> -#include <asm/utils.h> +#include <log2.h> #ifndef CONFIG_SYS_EMIF_PRECALCULATED_TIMING_REGS #define print_timing_reg(reg) debug(#reg" - 0x%08x\n", (reg)) diff --git a/arch/arm/mach-omap2/omap5/hwinit.c b/arch/arm/mach-omap2/omap5/hwinit.c index 56458ce495..ebd3b4903f 100644 --- a/arch/arm/mach-omap2/omap5/hwinit.c +++ b/arch/arm/mach-omap2/omap5/hwinit.c @@ -18,7 +18,7 @@ #include <asm/arch/sys_proto.h> #include <asm/arch/clock.h> #include <linux/sizes.h> -#include <asm/utils.h> +#include <log2.h> #include <asm/arch/gpio.h> #include <asm/emif.h> #include <asm/omap_common.h> diff --git a/arch/arm/mach-socfpga/spl_a10.c b/arch/arm/mach-socfpga/spl_a10.c index 7c38c50981..a2b19e0f47 100644 --- a/arch/arm/mach-socfpga/spl_a10.c +++ b/arch/arm/mach-socfpga/spl_a10.c @@ -8,7 +8,7 @@ #include <asm/io.h> #include <asm/pl310.h> #include <asm/u-boot.h> -#include <asm/utils.h> +#include <log2.h> #include <image.h> #include <asm/arch/reset_manager.h> #include <spl.h> diff --git a/arch/arm/mach-socfpga/spl_agilex.c b/arch/arm/mach-socfpga/spl_agilex.c index c745d64114..4e46d2bf5c 100644 --- a/arch/arm/mach-socfpga/spl_agilex.c +++ b/arch/arm/mach-socfpga/spl_agilex.c @@ -6,7 +6,7 @@ #include <asm/io.h> #include <asm/u-boot.h> -#include <asm/utils.h> +#include <log2.h> #include <common.h> #include <image.h> #include <spl.h> diff --git a/arch/arm/mach-socfpga/spl_gen5.c b/arch/arm/mach-socfpga/spl_gen5.c index e19f55aa9b..48de2aceee 100644 --- a/arch/arm/mach-socfpga/spl_gen5.c +++ b/arch/arm/mach-socfpga/spl_gen5.c @@ -6,7 +6,7 @@ #include <common.h> #include <asm/io.h> #include <asm/u-boot.h> -#include <asm/utils.h> +#include <log2.h> #include <image.h> #include <asm/arch/reset_manager.h> #include <spl.h> diff --git a/arch/arm/mach-socfpga/spl_s10.c b/arch/arm/mach-socfpga/spl_s10.c index 8d96918cb4..44063b332a 100644 --- a/arch/arm/mach-socfpga/spl_s10.c +++ b/arch/arm/mach-socfpga/spl_s10.c @@ -6,7 +6,7 @@ #include <asm/io.h> #include <asm/u-boot.h> -#include <asm/utils.h> +#include <log2.h> #include <common.h> #include <debug_uart.h> #include <image.h> diff --git a/drivers/watchdog/designware_wdt.c b/drivers/watchdog/designware_wdt.c index c668567c66..3b97db1256 100644 --- a/drivers/watchdog/designware_wdt.c +++ b/drivers/watchdog/designware_wdt.c @@ -4,9 +4,9 @@ */ #include <common.h> -#include <watchdog.h> #include <asm/io.h> -#include <asm/utils.h> +#include <log2.h> +#include <watchdog.h> #define DW_WDT_CR 0x00 #define DW_WDT_TORR 0x04 diff --git a/arch/arm/include/asm/utils.h b/include/log2.h similarity index 93% rename from arch/arm/include/asm/utils.h rename to include/log2.h index eee60c50e9..4f89d3dd76 100644 --- a/arch/arm/include/asm/utils.h +++ b/include/log2.h @@ -4,8 +4,8 @@ * Texas Instruments, <www.ti.com> * Aneesh V <aneesh@ti.com> */ -#ifndef _UTILS_H_ -#define _UTILS_H_ +#ifndef _LOG2_H_ +#define _LOG2_H_ static inline s32 log_2_n_round_up(u32 n) {