| Message ID | 20191029112700.14548-9-srinivas.kandagatla@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: Add support to WCD9340/WCD9341 codec | expand |
On Tue, Oct 29, 2019 at 12:29 PM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated > gpio controller to control 5 gpios on the chip. This patch adds > required device tree bindings for it. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../pinctrl/qcom,wcd934x-pinctrl.yaml | 52 +++++++++++++++++++ The bindings look OK, but remind me if I have asked before (sorry then) does these GPIOs expose some pin control properties and that is why the driver is placed under pin control rather than the GPIO namespace? Sorry if this is something I asked before, I just get too much mail. Yours, Linus Walleij
Thanks for reviewing this! On 03/11/2019 23:19, Linus Walleij wrote: > On Tue, Oct 29, 2019 at 12:29 PM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > >> Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated >> gpio controller to control 5 gpios on the chip. This patch adds >> required device tree bindings for it. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> .../pinctrl/qcom,wcd934x-pinctrl.yaml | 52 +++++++++++++++++++ > > The bindings look OK, but remind me if I have asked before (sorry then) > does these GPIOs expose some pin control properties and that is why > the driver is placed under pin control rather than the GPIO namespace? > I don't remember you asking about this before :-), This controller just has Output enable bits, No pin control properties. As you suggested I can move this to drivers/gpio in next version. Thanks, srini
On Mon, Nov 4, 2019 at 10:35 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > This controller just has Output enable bits, No pin control properties. > > As you suggested I can move this to drivers/gpio in next version. OK perfect, thanks! NB: this probably also affects the compatible-string which contains "pinctrl*" right? Yours, Linus Walleij
On 05/11/2019 13:25, Linus Walleij wrote: > On Mon, Nov 4, 2019 at 10:35 AM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > >> This controller just has Output enable bits, No pin control properties. >> >> As you suggested I can move this to drivers/gpio in next version. > OK perfect, thanks! > > NB: this probably also affects the compatible-string which contains > "pinctrl*" right? Yes, I will suffix it with "-gpio" instead. thanks, srini
On Tue, Nov 05, 2019 at 01:27:45PM +0000, Srinivas Kandagatla wrote: > > > On 05/11/2019 13:25, Linus Walleij wrote: > > On Mon, Nov 4, 2019 at 10:35 AM Srinivas Kandagatla > > <srinivas.kandagatla@linaro.org> wrote: > > > > > This controller just has Output enable bits, No pin control properties. > > > > > > As you suggested I can move this to drivers/gpio in next version. > > OK perfect, thanks! > > > > NB: this probably also affects the compatible-string which contains > > "pinctrl*" right? > Yes, I will suffix it with "-gpio" instead. Not a discussion we should be having because you should name this after what's in the chip documentation not the OS subsystem it happens to land in. Rob
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,wcd934x-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,wcd934x-pinctrl.yaml new file mode 100644 index 000000000000..432486d753b3 --- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/qcom,wcd934x-pinctrl.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/qcom,wcd934x-pinctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: WCD9340/WCD9341 GPIO Pin controller + +maintainers: + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> + +description: | + Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated + gpio controller to control 5 gpios on the chip. + +properties: + compatible: + enum: + - qcom,wcd9340-pinctrl + - qcom,wcd9341-pinctrl + + reg: + maxItems: 1 + + gpio-controller: true + + gpio-ranges: + maxItems: 1 + + '#gpio-cells': + const: 2 + +required: + - compatible + - reg + - gpio-controller + - gpio-ranges + - "#gpio-cells" + +additionalProperties: false + +examples: + - | + wcdpinctrl: pinctrl@42 { + compatible = "qcom,wcd9340-pinctrl"; + reg = <0x042 0x2>; + gpio-controller; + gpio-ranges = <&wcdpinctrl 0 0 5>; + #gpio-cells = <2>; + }; + +...
Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated gpio controller to control 5 gpios on the chip. This patch adds required device tree bindings for it. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- .../pinctrl/qcom,wcd934x-pinctrl.yaml | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,wcd934x-pinctrl.yaml