diff mbox series

[v2,3/3] dt-bindings: display: panel: add bindings for logic technologies displays

Message ID 20191027142609.12754-3-marcel@ziswiler.com
State Not Applicable, archived
Headers show
Series [v2,1/3] dt-bindings: add vendor prefix for logic technologies limited | expand

Checks

Context Check Description
robh/checkpatch warning "total: 0 errors, 1 warnings, 132 lines checked"
robh/dt-meta-schema fail build log

Commit Message

Marcel Ziswiler Oct. 27, 2019, 2:26 p.m. UTC 
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Add bindings for the following 3 previously added display panels
manufactured by Logic Technologies Limited:

- LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
7" Parallel [1]
- LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
Parallel [2]
- LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
10.1" LVDS [3]

Those panels may also be distributed by Endrich Bauelemente Vertriebs
GmbH [4].

[1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
[2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
[3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
[4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

Changes in v2:
- New patch adding display panel bindings as well as suggested by Rob.

 .../panel/logictechno,lt161010-2nhc.yaml      | 44 +++++++++++++++++++
 .../panel/logictechno,lt161010-2nhr.yaml      | 44 +++++++++++++++++++
 .../panel/logictechno,lt170410-2whc.yaml      | 44 +++++++++++++++++++
 3 files changed, 132 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
 create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml

Comments

Rob Herring (Arm) Oct. 30, 2019, 2:28 p.m. UTC | #1 
On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Add bindings for the following 3 previously added display panels
> manufactured by Logic Technologies Limited:
> 
> - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
> 7" Parallel [1]
> - LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
> Parallel [2]
> - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
> 10.1" LVDS [3]
> 
> Those panels may also be distributed by Endrich Bauelemente Vertriebs
> GmbH [4].
> 
> [1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> [2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> [3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> ---
> 
> Changes in v2:
> - New patch adding display panel bindings as well as suggested by Rob.
> 
>  .../panel/logictechno,lt161010-2nhc.yaml      | 44 +++++++++++++++++++
>  .../panel/logictechno,lt161010-2nhr.yaml      | 44 +++++++++++++++++++
>  .../panel/logictechno,lt170410-2whc.yaml      | 44 +++++++++++++++++++
>  3 files changed, 132 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
>  create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
>  create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml

I would just put these into 1 document as the compatible is the only 
difference. Either way:

Reviewed-by: Rob Herring <robh@kernel.org>

Rob
Rob Herring (Arm) Oct. 30, 2019, 2:29 p.m. UTC | #2 
On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Add bindings for the following 3 previously added display panels
> manufactured by Logic Technologies Limited:
> 
> - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display
> 7" Parallel [1]
> - LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7"
> Parallel [2]
> - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch Display
> 10.1" LVDS [3]
> 
> Those panels may also be distributed by Endrich Bauelemente Vertriebs
> GmbH [4].
> 
> [1] https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> [2] https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> [3] https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> ---
> 
> Changes in v2:
> - New patch adding display panel bindings as well as suggested by Rob.
> 
>  .../panel/logictechno,lt161010-2nhc.yaml      | 44 +++++++++++++++++++
>  .../panel/logictechno,lt161010-2nhr.yaml      | 44 +++++++++++++++++++
>  .../panel/logictechno,lt170410-2whc.yaml      | 44 +++++++++++++++++++
>  3 files changed, 132 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
>  create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
>  create mode 100644 Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> new file mode 100644
> index 000000000000..0dfe94d38a47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0

Except the license for new bindings should be: 

(GPL-2.0-only OR BSD-2-Clause)

Rob
Marcel Ziswiler Jan. 19, 2020, 9:25 p.m. UTC | #3 
Sorry, just noticed that this has not gone through yet.

On Wed, 2019-10-30 at 09:28 -0500, Rob Herring wrote:
> On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > Add bindings for the following 3 previously added display panels
> > manufactured by Logic Technologies Limited:
> > 
> > - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch
> > Display
> > 7" Parallel [1]
> > - LT161010-2NHR e.g. as found in the Toradex Resistive Touch
> > Display 7"
> > Parallel [2]
> > - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch
> > Display
> > 10.1" LVDS [3]
> > 
> > Those panels may also be distributed by Endrich Bauelemente
> > Vertriebs
> > GmbH [4].
> > 
> > [1] 
> > https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> > [2] 
> > https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> > [3] 
> > https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> > [4] 
> > https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > ---
> > 
> > Changes in v2:
> > - New patch adding display panel bindings as well as suggested by
> > Rob.
> > 
> >  .../panel/logictechno,lt161010-2nhc.yaml      | 44
> > +++++++++++++++++++
> >  .../panel/logictechno,lt161010-2nhr.yaml      | 44
> > +++++++++++++++++++
> >  .../panel/logictechno,lt170410-2whc.yaml      | 44
> > +++++++++++++++++++
> >  3 files changed, 132 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > 0-2nhc.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > 0-2nhr.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt17041
> > 0-2whc.yaml
> 
> I would just put these into 1 document as the compatible is the only 
> difference.

No, not quite just the compatible are different as the first and last
panel feature capacitive touch while the middle one is resistive and
the first two panels are parallel RGB ones while the last one is an
LVDS panel.

> Either way:
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Rob
Marcel Ziswiler Jan. 19, 2020, 9:27 p.m. UTC | #4 
On Wed, 2019-10-30 at 09:29 -0500, Rob Herring wrote:
> On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > Add bindings for the following 3 previously added display panels
> > manufactured by Logic Technologies Limited:
> > 
> > - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch
> > Display
> > 7" Parallel [1]
> > - LT161010-2NHR e.g. as found in the Toradex Resistive Touch
> > Display 7"
> > Parallel [2]
> > - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch
> > Display
> > 10.1" LVDS [3]
> > 
> > Those panels may also be distributed by Endrich Bauelemente
> > Vertriebs
> > GmbH [4].
> > 
> > [1] 
> > https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> > [2] 
> > https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> > [3] 
> > https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> > [4] 
> > https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > ---
> > 
> > Changes in v2:
> > - New patch adding display panel bindings as well as suggested by
> > Rob.
> > 
> >  .../panel/logictechno,lt161010-2nhc.yaml      | 44
> > +++++++++++++++++++
> >  .../panel/logictechno,lt161010-2nhr.yaml      | 44
> > +++++++++++++++++++
> >  .../panel/logictechno,lt170410-2whc.yaml      | 44
> > +++++++++++++++++++
> >  3 files changed, 132 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > 0-2nhc.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > 0-2nhr.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/logictechno,lt17041
> > 0-2whc.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/logictechno,lt161
> > 010-2nhc.yaml
> > b/Documentation/devicetree/bindings/display/panel/logictechno,lt161
> > 010-2nhc.yaml
> > new file mode 100644
> > index 000000000000..0dfe94d38a47
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/panel/logictechno,lt161
> > 010-2nhc.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: GPL-2.0
> 
> Except the license for new bindings should be: 
> 
> (GPL-2.0-only OR BSD-2-Clause)

OK, will send a v3 shortly.

> Rob
Sam Ravnborg Jan. 19, 2020, 9:38 p.m. UTC | #5 
Hi Marcel.

On Sun, Jan 19, 2020 at 09:25:02PM +0000, Marcel Ziswiler wrote:
> Sorry, just noticed that this has not gone through yet.
> 
> On Wed, 2019-10-30 at 09:28 -0500, Rob Herring wrote:
> > On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote:
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > 
> > > Add bindings for the following 3 previously added display panels
> > > manufactured by Logic Technologies Limited:
> > > 
> > > - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch
> > > Display
> > > 7" Parallel [1]
> > > - LT161010-2NHR e.g. as found in the Toradex Resistive Touch
> > > Display 7"
> > > Parallel [2]
> > > - LT170410-2WHC e.g. as found in the Toradex Capacitive Touch
> > > Display
> > > 10.1" LVDS [3]
> > > 
> > > Those panels may also be distributed by Endrich Bauelemente
> > > Vertriebs
> > > GmbH [4].
> > > 
> > > [1] 
> > > https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf
> > > [2] 
> > > https://docs.toradex.com/104498-7-inch-parallel-resistive-touch-display-800x480.pdf
> > > [3] 
> > > https://docs.toradex.com/105952-10-1-inch-lvds-capacitive-touch-display-1280x800-datasheet.pdf
> > > [4] 
> > > https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30
> > > 
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > 
> > > ---
> > > 
> > > Changes in v2:
> > > - New patch adding display panel bindings as well as suggested by
> > > Rob.
> > > 
> > >  .../panel/logictechno,lt161010-2nhc.yaml      | 44
> > > +++++++++++++++++++
> > >  .../panel/logictechno,lt161010-2nhr.yaml      | 44
> > > +++++++++++++++++++
> > >  .../panel/logictechno,lt170410-2whc.yaml      | 44
> > > +++++++++++++++++++
> > >  3 files changed, 132 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > > 0-2nhc.yaml
> > >  create mode 100644
> > > Documentation/devicetree/bindings/display/panel/logictechno,lt16101
> > > 0-2nhr.yaml
> > >  create mode 100644
> > > Documentation/devicetree/bindings/display/panel/logictechno,lt17041
> > > 0-2whc.yaml
> > 
> > I would just put these into 1 document as the compatible is the only 
> > difference.
> 
> No, not quite just the compatible are different as the first and last
> panel feature capacitive touch while the middle one is resistive and
> the first two panels are parallel RGB ones while the last one is an
> LVDS panel.

We have recently introduced panel-simple.yaml.
This is for dumb panels - where some of your panels could be candidates.
Please see the file in drm-misc-next, which is also where we will apply
you patch in the end.
So base the patch on drm-misc-next so we do not get conflicts when applying.

	Sam
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
new file mode 100644
index 000000000000..0dfe94d38a47
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhc.yaml
@@ -0,0 +1,44 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/logictechno,lt161010-2nhc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Logic Technologies LT161010-2NHC 7" WVGA TFT Cap Touch Module
+
+maintainers:
+  - Marcel Ziswiler <marcel.ziswiler@toradex.com>
+  - Thierry Reding <treding@nvidia.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: logictechno,lt161010-2nhc
+
+  power-supply: true
+  enable-gpios: true
+  backlight: true
+  port: true
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    panel_rgb: panel {
+      compatible = "logictechno,lt161010-2nhc";
+      backlight = <&backlight>;
+      power-supply = <&reg_3v3>;
+
+      port {
+        panel_in_rgb: endpoint {
+          remote-endpoint = <&controller_out_rgb>;
+        };
+      };
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
new file mode 100644
index 000000000000..ffc97529b068
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt161010-2nhr.yaml
@@ -0,0 +1,44 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/logictechno,lt161010-2nhr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Logic Technologies LT161010-2NHR 7" WVGA TFT Resistive Touch Module
+
+maintainers:
+  - Marcel Ziswiler <marcel.ziswiler@toradex.com>
+  - Thierry Reding <treding@nvidia.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: logictechno,lt161010-2nhr
+
+  power-supply: true
+  enable-gpios: true
+  backlight: true
+  port: true
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    panel_rgb: panel {
+      compatible = "logictechno,lt161010-2nhr";
+      backlight = <&backlight>;
+      power-supply = <&reg_3v3>;
+
+      port {
+        panel_in_rgb: endpoint {
+          remote-endpoint = <&controller_out_rgb>;
+        };
+      };
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml b/Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
new file mode 100644
index 000000000000..3606f7fe0dd0
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/logictechno,lt170410-2whc.yaml
@@ -0,0 +1,44 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/logictechno,lt170410-2whc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Logic Technologies LT170410-2WHC 10.1" 1280x800 IPS TFT Cap Touch Module
+
+maintainers:
+  - Marcel Ziswiler <marcel.ziswiler@toradex.com>
+  - Thierry Reding <treding@nvidia.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: logictechno,lt170410-2whc
+
+  power-supply: true
+  enable-gpios: true
+  backlight: true
+  port: true
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    lvds_panel: panel {
+      compatible = "logictechno,lt170410-2whc";
+      backlight = <&backlight>;
+      power-supply = <&reg_3v3>;
+
+      port {
+        panel_in_lvds: endpoint {
+          remote-endpoint = <&controller_out_lvds>;
+        };
+      };
+    };
+
+...