Message ID | 20191011205825.71888-1-amginwal@gmail.com |
---|---|
State | Superseded |
Headers | show |
Series | [ovs-dev,v1] ovs container build.sh requires python3 | expand |
On Fri, Oct 11, 2019 at 2:07 PM <amginwal@gmail.com> wrote: > > From: Aliasgar Ginwala <aginwala@ebay.com> > > building ovn/ovs container breaks while configure: > checking for Python 3 (version 3.4 or later)... no > configure: error: Python 3.4 or later is required but not found in > /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin, > please install it or set to point to it > > As per commit 1ca0323e7c29dc7ef5a615c265df0460208f92de > Require Python 3 and remove support for Python 2. > > Signed-off-by: Aliasgar Ginwala <aginwala@ebay.com> > --- > utilities/docker/debian/build-kernel-modules.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/utilities/docker/debian/build-kernel-modules.sh b/utilities/docker/debian/build-kernel-modules.sh > index 1b12720b9..18ac35764 100755 > --- a/utilities/docker/debian/build-kernel-modules.sh > +++ b/utilities/docker/debian/build-kernel-modules.sh > @@ -18,8 +18,8 @@ GITHUB_SRC=$3 > > # Install deps > linux="linux-image-$KERNEL_VERSION linux-headers-$KERNEL_VERSION" > -build_deps="apt-utils libelf-dev build-essential libssl-dev python \ > -python-six wget gdb autoconf libtool git automake bzip2 debhelper \ > +build_deps="apt-utils libelf-dev build-essential libssl-dev python3 \ > +python3-six wget gdb autoconf libtool git automake bzip2 debhelper \ > dh-autoreconf openssl" > > apt-get update > -- > 2.20.1 (Apple Git-117) > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Acked-by: hzhou@ovn.org
Hi Ben: Can you also push this to OVS master? Got it merged in ovn repo already. On Fri, Oct 11, 2019 at 2:06 PM <amginwal@gmail.com> wrote: > From: Aliasgar Ginwala <aginwala@ebay.com> > > building ovn/ovs container breaks while configure: > checking for Python 3 (version 3.4 or later)... no > configure: error: Python 3.4 or later is required but not found in > /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin, > please install it or set to point to it > > As per commit 1ca0323e7c29dc7ef5a615c265df0460208f92de > Require Python 3 and remove support for Python 2. > > Signed-off-by: Aliasgar Ginwala <aginwala@ebay.com> > --- > utilities/docker/debian/build-kernel-modules.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/utilities/docker/debian/build-kernel-modules.sh > b/utilities/docker/debian/build-kernel-modules.sh > index 1b12720b9..18ac35764 100755 > --- a/utilities/docker/debian/build-kernel-modules.sh > +++ b/utilities/docker/debian/build-kernel-modules.sh > @@ -18,8 +18,8 @@ GITHUB_SRC=$3 > > # Install deps > linux="linux-image-$KERNEL_VERSION linux-headers-$KERNEL_VERSION" > -build_deps="apt-utils libelf-dev build-essential libssl-dev python \ > -python-six wget gdb autoconf libtool git automake bzip2 debhelper \ > +build_deps="apt-utils libelf-dev build-essential libssl-dev python3 \ > +python3-six wget gdb autoconf libtool git automake bzip2 debhelper \ > dh-autoreconf openssl" > > apt-get update > -- > 2.20.1 (Apple Git-117) > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
Done. Does it make sense for this to be in both repos? On Mon, Oct 14, 2019 at 07:48:14PM -0700, aginwala wrote: > Hi Ben: > > Can you also push this to OVS master? Got it merged in ovn repo already. > > On Fri, Oct 11, 2019 at 2:06 PM <amginwal@gmail.com> wrote: > > > From: Aliasgar Ginwala <aginwala@ebay.com> > > > > building ovn/ovs container breaks while configure: > > checking for Python 3 (version 3.4 or later)... no > > configure: error: Python 3.4 or later is required but not found in > > /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin, > > please install it or set to point to it > > > > As per commit 1ca0323e7c29dc7ef5a615c265df0460208f92de > > Require Python 3 and remove support for Python 2. > > > > Signed-off-by: Aliasgar Ginwala <aginwala@ebay.com> > > --- > > utilities/docker/debian/build-kernel-modules.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/utilities/docker/debian/build-kernel-modules.sh > > b/utilities/docker/debian/build-kernel-modules.sh > > index 1b12720b9..18ac35764 100755 > > --- a/utilities/docker/debian/build-kernel-modules.sh > > +++ b/utilities/docker/debian/build-kernel-modules.sh > > @@ -18,8 +18,8 @@ GITHUB_SRC=$3 > > > > # Install deps > > linux="linux-image-$KERNEL_VERSION linux-headers-$KERNEL_VERSION" > > -build_deps="apt-utils libelf-dev build-essential libssl-dev python \ > > -python-six wget gdb autoconf libtool git automake bzip2 debhelper \ > > +build_deps="apt-utils libelf-dev build-essential libssl-dev python3 \ > > +python3-six wget gdb autoconf libtool git automake bzip2 debhelper \ > > dh-autoreconf openssl" > > > > apt-get update > > -- > > 2.20.1 (Apple Git-117) > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Ben: Yes ovs container build script is for ovs and similar for ovn; as user just using ovs in containers don't need to clone/use ovn stuff and vice versa. Regards, Aliasgar
diff --git a/utilities/docker/debian/build-kernel-modules.sh b/utilities/docker/debian/build-kernel-modules.sh index 1b12720b9..18ac35764 100755 --- a/utilities/docker/debian/build-kernel-modules.sh +++ b/utilities/docker/debian/build-kernel-modules.sh @@ -18,8 +18,8 @@ GITHUB_SRC=$3 # Install deps linux="linux-image-$KERNEL_VERSION linux-headers-$KERNEL_VERSION" -build_deps="apt-utils libelf-dev build-essential libssl-dev python \ -python-six wget gdb autoconf libtool git automake bzip2 debhelper \ +build_deps="apt-utils libelf-dev build-essential libssl-dev python3 \ +python3-six wget gdb autoconf libtool git automake bzip2 debhelper \ dh-autoreconf openssl" apt-get update