| Message ID | 1570126285-17369-2-git-send-email-david.marchand@redhat.com |
|---|---|
| State | Accepted |
| Delegated to: | Ian Stokes |
| Headers | show |
| Series | [ovs-dev,v2,1/2] sparse: Get rid of obsolete rte_flow header. | expand |
On 10/3/2019 7:11 PM, David Marchand wrote: > Make this branch point to current dpdk master branch so that we can > track API breakage. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > Changelog since v1: > - since building DPDK is controlled by either setting DPDK or DPDK_SHARED > variables, we can set DPDK_VER globally (Ilya), > Thanks for this David, builds fine locally and in travis for myself. https://travis-ci.org/istokes/ovs/builds/597711196 @Ilya, are you ok with the changes addressed in v2. Regards Ian > --- > .travis.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 6802631..73d8f0c 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -28,7 +28,9 @@ addons: > > before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh > > -before_script: export PATH=$PATH:$HOME/bin > +before_script: > + - export PATH=$PATH:$HOME/bin > + - export DPDK_VER=refs/heads/master > > env: > - OPTS="--disable-ssl" >
On 15.10.2019 14:59, Stokes, Ian wrote: > > > On 10/3/2019 7:11 PM, David Marchand wrote: >> Make this branch point to current dpdk master branch so that we can >> track API breakage. >> >> Signed-off-by: David Marchand <david.marchand@redhat.com> >> --- >> Changelog since v1: >> - since building DPDK is controlled by either setting DPDK or DPDK_SHARED >> variables, we can set DPDK_VER globally (Ilya), >> > > Thanks for this David, > > builds fine locally and in travis for myself. > > https://travis-ci.org/istokes/ovs/builds/597711196 > > @Ilya, are you ok with the changes addressed in v2. > Yes. It looks good. Acked-by: Ilya Maximets <i.maximets@ovn.org> One thing that might be useful is to add a banner like "THIS SHOULD NEVER GO TO MASTER BRANCH" to the commit message. Just in case. What do you think? Best regards, Ilya Maximets.
On 10/15/2019 2:04 PM, Ilya Maximets wrote: > On 15.10.2019 14:59, Stokes, Ian wrote: >> >> >> On 10/3/2019 7:11 PM, David Marchand wrote: >>> Make this branch point to current dpdk master branch so that we can >>> track API breakage. >>> >>> Signed-off-by: David Marchand <david.marchand@redhat.com> >>> --- >>> Changelog since v1: >>> - since building DPDK is controlled by either setting DPDK or >>> DPDK_SHARED >>> variables, we can set DPDK_VER globally (Ilya), >>> >> >> Thanks for this David, >> >> builds fine locally and in travis for myself. >> >> https://travis-ci.org/istokes/ovs/builds/597711196 >> >> @Ilya, are you ok with the changes addressed in v2. >> > > Yes. It looks good. > Acked-by: Ilya Maximets <i.maximets@ovn.org> > > One thing that might be useful is to add a banner like > "THIS SHOULD NEVER GO TO MASTER BRANCH" to the commit message. > Just in case. What do you think? +1, I've added this and pushed to dpdk-latest. Thanks Ian
diff --git a/.travis.yml b/.travis.yml index 6802631..73d8f0c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -28,7 +28,9 @@ addons: before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh -before_script: export PATH=$PATH:$HOME/bin +before_script: + - export PATH=$PATH:$HOME/bin + - export DPDK_VER=refs/heads/master env: - OPTS="--disable-ssl"
Make this branch point to current dpdk master branch so that we can track API breakage. Signed-off-by: David Marchand <david.marchand@redhat.com> --- Changelog since v1: - since building DPDK is controlled by either setting DPDK or DPDK_SHARED variables, we can set DPDK_VER globally (Ilya), --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)