| Message ID | 20191009141008.6756-1-aserdean@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] appveyor: Update OpenSSL link and python3 to path | expand |
Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 93 characters long (recommended limit is 79) #29 FILE: appveyor.yml:8: - ps: New-Item -Type HardLink -Path "C:\Python37\python3.exe" -Value "C:\Python37\python.exe" Lines checked: 56, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On Wed, Oct 09, 2019 at 05:10:08PM +0300, Alin Gabriel Serdean wrote: > This patch fixes the appveyor build by adding the python version 3 to path > as per: > https://www.appveyor.com/docs/windows-images-software/#python > > We also create a hardlink for python3 in the same directory to ease up scripts > which checks for its existence. > > This patch also bumps the OpenSSL version from 1.0.2n to 1.0.2t. > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> Thanks. Sorry I broke this. I am amused that there is a "/verysilent" option. Acked-by: Ben Pfaff <blp@ovn.org>
On Wed, Oct 09, 2019 at 09:44:14AM -0700, Ben Pfaff wrote: > On Wed, Oct 09, 2019 at 05:10:08PM +0300, Alin Gabriel Serdean wrote: > > This patch fixes the appveyor build by adding the python version 3 to path > > as per: > > https://www.appveyor.com/docs/windows-images-software/#python > > > > We also create a hardlink for python3 in the same directory to ease up scripts > > which checks for its existence. > > > > This patch also bumps the OpenSSL version from 1.0.2n to 1.0.2t. > > > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> > > Thanks. Sorry I broke this. > > I am amused that there is a "/verysilent" option. > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks! I applied to master. William
diff --git a/appveyor.yml b/appveyor.yml index b30122744..ee72a948b 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -4,6 +4,8 @@ branches: - master clone_folder: C:\openvswitch init: +- ps: $env:PATH ="C:\Python37;"+$env:PATH +- ps: New-Item -Type HardLink -Path "C:\Python37\python3.exe" -Value "C:\Python37\python.exe" - ps: >- mkdir C:\pthreads-win32 @@ -15,9 +17,9 @@ init: Invoke-WebRequest $source -OutFile $destination - $source = "https://slproweb.com/download/Win32OpenSSL-1_0_2n.exe" + $source = "https://slproweb.com/download/Win32OpenSSL-1_0_2t.exe" - $destination = "C:\ovs-build-downloads\Win32OpenSSL-1_0_2n.exe" + $destination = "C:\ovs-build-downloads\Win32OpenSSL-1_0_2t.exe" Invoke-WebRequest $source -OutFile $destination @@ -27,7 +29,7 @@ init: cd C:\ovs-build-downloads - .\Win32OpenSSL-1_0_2n.exe /silent /verysilent /sp- /suppressmsgboxes + .\Win32OpenSSL-1_0_2t.exe /silent /verysilent /sp- /suppressmsgboxes Start-Sleep -s 30
This patch fixes the appveyor build by adding the python version 3 to path as per: https://www.appveyor.com/docs/windows-images-software/#python We also create a hardlink for python3 in the same directory to ease up scripts which checks for its existence. This patch also bumps the OpenSSL version from 1.0.2n to 1.0.2t. Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> --- appveyor.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)