Message ID | 20190927112703.17745-1-sgarzare@redhat.com |
---|---|
Headers | show |
Series | vsock: add multi-transports support | expand |
> From: Stefano Garzarella <sgarzare@redhat.com> > Sent: Friday, September 27, 2019 4:27 AM > ... > Patch 9 changes the hvs_remote_addr_init(). setting the > VMADDR_CID_HOST as remote CID instead of VMADDR_CID_ANY to make > the choice of transport to be used work properly. > @Dexuan Could this change break anything? This patch looks good to me. > @Dexuan please can you test on HyperV that I didn't break anything > even without nested VMs? I did some quick tests with the 13 patches in a Linux VM (this is not a nested VM) on Hyper-V and it looks nothing is broken. :-) > I'll try to setup a Windows host where to test the nested VMs I suppose you're going to run a Linux VM on a Hyper-V host, and the Linux VM itself runs KVM/VmWare so it can create its own child VMs. IMO this is similar to the test "nested KVM ( ..., virtio-transport[L1,L2]" you have done. . Thanks! Dexuan
On Fri, Oct 04, 2019 at 12:04:46AM +0000, Dexuan Cui wrote: > > From: Stefano Garzarella <sgarzare@redhat.com> > > Sent: Friday, September 27, 2019 4:27 AM > > ... > > Patch 9 changes the hvs_remote_addr_init(). setting the > > VMADDR_CID_HOST as remote CID instead of VMADDR_CID_ANY to make > > the choice of transport to be used work properly. > > @Dexuan Could this change break anything? > > This patch looks good to me. > Thank you very much for your reviews! > > @Dexuan please can you test on HyperV that I didn't break anything > > even without nested VMs? > > I did some quick tests with the 13 patches in a Linux VM (this is not > a nested VM) on Hyper-V and it looks nothing is broken. :-) > Great :-) > > I'll try to setup a Windows host where to test the nested VMs > > I suppose you're going to run a Linux VM on a Hyper-V host, > and the Linux VM itself runs KVM/VmWare so it can create its own child > VMs. IMO this is similar to the test "nested KVM ( ..., virtio-transport[L1,L2]" > you have done. Yes, I think so. If the Hyper-V transport works well without nested VM, it should work the same with a nested KVM/VMware. Thanks, Stefano
On Fri, Sep 27, 2019 at 01:26:50PM +0200, Stefano Garzarella wrote: > Hi all, > this series adds the multi-transports support to vsock, following > this proposal: > https://www.spinics.net/lists/netdev/msg575792.html Nice series! I have left a few comments but overall it looks promising. Stefan
On Wed, Oct 09, 2019 at 02:29:52PM +0100, Stefan Hajnoczi wrote: > On Fri, Sep 27, 2019 at 01:26:50PM +0200, Stefano Garzarella wrote: > > Hi all, > > this series adds the multi-transports support to vsock, following > > this proposal: > > https://www.spinics.net/lists/netdev/msg575792.html > > Nice series! I have left a few comments but overall it looks promising. Thank you very much for the comments! I'll follow them and respin. Cheers, Stefano