Message ID | 1569332482-11931-1-git-send-email-damjan.skvarc@gmail.com |
---|---|
State | Accepted |
Commit | e35626355d9972c83b29491306b1eff94bb219f6 |
Headers | show |
Series | [ovs-dev,1/1] ovs-ofctl: fix memory leak in open_vconn__() function | expand |
On Tue, Sep 24, 2019 at 03:41:22PM +0200, Damijan Skvarc wrote:
> Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com>
Thanks. I applied this to master.
There's another memory leak here (in the run()) call, but it's even less
worth fixing than this one.
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 06289d2..b2350e0 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -590,6 +590,8 @@ open_vconn__(const char *name, enum open_target target, } else if (!open_vconn_socket(socket_name, vconnp)) { /* Fall Through. */ } else { + free(bridge_path); + free(socket_name); ovs_fatal(0, "%s is not a bridge or a socket", name); }
Signed-off-by: Damijan Skvarc <damjan.skvarc@gmail.com> --- utilities/ovs-ofctl.c | 2 ++ 1 file changed, 2 insertions(+)