| Message ID | 20190911075215.78047-7-dmitry.torokhov@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for software nodes to gpiolib | expand |
Hi Dmitry, (CC'ing Heikki as the original author of software nodes support) Thank you for the patch. On Wed, Sep 11, 2019 at 12:52:10AM -0700, Dmitry Torokhov wrote: > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit s/bit/but/ > works with arbitrary firmware node. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> On a side note, as I'm not very familiar with software nodes, I tried to see how they are to be used, and it seems they are completely undocumented :-( Heikki, is this something that could be fixed ? > --- > > drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index 61cc2354ef1b..d9c9c9ebad2b 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -284,8 +284,8 @@ static int tfp410_get_connector_properties(struct tfp410 *dvi) > else > dvi->connector_type = DRM_MODE_CONNECTOR_DVID; > > - dvi->hpd = fwnode_get_named_gpiod(&connector_node->fwnode, > - "hpd-gpios", 0, GPIOD_IN, "hpd"); > + dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode, > + "hpd", 0, GPIOD_IN, "hpd"); > if (IS_ERR(dvi->hpd)) { > ret = PTR_ERR(dvi->hpd); > dvi->hpd = NULL;
On Sat, Sep 21, 2019 at 02:12:28AM +0300, Laurent Pinchart wrote: > Hi Dmitry, > > (CC'ing Heikki as the original author of software nodes support) > > Thank you for the patch. > > On Wed, Sep 11, 2019 at 12:52:10AM -0700, Dmitry Torokhov wrote: > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit > > s/bit/but/ > > > works with arbitrary firmware node. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > On a side note, as I'm not very familiar with software nodes, I tried to > see how they are to be used, and it seems they are completely > undocumented :-( Heikki, is this something that could be fixed ? OK. I'll start writing API documentation for it. thanks,
Hi Heikki, On Mon, Sep 23, 2019 at 06:03:33PM +0300, Heikki Krogerus wrote: > On Sat, Sep 21, 2019 at 02:12:28AM +0300, Laurent Pinchart wrote: > > Hi Dmitry, > > > > (CC'ing Heikki as the original author of software nodes support) > > > > Thank you for the patch. > > > > On Wed, Sep 11, 2019 at 12:52:10AM -0700, Dmitry Torokhov wrote: > > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit > > > > s/bit/but/ > > > > > works with arbitrary firmware node. > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > On a side note, as I'm not very familiar with software nodes, I tried to > > see how they are to be used, and it seems they are completely > > undocumented :-( Heikki, is this something that could be fixed ? > > OK. I'll start writing API documentation for it. That's great, thanks ! I'll do my best to review it if you CC me.
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index 61cc2354ef1b..d9c9c9ebad2b 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c +++ b/drivers/gpu/drm/bridge/ti-tfp410.c @@ -284,8 +284,8 @@ static int tfp410_get_connector_properties(struct tfp410 *dvi) else dvi->connector_type = DRM_MODE_CONNECTOR_DVID; - dvi->hpd = fwnode_get_named_gpiod(&connector_node->fwnode, - "hpd-gpios", 0, GPIOD_IN, "hpd"); + dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode, + "hpd", 0, GPIOD_IN, "hpd"); if (IS_ERR(dvi->hpd)) { ret = PTR_ERR(dvi->hpd); dvi->hpd = NULL;
Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit works with arbitrary firmware node. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)