diff mbox series

net: fec: Allow the driver to be built for ARM64 SoCs such as i.MX8

Message ID 20190807114332.13312-2-frieder.schrempf@kontron.de
State Not Applicable
Delegated to: David Miller
Headers show
Series net: fec: Allow the driver to be built for ARM64 SoCs such as i.MX8 | expand

Commit Message

Frieder Schrempf Aug. 7, 2019, 11:44 a.m. UTC 
From: Frieder Schrempf <frieder.schrempf@kontron.de>

The FEC ethernet controller is used in some ARM64 SoCs such as i.MX8.
To make use of it, append ARM64 to the list of dependencies.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 drivers/net/ethernet/freescale/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Aug. 7, 2019, 12:20 p.m. UTC | #1 
Hi Frieder,

On Wed, Aug 7, 2019 at 9:04 AM Schrempf Frieder
<frieder.schrempf@kontron.de> wrote:
>
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> The FEC ethernet controller is used in some ARM64 SoCs such as i.MX8.
> To make use of it, append ARM64 to the list of dependencies.

ARCH_MXC is also used by i.MX8, so there is no need for such change.

By the way: arch/arm64/configs/defconfig has CONFIG_FEC=y by default.
Frieder Schrempf Aug. 7, 2019, 1:25 p.m. UTC | #2 
On 07.08.19 14:20, Fabio Estevam wrote:
> Hi Frieder,
> 
> On Wed, Aug 7, 2019 at 9:04 AM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
>>
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> The FEC ethernet controller is used in some ARM64 SoCs such as i.MX8.
>> To make use of it, append ARM64 to the list of dependencies.
> 
> ARCH_MXC is also used by i.MX8, so there is no need for such change.

You're right of course. I somehow managed to mess up my defconfig. I 
started over with a clean config from arch/arm64/configs/defconfig and 
everything seems fine now. Sorry for the noise.

> 
> By the way: arch/arm64/configs/defconfig has CONFIG_FEC=y by default.
>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index 6a7e8993119f..f7f4e073d955 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -23,7 +23,7 @@  if NET_VENDOR_FREESCALE
 config FEC
 	tristate "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
 	depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
-		   ARCH_MXC || SOC_IMX28 || COMPILE_TEST)
+		   ARCH_MXC || ARM64 || SOC_IMX28 || COMPILE_TEST)
 	default ARCH_MXC || SOC_IMX28 if ARM
 	select PHYLIB
 	imply PTP_1588_CLOCK