Message ID | 1304897915-8538-1-git-send-email-tytso@mit.edu |
---|---|
State | Accepted, archived |
Headers | show |
On May 8, 2011, at 17:38, Theodore Ts'o wrote: > If we somehow wrap, we don't want to keep printing the warning message > over and over again. > > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Acked-by: Andreas Dilger <adilger@dilger.ca> > --- > fs/jbd2/journal.c | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 8c10004..cd2d341 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -500,10 +500,11 @@ int __jbd2_log_start_commit(journal_t *journal, tid_t target) > /* This should never happen, but if it does, preserve > the evidence before kjournald goes into a loop and > increments j_commit_sequence beyond all recognition. */ > - WARN(1, "jbd: bad log_start_commit: %u %u %u %u\n", > - journal->j_commit_request, journal->j_commit_sequence, > - target, journal->j_running_transaction ? > - journal->j_running_transaction->t_tid : 0); > + WARN_ONCE(1, "jbd: bad log_start_commit: %u %u %u %u\n", > + journal->j_commit_request, > + journal->j_commit_sequence, > + target, journal->j_running_transaction ? > + journal->j_running_transaction->t_tid : 0); > return 0; > } > > -- > 1.7.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 8c10004..cd2d341 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -500,10 +500,11 @@ int __jbd2_log_start_commit(journal_t *journal, tid_t target) /* This should never happen, but if it does, preserve the evidence before kjournald goes into a loop and increments j_commit_sequence beyond all recognition. */ - WARN(1, "jbd: bad log_start_commit: %u %u %u %u\n", - journal->j_commit_request, journal->j_commit_sequence, - target, journal->j_running_transaction ? - journal->j_running_transaction->t_tid : 0); + WARN_ONCE(1, "jbd: bad log_start_commit: %u %u %u %u\n", + journal->j_commit_request, + journal->j_commit_sequence, + target, journal->j_running_transaction ? + journal->j_running_transaction->t_tid : 0); return 0; }
If we somehow wrap, we don't want to keep printing the warning message over and over again. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> --- fs/jbd2/journal.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)