| Message ID | 20190723194505.28060-1-uwe@kleine-koenig.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | ARM: kirkwood: ts219: disable the SoC's RTC | expand |
On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote: > The internal RTC doesn't work, loading the driver only yields > > rtc-mv f1010300.rtc: internal RTC not ticking > > . So disable it. > > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> > --- > arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi > index a88eb22070a1..994cabcf4b51 100644 > --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi > +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi > @@ -104,3 +104,11 @@ > &pcie0 { > status = "okay"; > }; > + > +&rtc { > + /* > + * There is a s35390a available on the i2c bus, the internal rtc isn't > + * working (probably no crystal assembled). > + */ > + status = "disabled"; > +}; You could also use the aliases to ensure rtc0 is the s35390a. This would solve the initial issue. > -- > 2.20.1 >
On 7/23/19 10:03 PM, Alexandre Belloni wrote: > On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote: >> The internal RTC doesn't work, loading the driver only yields >> >> rtc-mv f1010300.rtc: internal RTC not ticking >> >> . So disable it. >> >> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> >> --- >> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi >> index a88eb22070a1..994cabcf4b51 100644 >> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi >> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi >> @@ -104,3 +104,11 @@ >> &pcie0 { >> status = "okay"; >> }; >> + >> +&rtc { >> + /* >> + * There is a s35390a available on the i2c bus, the internal rtc isn't >> + * working (probably no crystal assembled). >> + */ >> + status = "disabled"; >> +}; > > You could also use the aliases to ensure rtc0 is the s35390a. This would > solve the initial issue. What do you assume is my initial issue? Adding the alias doesn't make the above message disappear from the boot log. Best regards Uwe
On Tue, Jul 23, 2019 at 09:45:05PM +0200, Uwe Kleine-König wrote: > The internal RTC doesn't work, loading the driver only yields > > rtc-mv f1010300.rtc: internal RTC not ticking > > . So disable it. > > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Hi Uwe This should probably go via the mvebu maintainers, who look after the DT files. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 23/07/2019 22:24:18+0200, Uwe Kleine-König wrote: > On 7/23/19 10:03 PM, Alexandre Belloni wrote: > > On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote: > >> The internal RTC doesn't work, loading the driver only yields > >> > >> rtc-mv f1010300.rtc: internal RTC not ticking > >> > >> . So disable it. > >> > >> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> > >> --- > >> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi > >> index a88eb22070a1..994cabcf4b51 100644 > >> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi > >> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi > >> @@ -104,3 +104,11 @@ > >> &pcie0 { > >> status = "okay"; > >> }; > >> + > >> +&rtc { > >> + /* > >> + * There is a s35390a available on the i2c bus, the internal rtc isn't > >> + * working (probably no crystal assembled). > >> + */ > >> + status = "disabled"; > >> +}; > > > > You could also use the aliases to ensure rtc0 is the s35390a. This would > > solve the initial issue. > > What do you assume is my initial issue? Adding the alias doesn't make > the above message disappear from the boot log. > I overlooked that the rtc is not working at all (and I thought it only needed some init in u-boot like the armada38x). Seems good to me then.
diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi index a88eb22070a1..994cabcf4b51 100644 --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi @@ -104,3 +104,11 @@ &pcie0 { status = "okay"; }; + +&rtc { + /* + * There is a s35390a available on the i2c bus, the internal rtc isn't + * working (probably no crystal assembled). + */ + status = "disabled"; +};
The internal RTC doesn't work, loading the driver only yields rtc-mv f1010300.rtc: internal RTC not ticking . So disable it. Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> --- arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)