| Message ID | 20190710074552.74394-1-xingwu.yang@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | ipvs: remove unnecessary space | expand |
On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > this patch removes the extra space. > > Signed-off-by: yangxingwu <xingwu.yang@gmail.com> Thanks, this looks good to me. Acked-by: Simon Horman <horms@verge.net.au> Pablo, please consider including this in nf-next. > --- > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > index 94d9d34..98e358e 100644 > --- a/net/netfilter/ipvs/ip_vs_mh.c > +++ b/net/netfilter/ipvs/ip_vs_mh.c > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > return 0; > } > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > - sizeof(unsigned long), GFP_KERNEL); > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > + sizeof(unsigned long), GFP_KERNEL); > if (!table) > return -ENOMEM; > > -- > 1.8.3.1 >
On Wed, 2019-07-10 at 10:06 +0200, Simon Horman wrote: > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > this patch removes the extra space. > > > > Signed-off-by: yangxingwu <xingwu.yang@gmail.com> > > Thanks, this looks good to me. > > Acked-by: Simon Horman <horms@verge.net.au> > > Pablo, please consider including this in nf-next. > > > > --- > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > index 94d9d34..98e358e 100644 > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > return 0; > > } > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > - sizeof(unsigned long), GFP_KERNEL); > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > + sizeof(unsigned long), GFP_KERNEL); bitmap_alloc? > > if (!table) > > return -ENOMEM; > > > > -- > > 1.8.3.1 > >
On Wed, Jul 10, 2019 at 10:06:09AM +0200, Simon Horman wrote: > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > --- > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > index 94d9d34..98e358e 100644 > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > return 0; > > } > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > - sizeof(unsigned long), GFP_KERNEL); > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > + sizeof(unsigned long), GFP_KERNEL); May I ask one thing? :-) Please, remove all unnecessary spaces in one go, search for: git grep "= " in the netfilter tree, and send a v2 for this one. Thanks.
ok I will remove all unnecessary spaces and send the v2 patch Thansk Pablo Pablo Neira Ayuso <pablo@netfilter.org> 于2019年7月15日周一 下午4:27写道： > > On Wed, Jul 10, 2019 at 10:06:09AM +0200, Simon Horman wrote: > > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > > --- > > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > > index 94d9d34..98e358e 100644 > > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > > return 0; > > > } > > > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > > - sizeof(unsigned long), GFP_KERNEL); > > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > > + sizeof(unsigned long), GFP_KERNEL); > > May I ask one thing? :-) > > Please, remove all unnecessary spaces in one go, search for: > > git grep "= " > > in the netfilter tree, and send a v2 for this one. > > Thanks.
Pablo v2 has been sent I made the following changes: 1. remove all unnecessary spaces in one go 2. revert bitmap_alloc ( since it's irrelevant to this subject) 3. chenge subject to "net/netfiler:remove unnecessary space" thanks Pablo Neira Ayuso <pablo@netfilter.org> 于2019年7月15日周一 下午4:27写道： > > On Wed, Jul 10, 2019 at 10:06:09AM +0200, Simon Horman wrote: > > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > > --- > > > net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c > > > index 94d9d34..98e358e 100644 > > > --- a/net/netfilter/ipvs/ip_vs_mh.c > > > +++ b/net/netfilter/ipvs/ip_vs_mh.c > > > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, > > > return 0; > > > } > > > > > > - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > > - sizeof(unsigned long), GFP_KERNEL); > > > + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), > > > + sizeof(unsigned long), GFP_KERNEL); > > May I ask one thing? :-) > > Please, remove all unnecessary spaces in one go, search for: > > git grep "= " > > in the netfilter tree, and send a v2 for this one. > > Thanks.
diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c index 94d9d34..98e358e 100644 --- a/net/netfilter/ipvs/ip_vs_mh.c +++ b/net/netfilter/ipvs/ip_vs_mh.c @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s, return 0; } - table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), - sizeof(unsigned long), GFP_KERNEL); + table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE), + sizeof(unsigned long), GFP_KERNEL); if (!table) return -ENOMEM;
this patch removes the extra space. Signed-off-by: yangxingwu <xingwu.yang@gmail.com> --- net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)