| Message ID | 20190613065102.GA16334@mwanda |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net: phy: sfp: clean up a condition | expand |
Dan Carpenter writes: > The acpi_node_get_property_reference() doesn't return ACPI error codes, > it just returns regular negative kernel error codes. This patch doesn't > affect run time, it's just a clean up. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- Reviewed-by: Ruslan Babayev <ruslan@babayev.com>
On Thu, Jun 13, 2019 at 09:51:02AM +0300, Dan Carpenter wrote: > The acpi_node_get_property_reference() doesn't return ACPI error codes, > it just returns regular negative kernel error codes. This patch doesn't > affect run time, it's just a clean up. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/phy/sfp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > index a991c80e6567..8a99307c1c39 100644 > --- a/drivers/net/phy/sfp.c > +++ b/drivers/net/phy/sfp.c > @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev) > int ret; > > ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args); > - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) { > + if (ret || !is_acpi_device_node(args.fwnode)) { > dev_err(&pdev->dev, "missing 'i2c-bus' property\n"); > return -ENODEV; If "ret" is a Linux error code, should we print its value when reporting the error so we know why the failure occurred, and propagate the error code? > } > -- > 2.20.1 > >
On Thu, Jun 13, 2019 at 07:00:16PM +0100, Russell King - ARM Linux admin wrote: > On Thu, Jun 13, 2019 at 09:51:02AM +0300, Dan Carpenter wrote: > > The acpi_node_get_property_reference() doesn't return ACPI error codes, > > it just returns regular negative kernel error codes. This patch doesn't > > affect run time, it's just a clean up. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > --- > > drivers/net/phy/sfp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > > index a991c80e6567..8a99307c1c39 100644 > > --- a/drivers/net/phy/sfp.c > > +++ b/drivers/net/phy/sfp.c > > @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev) > > int ret; > > > > ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args); > > - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) { > > + if (ret || !is_acpi_device_node(args.fwnode)) { > > dev_err(&pdev->dev, "missing 'i2c-bus' property\n"); > > return -ENODEV; > > If "ret" is a Linux error code, should we print its value when reporting > the error so we know why the failure occurred, and propagate the error > code? We can't propagate the error code because we might have failed because acpi_node_get_property_reference() succeeded but it's not a device node. regards, dan carpenter
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Thu, 13 Jun 2019 09:51:02 +0300 > The acpi_node_get_property_reference() doesn't return ACPI error codes, > it just returns regular negative kernel error codes. This patch doesn't > affect run time, it's just a clean up. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to net-next.
On Fri, Jun 14, 2019 at 07:21:48PM -0700, David Miller wrote: > From: Dan Carpenter <dan.carpenter@oracle.com> > Date: Thu, 13 Jun 2019 09:51:02 +0300 > > > The acpi_node_get_property_reference() doesn't return ACPI error codes, > > it just returns regular negative kernel error codes. This patch doesn't > > affect run time, it's just a clean up. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Applied to net-next. I meant to say net-next but I made a typo. :/ regards, dan carpenter
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index a991c80e6567..8a99307c1c39 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev) int ret; ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args); - if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) { + if (ret || !is_acpi_device_node(args.fwnode)) { dev_err(&pdev->dev, "missing 'i2c-bus' property\n"); return -ENODEV; }
The acpi_node_get_property_reference() doesn't return ACPI error codes, it just returns regular negative kernel error codes. This patch doesn't affect run time, it's just a clean up. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/phy/sfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)