| Message ID | 20190408152145.29005-1-chrubis@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Makefile: Remove IDcheck.sh | expand |
> On Apr 8, 2019, at 08:21, Cyril Hrubis <chrubis@suse.cz> wrote: > > There is no point in running the IDcheck on 'make install' as it's > completely pointless to print ignored errors on installation which is > only confusing users. > > Also the same script is even executed as a part of runltp script which > is more appropriate place for it. LGTM! Reviewed-by: Enji Cooper <yaneurabeya@gmail.com> > Signed-off-by: Cyril Hrubis <chrubis@suse.cz> > --- > Makefile | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/Makefile b/Makefile > index 170c2da20..c46d050ce 100644 > --- a/Makefile > +++ b/Makefile > @@ -21,11 +21,6 @@ > # Ngie Cooper, July 2009 > # > > -# Force IDcheck.sh to fix any issues found with $(DESTDIR)/etc/group and > -# $(DESTDIR)/etc/passwd automatically when after running the top-level > -# install target. > -CREATE_ENTRIES ?= 0 > - > top_srcdir ?= $(CURDIR) > > include $(top_srcdir)/include/mk/env_pre.mk > @@ -42,9 +37,6 @@ vpath %.in $(top_srcdir)/include > vpath %.m4 $(top_srcdir)/m4 > vpath %.mk $(top_srcdir)/mk:$(top_srcdir)/mk/include > > -# Skip running IDcheck.sh at the end of install? > -SKIP_IDCHECK ?= 0 > - > # User wants uclinux binaries? > UCLINUX ?= 0 > export UCLINUX > @@ -202,17 +194,6 @@ $(INSTALL_TARGETS): $(INSTALL_DIR) $(DESTDIR)/$(bindir) > > ## Install > install: $(INSTALL_TARGETS) > -ifeq ($(SKIP_IDCHECK),0) > - -@CREATE_ENTRIES=$(CREATE_ENTRIES) \ > - DESTDIR="$(DESTDIR)" \ > - "$(top_srcdir)/IDcheck.sh" > -else > - @echo "*******************************************************" > - @echo "** Will not run IDcheck.sh (SKIP_IDCHECK set to 1). **" > - @echo "*******************************************************" > -endif > - > -## Misc targets. > > ## Help > .PHONY: help > -- > 2.19.2 > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp
Hi! Pushed, thanks.
Hi Cyril, > There is no point in running the IDcheck on 'make install' as it's > completely pointless to print ignored errors on installation which is > only confusing users. +1 > Also the same script is even executed as a part of runltp script which > is more appropriate place for it. +1 I hope to implement one day tst_user() and tst_group() [1]. Than IDcheck.sh could be removed :). Kind regards, Petr [1] https://github.com/linux-test-project/ltp/issues/468
diff --git a/Makefile b/Makefile index 170c2da20..c46d050ce 100644 --- a/Makefile +++ b/Makefile @@ -21,11 +21,6 @@ # Ngie Cooper, July 2009 # -# Force IDcheck.sh to fix any issues found with $(DESTDIR)/etc/group and -# $(DESTDIR)/etc/passwd automatically when after running the top-level -# install target. -CREATE_ENTRIES ?= 0 - top_srcdir ?= $(CURDIR) include $(top_srcdir)/include/mk/env_pre.mk @@ -42,9 +37,6 @@ vpath %.in $(top_srcdir)/include vpath %.m4 $(top_srcdir)/m4 vpath %.mk $(top_srcdir)/mk:$(top_srcdir)/mk/include -# Skip running IDcheck.sh at the end of install? -SKIP_IDCHECK ?= 0 - # User wants uclinux binaries? UCLINUX ?= 0 export UCLINUX @@ -202,17 +194,6 @@ $(INSTALL_TARGETS): $(INSTALL_DIR) $(DESTDIR)/$(bindir) ## Install install: $(INSTALL_TARGETS) -ifeq ($(SKIP_IDCHECK),0) - -@CREATE_ENTRIES=$(CREATE_ENTRIES) \ - DESTDIR="$(DESTDIR)" \ - "$(top_srcdir)/IDcheck.sh" -else - @echo "*******************************************************" - @echo "** Will not run IDcheck.sh (SKIP_IDCHECK set to 1). **" - @echo "*******************************************************" -endif - -## Misc targets. ## Help .PHONY: help
There is no point in running the IDcheck on 'make install' as it's completely pointless to print ignored errors on installation which is only confusing users. Also the same script is even executed as a part of runltp script which is more appropriate place for it. Signed-off-by: Cyril Hrubis <chrubis@suse.cz> --- Makefile | 19 ------------------- 1 file changed, 19 deletions(-)